[nautilus: 1/2] Disable tab detaching to avoid crash



commit 24ef9bd31ac542d5e8dd1de2f8c3c9627cd62e31
Author: Nelson Benítez León <nbenitezl+gnome gmail com>
Date:   Sat Nov 25 15:17:55 2017 +0500

    Disable tab detaching to avoid crash
    
    As reported by Antonio Fernandes in:
    https://bugzilla.gnome.org/show_bug.cgi?id=781991#c1
    
    Detaching a notebook tab into a new window through DnD
    leaves Nautilus in an inconsistent state leading to a
    crash after loading a new location.
    
    As opening a folder into a new window should be done
    through its action already present in the folder context
    menu of both files view and path bar, let's disable this
    alternative way to do it through tab detaching, as
    Nautilus code was not expecting that use pattern.
    
    Closes #137

 src/nautilus-notebook.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/src/nautilus-notebook.c b/src/nautilus-notebook.c
index 3f6b94667..b5cc5f67c 100644
--- a/src/nautilus-notebook.c
+++ b/src/nautilus-notebook.c
@@ -403,6 +403,7 @@ nautilus_notebook_add_tab (NautilusNotebook   *notebook,
     gtk_container_child_set (GTK_CONTAINER (notebook),
                              GTK_WIDGET (slot),
                              "tab-expand", TRUE,
+                             "detachable", FALSE,
                              NULL);
 
     nautilus_notebook_sync_tab_label (notebook, slot);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]