[gnome-builder] pipeline: notify of message before finish events



commit d8050490cd23683554df4ec5213aa86d92fed8b6
Author: Christian Hergert <chergert redhat com>
Date:   Thu Nov 23 03:43:06 2017 -0800

    pipeline: notify of message before finish events
    
    This allows handlers to update things before disconnecting signals.

 src/libide/buildsystem/ide-build-pipeline.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/src/libide/buildsystem/ide-build-pipeline.c b/src/libide/buildsystem/ide-build-pipeline.c
index 59c77ce..4a403b4 100644
--- a/src/libide/buildsystem/ide-build-pipeline.c
+++ b/src/libide/buildsystem/ide-build-pipeline.c
@@ -1463,6 +1463,9 @@ ide_build_pipeline_task_notify_completed (IdeBuildPipeline *self,
   self->requested_mask = 0;
   self->in_clean = FALSE;
 
+  g_clear_pointer (&self->message, g_free);
+  g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_MESSAGE]);
+
   /*
    * XXX: How do we ensure transients are executed with the part of the
    *      pipeline we care about? We might just need to ensure that :busy is
@@ -1474,7 +1477,6 @@ ide_build_pipeline_task_notify_completed (IdeBuildPipeline *self,
 
   g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_BUSY]);
   g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_PHASE]);
-  g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_MESSAGE]);
 
   /*
    * We might have a delayed addin unloading that needs to occur after the


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]