[smuxi: 1/2] Revert "Frontend-GNOME: restore cursor position in MessageTextView"
- From: Mirco M. M. Bauer <mmmbauer src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [smuxi: 1/2] Revert "Frontend-GNOME: restore cursor position in MessageTextView"
- Date: Mon, 20 Nov 2017 15:36:40 +0000 (UTC)
commit 3f2f92127f42f35cbed342a1dcbdacd0751b23cd
Author: Mirco Bauer <meebey meebey net>
Date: Mon Nov 20 23:15:40 2017 +0800
Revert "Frontend-GNOME: restore cursor position in MessageTextView"
This reverts commit 22be95388e0aaae195538a62c8637f91db888692.
Turns out this change wasn't useful for blind persons as they rely on the
position of the cursor at all times. The red marker line as visual indicator
for marking were read messages end and new messages start is not useful to them
as the red marker line "jumps" from the current/last position to the bottom of
the chat if you leave the chat. This logic makes sense because the human eye can
easily jump many messages and still knows what is going on. For blind persons
they have to follow and go through each message one by one, otherwise they will
be lost of what happened in between. The cursor gives them the full control over
where they are and where they want to move next to, while an automatic jump
is completely confusing and useless to them.
The idea here was to align the "already read messages" logic from the red marker
line with the cursor position but instead it became more confusing and harder
for blind people. Thus this change is reverted and the exact position of the
cursor needs to be retained even across restarts of Smuxi, to be an improvement
for blind users.
src/Frontend-GNOME/Views/MessageTextView.cs | 12 ------------
1 files changed, 0 insertions(+), 12 deletions(-)
---
diff --git a/src/Frontend-GNOME/Views/MessageTextView.cs b/src/Frontend-GNOME/Views/MessageTextView.cs
index ea5df8f..e9e1627 100644
--- a/src/Frontend-GNOME/Views/MessageTextView.cs
+++ b/src/Frontend-GNOME/Views/MessageTextView.cs
@@ -176,18 +176,6 @@ namespace Smuxi.Frontend.Gnome
}
CheckStyle();
};
- FocusInEvent += (o, args) => {
- if (_MarkerlineBufferPosition == 0) {
- return;
- }
- // restore the cursor position when entering the focus, for
- // example by pressing F7. This is useful for blind persons who
- // use a screen reader like orca to continue reading new unread
- // messages.
- var markerIter = Buffer.GetIterAtOffset(_MarkerlineBufferPosition);
- markerIter.ForwardLine();
- Buffer.PlaceCursor(markerIter);
- };
}
public void ApplyConfig(UserConfig config)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]