[gtk+] x11: Fix error traps in the dnd code



commit 90d502fdbd23b25298721d8b448d0fcd54ff85a7
Author: Matthias Clasen <mclasen redhat com>
Date:   Thu Nov 16 23:56:11 2017 -0500

    x11: Fix error traps in the dnd code
    
    The code for grabbing keys was using a generic
    error trap call, and more concerning, it was forgetting
    to pop the trap.

 gdk/x11/gdkdnd-x11.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/gdk/x11/gdkdnd-x11.c b/gdk/x11/gdkdnd-x11.c
index 2224320..767fd1c 100644
--- a/gdk/x11/gdkdnd-x11.c
+++ b/gdk/x11/gdkdnd-x11.c
@@ -2690,7 +2690,7 @@ drag_context_grab (GdkDragContext *context)
 
   g_set_object (&x11_context->grab_seat, seat);
 
-  gdk_error_trap_push ();
+  gdk_x11_display_error_trap_push (context->display);
 
   for (i = 0; i < G_N_ELEMENTS (grab_keys); ++i)
     {
@@ -2742,6 +2742,8 @@ drag_context_grab (GdkDragContext *context)
         }
     }
 
+  gdk_x11_display_error_trap_pop_ignored (context->display);
+
   return TRUE;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]