[pango] Drop fixup_broken_linebreaktest variable



commit 46a6496b9ea849a20c98e79f9a56bcab609dd8f9
Author: Peng Wu <alexepico gmail com>
Date:   Tue Nov 7 13:56:59 2017 +0800

    Drop fixup_broken_linebreaktest variable
    
    The fixup_broken_linebreaktest variable is not needed any more.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=789625

 tests/testboundaries_ucd.c |   21 +++++++--------------
 1 files changed, 7 insertions(+), 14 deletions(-)
---
diff --git a/tests/testboundaries_ucd.c b/tests/testboundaries_ucd.c
index 08bd2ae..53f7b4c 100644
--- a/tests/testboundaries_ucd.c
+++ b/tests/testboundaries_ucd.c
@@ -216,8 +216,7 @@ make_test_string (gchar *string,
 
 static void
 do_test (const gchar *filename,
-         AttrBits bits,
-        gboolean fixup_broken_linebreaktest)
+         AttrBits bits)
 {
   GIOChannel *channel;
   GIOStatus status;
@@ -280,12 +279,6 @@ do_test (const gchar *filename,
           PangoLogAttr *attrs = g_new (PangoLogAttr, num_attrs);
           pango_get_log_attrs (string, -1, 0, pango_language_from_string ("C"), attrs, num_attrs);
 
-         /* LineBreakTest.txt from Unicode 5.1.0 has this bug that it says
-          * breaking is allowed at the beginning of the strings, while the
-          * algorithm says it's not.  Fix that up. */
-         if (fixup_broken_linebreaktest)
-           memset (expected_attrs, 0, sizeof (expected_attrs[0]));
-
           if (! attrs_equal (attrs, expected_attrs, num_attrs, bits))
             {
               gchar *str = make_test_string (string, attrs, bits);
@@ -339,7 +332,7 @@ test_grapheme_break (void)
 #endif
   bits.bits = 0;
   bits.attr.is_cursor_position = 1;
-  do_test (filename, bits, FALSE);
+  do_test (filename, bits);
 }
 
 static void
@@ -355,7 +348,7 @@ test_emoji_break (void)
 #endif
   bits.bits = 0;
   bits.attr.is_cursor_position = 1;
-  do_test (filename, bits, FALSE);
+  do_test (filename, bits);
 }
 
 static void
@@ -371,7 +364,7 @@ test_char_break (void)
 #endif
   bits.bits = 0;
   bits.attr.is_char_break = 1;
-  do_test (filename, bits, FALSE);
+  do_test (filename, bits);
 }
 
 static void
@@ -387,7 +380,7 @@ test_word_break (void)
 #endif
   bits.bits = 0;
   bits.attr.is_word_boundary = 1;
-  do_test (filename, bits, FALSE);
+  do_test (filename, bits);
 }
 
 static void
@@ -403,7 +396,7 @@ test_sentence_break (void)
 #endif
   bits.bits = 0;
   bits.attr.is_sentence_boundary = 1;
-  do_test (filename, bits, FALSE);
+  do_test (filename, bits);
 }
 
 static void
@@ -420,7 +413,7 @@ test_line_break (void)
   bits.bits = 0;
   bits.attr.is_line_break = 1;
   bits.attr.is_mandatory_break = 1;
-  do_test (filename, bits, FALSE);
+  do_test (filename, bits);
 }
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]