[gnome-builder] snippet: remove snippet full text



commit 6ff106355f9e65cd5dc0dce96cebf5191ffac38a
Author: Christian Hergert <chergert redhat com>
Date:   Mon Nov 13 04:57:00 2017 -0800

    snippet: remove snippet full text
    
    We weren't ever using this, and it just adds lots of heap data
    for something unnecessary. We might bring something back in the
    future for snippet editing, but probably not like this.

 src/libide/snippets/ide-source-snippet-parser.c |    1 -
 src/libide/snippets/ide-source-snippet.c        |   56 -----------------------
 src/libide/snippets/ide-source-snippet.h        |    5 --
 3 files changed, 0 insertions(+), 62 deletions(-)
---
diff --git a/src/libide/snippets/ide-source-snippet-parser.c b/src/libide/snippets/ide-source-snippet-parser.c
index 771cc3b..b31b044 100644
--- a/src/libide/snippets/ide-source-snippet-parser.c
+++ b/src/libide/snippets/ide-source-snippet-parser.c
@@ -97,7 +97,6 @@ ide_source_snippet_parser_store (IdeSourceSnippetParser *parser)
     {
       snippet = ide_source_snippet_new (parser->cur_name, scope_iter->data);
       ide_source_snippet_set_description (snippet, parser->cur_desc);
-      ide_source_snippet_set_snippet_text (snippet, parser->snippet_text->str);
 
       for (chunck_iter = parser->chunks; chunck_iter; chunck_iter = chunck_iter->next)
         {
diff --git a/src/libide/snippets/ide-source-snippet.c b/src/libide/snippets/ide-source-snippet.c
index 0232705..0763af5 100644
--- a/src/libide/snippets/ide-source-snippet.c
+++ b/src/libide/snippets/ide-source-snippet.c
@@ -53,7 +53,6 @@ struct _IdeSourceSnippet
   gchar                   *trigger;
   const gchar             *language;
   gchar                   *description;
-  gchar                   *snippet_text;
 
   gint                     tab_stop;
   gint                     max_tab_stop;
@@ -69,7 +68,6 @@ enum {
   PROP_LANGUAGE,
   PROP_MARK_BEGIN,
   PROP_MARK_END,
-  PROP_SNIPPET_TEXT,
   PROP_TAB_STOP,
   PROP_TRIGGER,
   LAST_PROP
@@ -101,43 +99,6 @@ ide_source_snippet_new (const gchar *trigger,
 }
 
 /**
- * ide_source_snippet_get_snippet_text:
- * @self: a #IdeSourceSnippet
- *
- * Gets the text for the snippet.
- *
- * Returns: the snippet text.
- */
-const gchar *
-ide_source_snippet_get_snippet_text (IdeSourceSnippet *self)
-{
-  g_return_val_if_fail (IDE_IS_SOURCE_SNIPPET (self), NULL);
-
-  return self->snippet_text;
-}
-
-/**
- * ide_source_snippet_set_snippet_text:
- * @self: a #IdeSourceSnippet
- * @snippet_text: the text for the snippet
- *
- * Sets the snippet text.
- */
-void
-ide_source_snippet_set_snippet_text (IdeSourceSnippet *self,
-                                     const gchar      *snippet_text)
-{
-  g_return_if_fail (IDE_IS_SOURCE_SNIPPET (self));
-
-  if (!ide_str_equal0 (snippet_text, self->snippet_text))
-    {
-      g_free (self->snippet_text);
-      self->snippet_text = g_strdup (snippet_text);
-      g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_SNIPPET_TEXT]);
-    }
-}
-
-/**
  * ide_source_snippet_copy:
  * @self: an #IdeSourceSnippet
  *
@@ -157,7 +118,6 @@ ide_source_snippet_copy (IdeSourceSnippet *self)
                       "trigger", self->trigger,
                       "language", self->language,
                       "description", self->description,
-                      "snippet-text", self->snippet_text,
                       NULL);
 
   for (guint i = 0; i < self->chunks->len; i++)
@@ -1158,7 +1118,6 @@ ide_source_snippet_finalize (GObject *object)
 
   g_clear_pointer (&self->description, g_free);
   g_clear_pointer (&self->trigger, g_free);
-  g_clear_pointer (&self->snippet_text, g_free);
 
   G_OBJECT_CLASS (ide_source_snippet_parent_class)->finalize (object);
 
@@ -1199,10 +1158,6 @@ ide_source_snippet_get_property (GObject    *object,
       g_value_set_string (value, self->description);
       break;
 
-    case PROP_SNIPPET_TEXT:
-      g_value_set_string (value, self->snippet_text);
-      break;
-
     case PROP_TAB_STOP:
       g_value_set_uint (value, self->tab_stop);
       break;
@@ -1234,10 +1189,6 @@ ide_source_snippet_set_property (GObject      *object,
       ide_source_snippet_set_description (self, g_value_get_string (value));
       break;
 
-    case PROP_SNIPPET_TEXT:
-      ide_source_snippet_set_snippet_text (self, g_value_get_string (value));
-      break;
-
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
     }
@@ -1304,13 +1255,6 @@ ide_source_snippet_class_init (IdeSourceSnippetClass *klass)
                       -1,
                       (G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
 
-  properties [PROP_SNIPPET_TEXT] =
-    g_param_spec_string ("snippet-text",
-                         "Snippet Text",
-                         "The entire snippet text from the source file.",
-                         NULL,
-                         (G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
-
   g_object_class_install_properties (object_class, LAST_PROP, properties);
 }
 
diff --git a/src/libide/snippets/ide-source-snippet.h b/src/libide/snippets/ide-source-snippet.h
index b2943b8..9ef391b 100644
--- a/src/libide/snippets/ide-source-snippet.h
+++ b/src/libide/snippets/ide-source-snippet.h
@@ -67,10 +67,5 @@ void                     ide_source_snippet_get_chunk_range  (IdeSourceSnippet
                                                               GtkTextIter           *end);
 IDE_AVAILABLE_IN_ALL
 IdeSourceSnippetContext *ide_source_snippet_get_context      (IdeSourceSnippet      *self);
-IDE_AVAILABLE_IN_ALL
-const gchar             *ide_source_snippet_get_snippet_text (IdeSourceSnippet      *self);
-IDE_AVAILABLE_IN_ALL
-void                     ide_source_snippet_set_snippet_text (IdeSourceSnippet      *self,
-                                                              const gchar           *snippet_text);
 
 G_END_DECLS


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]