[polari/wip/fmuellner/cleanups: 9/11] cleanup: Make singleton classes public



commit 0ab064abd42043005b431f11d30a34bbf1c87e16
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Nov 9 23:26:25 2017 +0100

    cleanup: Make singleton classes public
    
    We currently keep some of the singleton classes private to enforce
    accessing them via the corresponding getDefault() function. However
    as we are embracing ES6 classes, we are about to turn the getDefault()
    functions into more idiomatic class methods, which will require that
    callers have access to the class.

 src/accountsMonitor.js   | 2 +-
 src/roomManager.js       | 6 +++---
 src/serverRoomManager.js | 6 +++---
 src/userTracker.js       | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)
---
diff --git a/src/accountsMonitor.js b/src/accountsMonitor.js
index 31cd351..4171f00 100644
--- a/src/accountsMonitor.js
+++ b/src/accountsMonitor.js
@@ -11,7 +11,7 @@ function getDefault() {
     return _singleton;
 }
 
-class AccountsMonitor {
+var AccountsMonitor = class {
     constructor() {
         this._accounts = new Map();
         this._accountSettings = new Map();
diff --git a/src/roomManager.js b/src/roomManager.js
index 904cc81..45e9aa8 100644
--- a/src/roomManager.js
+++ b/src/roomManager.js
@@ -11,11 +11,11 @@ let _singleton = null;
 
 function getDefault() {
     if (_singleton == null)
-        _singleton = new _RoomManager();
+        _singleton = new RoomManager();
     return _singleton;
 }
 
-class _RoomManager {
+var RoomManager = class {
     constructor() {
         this._rooms = new Map();
         this._settings = new Gio.Settings({ schema_id: 'org.gnome.Polari' })
@@ -201,4 +201,4 @@ class _RoomManager {
             this.emit('room-removed', room);
     }
 };
-Signals.addSignalMethods(_RoomManager.prototype);
+Signals.addSignalMethods(RoomManager.prototype);
diff --git a/src/serverRoomManager.js b/src/serverRoomManager.js
index 60cb538..450ee6d 100644
--- a/src/serverRoomManager.js
+++ b/src/serverRoomManager.js
@@ -18,11 +18,11 @@ let _singleton = null;
 
 function getDefault() {
     if (_singleton == null)
-        _singleton = new _ServerRoomManager();
+        _singleton = new ServerRoomManager();
     return _singleton;
 }
 
-class _ServerRoomManager {
+var ServerRoomManager = class {
     constructor() {
         this._roomLists = new Map();
 
@@ -98,7 +98,7 @@ class _ServerRoomManager {
         this.emit('loading-changed', list.account);
     }
 };
-Signals.addSignalMethods(_ServerRoomManager.prototype);
+Signals.addSignalMethods(ServerRoomManager.prototype);
 
 
 const RoomListColumn = {
diff --git a/src/userTracker.js b/src/userTracker.js
index ac94976..143fd5a 100644
--- a/src/userTracker.js
+++ b/src/userTracker.js
@@ -17,7 +17,7 @@ function getUserStatusMonitor() {
     return _singleton;
 }
 
-class UserStatusMonitor {
+var UserStatusMonitor = class {
     constructor() {
         this._userTrackers = new Map();
         this._accountsMonitor = AccountsMonitor.getDefault();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]