[glib] meson: Fix comment explaining gdb hacks



commit 625bfa0b36380b97205fa7df0e07f8eca13d616e
Author: Nirbheek Chauhan <nirbheek centricular com>
Date:   Thu Nov 2 10:03:22 2017 +0530

    meson: Fix comment explaining gdb hacks
    
    https://bugzilla.gnome.org/show_bug.cgi?id=788772

 glib/meson.build    |    7 +++++--
 gobject/meson.build |    7 +++++--
 2 files changed, 10 insertions(+), 4 deletions(-)
---
diff --git a/glib/meson.build b/glib/meson.build
index 33ece2d..debfee2 100644
--- a/glib/meson.build
+++ b/glib/meson.build
@@ -283,9 +283,12 @@ configure_file(
   input: 'libglib-gdb.py.in',
   output: 'libglib-2.0.so.@0 -gdb py'.format(library_version),
   configuration: gdb_conf,
-  # FIXME: Figure out how to install this on Windows
-  install: host_system != 'windows',
+  # XXX: We add a leading './' because glib_libdir is an absolute path and we
+  # need it to be a relative path so that join_paths appends it to the end.
   install_dir: join_paths(glib_datadir, 'gdb', 'auto-load', './' + glib_libdir)
+  # FIXME: Cannot install on Windows because the path will contain a drive
+  # letter and colons are not allowed in paths.
+  install: host_system != 'windows',
 )
 
 if enable_systemtap
diff --git a/gobject/meson.build b/gobject/meson.build
index 0c8c0cb..dedc9fb 100644
--- a/gobject/meson.build
+++ b/gobject/meson.build
@@ -100,9 +100,12 @@ configure_file(
   input: 'libgobject-gdb.py.in',
   output: 'libgobject-2.0.so.@0 -gdb py'.format(library_version),
   configuration: gdb_conf,
-  # FIXME: Figure out how to install this on Windows
-  install: host_system != 'windows',
+  # XXX: We add a leading './' because glib_libdir is an absolute path and we
+  # need it to be a relative path so that join_paths appends it to the end.
   install_dir: join_paths(glib_datadir, 'gdb', 'auto-load', './' + glib_libdir)
+  # FIXME: Cannot install on Windows because the path will contain a drive
+  # letter and colons are not allowed in paths.
+  install: host_system != 'windows',
 )
 
 if enable_systemtap


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]