[gnome-todo] dnd-row: Match dragged row size
- From: Gitlab Administrative User <gitlab src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-todo] dnd-row: Match dragged row size
- Date: Wed, 1 Nov 2017 10:17:40 +0000 (UTC)
commit 359635193865481ccaee4c79d29a9cbd4db8f564
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Wed Nov 1 08:17:00 2017 -0200
dnd-row: Match dragged row size
data/theme/Adwaita.css | 1 -
data/ui/dnd-row.ui | 26 ++++++++++++++++++++++++--
src/gtd-task-list-view.c | 5 +++++
src/gtd-task-row.c | 2 ++
4 files changed, 31 insertions(+), 3 deletions(-)
---
diff --git a/data/theme/Adwaita.css b/data/theme/Adwaita.css
index d07605a..39cb62e 100644
--- a/data/theme/Adwaita.css
+++ b/data/theme/Adwaita.css
@@ -100,7 +100,6 @@ dndrow {
dndrow frame {
background: rgba(0, 0, 0, 0.2);
- min-height: 32px;
}
/* extension list */
diff --git a/data/ui/dnd-row.ui b/data/ui/dnd-row.ui
index 7983f8c..af7b1cd 100644
--- a/data/ui/dnd-row.ui
+++ b/data/ui/dnd-row.ui
@@ -7,11 +7,11 @@
<property name="selectable">False</property>
<property name="halign">center</property>
<child>
- <object class="GtkBox" id="box">
+ <object class="GtkGrid" id="box">
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="margin_start">20</property>
- <property name="spacing">12</property>
+ <property name="column_spacing">12</property>
<child>
<object class="GtkImage" id="icon">
<property name="visible">True</property>
@@ -39,6 +39,28 @@
</object>
</child>
</object>
+ <packing>
+ <property name="left_attach">1</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkFrame">
+ <property name="visible">True</property>
+ <property name="can_focus">False</property>
+ <property name="hexpand">True</property>
+ <property name="label_xalign">0</property>
+ <property name="shadow_type">none</property>
+ <child>
+ <object class="GtkBox">
+ <property name="visible">True</property>
+ <property name="vexpand">True</property>
+ </object>
+ </child>
+ </object>
+ <packing>
+ <property name="top_attach">1</property>
+ <property name="left_attach">1</property>
+ </packing>
</child>
</object>
</child>
diff --git a/src/gtd-task-list-view.c b/src/gtd-task-list-view.c
index 9c7cddb..0072864 100644
--- a/src/gtd-task-list-view.c
+++ b/src/gtd-task-list-view.c
@@ -1346,6 +1346,11 @@ listbox_drag_motion (GtkListBox *listbox,
x -= gtd_task_row_get_x_offset (GTD_TASK_ROW (source_row));
+ /* Make sure the DnD row always have the same height of the dragged row */
+ gtk_widget_set_size_request (priv->dnd_row,
+ -1,
+ gtk_widget_get_allocated_height (GTK_WIDGET (source_row)));
+
/*
* When not hovering any row, we still have to make sure that the listbox is a valid
* drop target. Otherwise, the user can drop at the space after the rows, and the row
diff --git a/src/gtd-task-row.c b/src/gtd-task-row.c
index e4e9c19..535cbb0 100644
--- a/src/gtd-task-row.c
+++ b/src/gtd-task-row.c
@@ -103,6 +103,8 @@ create_transient_row (GtdTaskRow *self)
gtk_widget_get_allocated_width (GTK_WIDGET (self)),
-1);
+ gtk_revealer_set_reveal_child (GTK_REVEALER (new_row->edit_panel_revealer), self->active);
+
return GTK_WIDGET (new_row);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]