[gnome-software/gnome-3-24] Revert "Never show components without AppData files"



commit 3096e6e8a51b744cbc6de10cd55f7e7f9c9e960d
Author: Richard Hughes <richard hughsie com>
Date:   Mon May 15 11:22:55 2017 +0100

    Revert "Never show components without AppData files"
    
    This reverts commit ccdda12701cb5618b6594f0d8899cc69e96460fe.
    
    We need to refine non-AppData-providing apps so we can use the folder selection
    mode to create folders for non-free (and non-compliant) apps in GNOME Shell.

 lib/gs-plugin-loader.c          |    6 ------
 plugins/dummy/gs-plugin-dummy.c |    8 --------
 2 files changed, 0 insertions(+), 14 deletions(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index 246143e..be998e6 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -1010,12 +1010,6 @@ gs_plugin_loader_app_is_valid_installed (GsApp *app, gpointer user_data)
                break;
        }
 
-       /* do not show components without AppData files */
-       if (gs_app_get_description (app) == NULL) {
-               g_debug ("Ignoring %s as no AppData file", gs_app_get_id (app));
-               return FALSE;
-       }
-
        /* ignore this crazy application */
        if (g_strcmp0 (gs_app_get_id (app), "gnome-system-monitor-kde.desktop") == 0) {
                g_debug ("Ignoring KDE version of %s", gs_app_get_id (app));
diff --git a/plugins/dummy/gs-plugin-dummy.c b/plugins/dummy/gs-plugin-dummy.c
index fe998ed..d74237d 100644
--- a/plugins/dummy/gs-plugin-dummy.c
+++ b/plugins/dummy/gs-plugin-dummy.c
@@ -595,14 +595,6 @@ gs_plugin_refine_app (GsPlugin *plugin,
                        gs_app_add_icon (app, ic);
                }
        }
-       if (g_strcmp0 (gs_app_get_id (app), "zeus.desktop") == 0) {
-               if (gs_app_get_name (app) == NULL)
-                       gs_app_set_name (app, GS_APP_QUALITY_NORMAL, "Zeus");
-               if (gs_app_get_summary (app) == NULL)
-                       gs_app_set_summary (app, GS_APP_QUALITY_NORMAL, "Zeus");
-               if (gs_app_get_description (app) == NULL)
-                       gs_app_set_description (app, GS_APP_QUALITY_NORMAL, "Zeus!");
-       }
 
        /* description */
        if (flags & GS_PLUGIN_REFINE_FLAGS_REQUIRE_DESCRIPTION) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]