[gnome-builder/gnome-builder-3-24] todo: be more defensive after destruction
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/gnome-builder-3-24] todo: be more defensive after destruction
- Date: Mon, 8 May 2017 22:09:50 +0000 (UTC)
commit 6806914efeaa28934ed34b459609fc199f07219c
Author: Christian Hergert <chergert redhat com>
Date: Mon May 8 14:03:04 2017 -0700
todo: be more defensive after destruction
plugins/todo/todo_plugin/__init__.py | 20 ++++++++++++--------
1 files changed, 12 insertions(+), 8 deletions(-)
---
diff --git a/plugins/todo/todo_plugin/__init__.py b/plugins/todo/todo_plugin/__init__.py
index 712800f..4f69e59 100644
--- a/plugins/todo/todo_plugin/__init__.py
+++ b/plugins/todo/todo_plugin/__init__.py
@@ -93,16 +93,17 @@ class TodoWorkbenchAddin(GObject.Object, Ide.WorkbenchAddin):
return name.endswith('.m4') or name.endswith('.in')
def _post_from_main(self, args):
- items, prepend = args
+ if self.panel:
+ items, prepend = args
- context = self.workbench.get_context()
- vcs = context.get_vcs()
+ context = self.workbench.get_context()
+ vcs = context.get_vcs()
- for item in items:
- file = item.props.file
- if vcs.is_ignored(file) or self._is_ignored_pattern(file.get_basename()):
- continue
- self.panel.add_item(item, prepend=prepend)
+ for item in items:
+ file = item.props.file
+ if vcs.is_ignored(file) or self._is_ignored_pattern(file.get_basename()):
+ continue
+ self.panel.add_item(item, prepend=prepend)
return GLib.SOURCE_REMOVE
@@ -232,6 +233,9 @@ class TodoPanel(Pnl.DockWidget):
cell.props.text = item.shortdesc
def add_item(self, item, prepend=False):
+ if not self.treeview or not self.treeview.get_selection():
+ return
+
if prepend:
iter = self.model.prepend()
else:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]