[gnome-builder] flatpak: perform remove_range() inside of NULL-check



commit 5199591ef828ecf9efc2f2e10b75754a9f5f9b9e
Author: Christian Hergert <chergert redhat com>
Date:   Fri May 5 00:44:44 2017 -0700

    flatpak: perform remove_range() inside of NULL-check
    
    Fixes Coverity CID 168632

 plugins/flatpak/gbp-flatpak-preferences-addin.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/plugins/flatpak/gbp-flatpak-preferences-addin.c b/plugins/flatpak/gbp-flatpak-preferences-addin.c
index 13ac300..ef32e3f 100644
--- a/plugins/flatpak/gbp-flatpak-preferences-addin.c
+++ b/plugins/flatpak/gbp-flatpak-preferences-addin.c
@@ -348,8 +348,9 @@ gbp_flatpak_preferences_addin_reload (GbpFlatpakPreferencesAddin *self)
           id = g_array_index (self->ids, guint, i);
           ide_preferences_remove_id (self->preferences, id);
         }
+
+      g_array_remove_range (self->ids, 0, self->ids->len);
     }
-  g_array_remove_range (self->ids, 0, self->ids->len);
 
   task = g_task_new (self, self->cancellable, gbp_flatpak_preferences_addin_reload_cb, NULL);
   g_task_set_source_tag (task, gbp_flatpak_preferences_addin_reload);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]