[gnome-software] feature-tile: remove unused event box
- From: Richard Hughes <rhughes src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software] feature-tile: remove unused event box
- Date: Tue, 2 May 2017 09:11:41 +0000 (UTC)
commit a4fa46d234bd8234ac50bcd6539bf7243f7bc68c
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date: Mon Aug 22 17:54:53 2016 -0300
feature-tile: remove unused event box
This event box appearently was used to push the
label to the far end of the tile. Not only it is
unecessary, but also made the tile require much
more horizontal space than it needs to.
Fix that by removing the event box and making the
parent box end-aligned, so the labels keep their
current position.
https://bugzilla.gnome.org/show_bug.cgi?id=770399
Signed-off-by: Richard Hughes <richard hughsie com>
src/gs-feature-tile.c | 2 --
src/gs-feature-tile.ui | 12 +-----------
2 files changed, 1 insertions(+), 13 deletions(-)
---
diff --git a/src/gs-feature-tile.c b/src/gs-feature-tile.c
index e9b2a84..1f8e4fa 100644
--- a/src/gs-feature-tile.c
+++ b/src/gs-feature-tile.c
@@ -32,7 +32,6 @@ struct _GsFeatureTile
GsAppTile parent_instance;
GsApp *app;
- GtkWidget *image;
GtkWidget *stack;
GtkWidget *title;
GtkWidget *subtitle;
@@ -148,7 +147,6 @@ gs_feature_tile_class_init (GsFeatureTileClass *klass)
gtk_widget_class_set_template_from_resource (widget_class, "/org/gnome/Software/gs-feature-tile.ui");
- gtk_widget_class_bind_template_child (widget_class, GsFeatureTile, image);
gtk_widget_class_bind_template_child (widget_class, GsFeatureTile, stack);
gtk_widget_class_bind_template_child (widget_class, GsFeatureTile, title);
gtk_widget_class_bind_template_child (widget_class, GsFeatureTile, subtitle);
diff --git a/src/gs-feature-tile.ui b/src/gs-feature-tile.ui
index d5c74cb..1e41475 100644
--- a/src/gs-feature-tile.ui
+++ b/src/gs-feature-tile.ui
@@ -32,19 +32,9 @@
<property name="hexpand">True</property>
<property name="homogeneous">True</property>
<child>
- <object class="GtkEventBox" id="image">
- <property name="visible">True</property>
- <property name="can_focus">False</property>
- <property name="visible_window">True</property>
- <property name="height_request">160</property>
- <style>
- <class name="featured-image"/>
- </style>
- </object>
- </child>
- <child>
<object class="GtkBox" id="box2">
<property name="visible">True</property>
+ <property name="halign">end</property>
<property name="orientation">vertical</property>
<property name="margin">40</property>
<child>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]