[gnome-software/gnome-3-24] Do not show the origin comment in the details page



commit c05a7d74744e1fd1a887ee4198ab9109e56aa684
Author: Richard Hughes <richard hughsie com>
Date:   Tue May 2 08:29:53 2017 +0100

    Do not show the origin comment in the details page
    
    This can easily be spoofed with a malicious flatpakrepo or distro repo file.
    
    Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=781895

 src/gs-details-page.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 31603c3..560385d 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -895,9 +895,7 @@ gs_details_page_refresh_all (GsDetailsPage *self)
        }
 
        /* set the origin */
-       tmp = gs_app_get_origin_ui (self->app);
-       if (tmp == NULL)
-               tmp = gs_app_get_origin_hostname (self->app);
+       tmp = gs_app_get_origin_hostname (self->app);
        if (tmp == NULL)
                tmp = gs_app_get_origin (self->app);
        if (tmp == NULL || tmp[0] == '\0') {
@@ -1516,7 +1514,7 @@ gs_details_page_set_local_file (GsDetailsPage *self, GFile *file)
                                            GS_PLUGIN_REFINE_FLAGS_REQUIRE_SIZE |
                                            GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION |
                                            GS_PLUGIN_REFINE_FLAGS_REQUIRE_HISTORY |
-                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_UI |
+                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_HOSTNAME |
                                            GS_PLUGIN_REFINE_FLAGS_REQUIRE_MENU_PATH |
                                            GS_PLUGIN_REFINE_FLAGS_REQUIRE_URL |
                                            GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION |
@@ -1566,7 +1564,7 @@ gs_details_page_load (GsDetailsPage *self)
                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_VERSION |
                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_HISTORY |
                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION |
-                                          GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_UI |
+                                          GS_PLUGIN_REFINE_FLAGS_REQUIRE_ORIGIN_HOSTNAME |
                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_MENU_PATH |
                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_URL |
                                           GS_PLUGIN_REFINE_FLAGS_REQUIRE_SETUP_ACTION |


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]