[gvfs/gnome-3-22] google: Prevent potential crashes if resolve_dir fails



commit 0a48084c29e6575eb86ba915e4d79dbd6468e501
Author: Ondrej Holy <oholy redhat com>
Date:   Fri Mar 17 13:54:15 2017 +0100

    google: Prevent potential crashes if resolve_dir fails
    
    Initialize pointers properly in order to avoid usage of unitialized,
    or already freed memory.
    
    This issues were revealed by coverity scan.

 daemon/gvfsbackendgoogle.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/daemon/gvfsbackendgoogle.c b/daemon/gvfsbackendgoogle.c
index 7a27720..a6f1f86 100644
--- a/daemon/gvfsbackendgoogle.c
+++ b/daemon/gvfsbackendgoogle.c
@@ -748,7 +748,7 @@ resolve_dir_and_rebuild (GVfsBackendGoogle  *self,
   GDataEntry *parent;
   GDataEntry *ret_val = NULL;
   GError *local_error;
-  gchar *basename;
+  gchar *basename = NULL;
 
   local_error = NULL;
   parent = resolve_dir (self, filename, &basename, &local_error);
@@ -1184,6 +1184,7 @@ g_vfs_backend_google_copy (GVfsBackend           *_self,
       if (!destination_not_directory)
         {
           g_free (destination_basename);
+          destination_basename = NULL;
 
           error = NULL;
           destination_parent = resolve_dir (self, destination, &destination_basename, &error);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]