[gtkmm/gtkmm-3-22] FileChooserDialog: Drop unneeded explicit on ctor
- From: Daniel Boles <dboles src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtkmm/gtkmm-3-22] FileChooserDialog: Drop unneeded explicit on ctor
- Date: Mon, 27 Mar 2017 20:05:45 +0000 (UTC)
commit 5c02dbb2a4fa612c0630793479d3af754c5bab00
Author: Daniel Boles <dboles src gnome org>
Date: Mon Mar 27 21:01:09 2017 +0100
FileChooserDialog: Drop unneeded explicit on ctor
This is only useful to us if the constructor can be invoked with one
argument (i.e. it only has 1, or the subsequent have default values).
That is not true here, so the explicit keyword is a semantic mistake.
https://bugzilla.gnome.org/show_bug.cgi?id=780004
gtk/src/filechooserdialog.hg | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/gtk/src/filechooserdialog.hg b/gtk/src/filechooserdialog.hg
index 827e11f..cc1a26a 100644
--- a/gtk/src/filechooserdialog.hg
+++ b/gtk/src/filechooserdialog.hg
@@ -41,14 +41,14 @@ class FileChooserDialog
_UNMANAGEABLE
public:
_IGNORE(gtk_file_chooser_dialog_new)
- explicit FileChooserDialog(Gtk::Window& parent, const Glib::ustring& title, FileChooserAction action =
FILE_CHOOSER_ACTION_OPEN);
+ FileChooserDialog(Gtk::Window& parent, const Glib::ustring& title, FileChooserAction action =
FILE_CHOOSER_ACTION_OPEN);
explicit FileChooserDialog(const Glib::ustring& title, FileChooserAction action =
FILE_CHOOSER_ACTION_OPEN);
_DEPRECATE_IFDEF_START
/// @deprecated Use a constructor without the @a backend parameter.
- explicit FileChooserDialog(Gtk::Window& parent, const Glib::ustring& title, FileChooserAction action,
const Glib::ustring& backend);
+ FileChooserDialog(Gtk::Window& parent, const Glib::ustring& title, FileChooserAction action, const
Glib::ustring& backend);
/// @deprecated Use a constructor without the @a backend parameter.
- explicit FileChooserDialog(const Glib::ustring& title, FileChooserAction action, const Glib::ustring&
backend);
+ FileChooserDialog(const Glib::ustring& title, FileChooserAction action, const Glib::ustring& backend);
_DEPRECATE_IFDEF_END
};
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]