[glom/gtkmm4v4: 32/37] gtkmm4: Don't unnecessarly deref TreeModel::Row.



commit eaeac1b88f67d9c2570f0cca5f2e5c0c3cbaf245
Author: Murray Cumming <murrayc murrayc com>
Date:   Wed Mar 15 11:27:22 2017 +0100

    gtkmm4: Don't unnecessarly deref TreeModel::Row.
    
    I guess this worked before because TreeRow inherited from TreeIter.

 glom/mode_data/datawidget/treemodel_db.cc        |    2 +-
 glom/mode_data/db_adddel/db_adddel.cc            |    2 +-
 glom/mode_design/layout/combobox_relationship.cc |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/glom/mode_data/datawidget/treemodel_db.cc b/glom/mode_data/datawidget/treemodel_db.cc
index a81729a..b924e69 100644
--- a/glom/mode_data/datawidget/treemodel_db.cc
+++ b/glom/mode_data/datawidget/treemodel_db.cc
@@ -712,7 +712,7 @@ DbTreeModel::type_datamodel_row_index DbTreeModel::get_datamodel_row_index_from_
 
 bool DbTreeModel::check_treeiter_validity(const const_iterator& iter) const
 {
-  if(!(iter->get_model_gobject()))
+  if(!(iter.get_model_gobject()))
     return false;
 
   // Anything that modifies the model's structure should change the model's stamp,
diff --git a/glom/mode_data/db_adddel/db_adddel.cc b/glom/mode_data/db_adddel/db_adddel.cc
index 50efaea..6715951 100644
--- a/glom/mode_data/db_adddel/db_adddel.cc
+++ b/glom/mode_data/db_adddel/db_adddel.cc
@@ -1857,7 +1857,7 @@ void DbAddDel::treeviewcolumn_on_cell_data(Gtk::CellRenderer* renderer, const Gt
       const guint col_real = data_model_column_index + get_count_hidden_system_columns();
       auto treerow = *iter;
       Gnome::Gda::Value value;
-      treerow->get_value(col_real, value);
+      treerow.get_value(col_real, value);
 
       /*
       GType debug_type = value.get_value_type();
diff --git a/glom/mode_design/layout/combobox_relationship.cc 
b/glom/mode_design/layout/combobox_relationship.cc
index aa56e56..85be682 100644
--- a/glom/mode_design/layout/combobox_relationship.cc
+++ b/glom/mode_design/layout/combobox_relationship.cc
@@ -235,7 +235,7 @@ void ComboBox_Relationship::on_cell_data_title(const Gtk::TreeModel::const_itera
   std::shared_ptr<Relationship> relationship = row[m_model_columns.m_relationship];
   if(relationship)
   {
-    auto iterParent = row->parent();
+    auto iterParent = row.parent();
     if(iterParent)
     {
       //related relationship:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]