[glom/gtkmm4v4: 19/37] gtkmm4: Remove calls to show_all_children().

From: Murray Cumming <murrayc src gnome org>
To: commits-list gnome org
Cc:
Subject: [glom/gtkmm4v4: 19/37] gtkmm4: Remove calls to show_all_children().
Date: Wed, 15 Mar 2017 14:55:34 +0000 (UTC)
commit 0af60c45e387106c0ace6e547516b3b850aedfb2
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Mar 14 09:49:26 2017 +0100

    gtkmm4: Remove calls to show_all_children().
    
    This has been removed from gtkmm4. Apparently child widgets are now
    visible by default.

 glom/box_reports.cc                                |    2 --
 glom/frame_glom.cc                                 |    2 --
 glom/libglom/test_avahi_publisher.cc               |    2 --
 glom/mode_data/box_data_details.cc                 |    2 --
 glom/mode_data/datawidget/dialog_choose_id.cc      |    1 -
 glom/mode_data/db_adddel/db_adddel.cc              |    2 --
 glom/mode_data/notebook_data.cc                    |    2 --
 glom/mode_design/box_db_table_relationships.cc     |    2 --
 glom/mode_design/dialog_design.cc                  |    2 --
 glom/mode_design/dialog_fields.cc                  |    2 --
 glom/mode_design/dialog_relationships.cc           |    2 --
 .../mode_design/fields/dialog_defaultformatting.cc |    2 --
 glom/mode_design/fields/dialog_fieldcalculation.cc |    2 --
 glom/mode_design/fields/dialog_fielddefinition.cc  |    2 --
 glom/mode_design/layout/dialog_choose_field.cc     |    2 --
 .../layout/dialog_choose_relationship.cc           |    2 --
 glom/mode_design/layout/dialog_layout.cc           |    2 --
 .../layout/dialog_layout_calendar_related.cc       |    2 --
 glom/mode_design/layout/dialog_layout_details.cc   |    2 --
 glom/mode_design/layout/dialog_layout_export.cc    |    2 --
 .../layout/dialog_layout_list_related.cc           |    2 --
 .../layout/layout_item_dialogs/box_formatting.cc   |    2 --
 .../layout_item_dialogs/dialog_buttonscript.cc     |    2 --
 .../layout_item_dialogs/dialog_field_layout.cc     |    2 --
 .../layout_item_dialogs/dialog_field_summary.cc    |    2 --
 .../layout_item_dialogs/dialog_fieldslist.cc       |    2 --
 .../layout_item_dialogs/dialog_formatting.cc       |    2 --
 .../layout/layout_item_dialogs/dialog_group_by.cc  |    2 --
 .../layout_item_dialogs/dialog_imageobject.cc      |    2 --
 .../layout/layout_item_dialogs/dialog_line.cc      |    2 --
 .../layout_item_dialogs/dialog_sortfields.cc       |    2 --
 .../layout_item_dialogs/dialog_textobject.cc       |    2 --
 .../mode_design/print_layouts/box_print_layouts.cc |    2 --
 .../print_layouts/dialog_text_formatting.cc        |    2 --
 .../print_layouts/print_layout_toolbar.cc          |    2 --
 .../print_layouts/window_print_layout_edit.cc      |    2 --
 .../report_layout/dialog_layout_report.cc          |    3 ---
 .../script_library/dialog_script_library.cc        |    2 --
 .../mode_design/translation/window_translations.cc |    2 --
 glom/mode_design/users/dialog_groups_list.cc       |    2 --
 glom/mode_design/users/dialog_user.cc              |    2 --
 glom/mode_design/users/dialog_users_list.cc        |    2 --
 glom/mode_find/box_data_details_find.cc            |    2 --
 glom/mode_find/box_data_list_find.cc               |    2 --
 glom/mode_find/notebook_find.cc                    |    3 ---
 glom/navigation/box_tables.cc                      |    2 --
 glom/utility_widgets/adddel/adddel.cc              |    2 --
 glom/utility_widgets/dialog_flowtable.cc           |    2 --
 glom/utility_widgets/dialog_properties.cc          |    4 +---
 glom/utility_widgets/layouttoolbar.cc              |    2 --
 50 files changed, 1 insertions(+), 102 deletions(-)
---
diff --git a/glom/box_reports.cc b/glom/box_reports.cc
index 5e1cee4..5bd0aef 100644
--- a/glom/box_reports.cc
+++ b/glom/box_reports.cc
@@ -64,8 +64,6 @@ Box_Reports::Box_Reports(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Builde
   m_AddDel.signal_user_requested_delete().connect(sigc::mem_fun(*this, &Box_Reports::on_adddel_Delete));
   m_AddDel.signal_user_requested_edit().connect(sigc::mem_fun(*this, &Box_Reports::on_adddel_Edit));
   m_AddDel.signal_user_changed().connect(sigc::mem_fun(*this, &Box_Reports::on_adddel_changed));
-
-  show_all_children();
 }
 
 void Box_Reports::fill_row(const Gtk::TreeModel::iterator& iter, const std::shared_ptr<const Report>& report)
diff --git a/glom/frame_glom.cc b/glom/frame_glom.cc
index e0aad01..1e451ce 100644
--- a/glom/frame_glom.cc
+++ b/glom/frame_glom.cc
@@ -126,8 +126,6 @@ Frame_Glom::Frame_Glom(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Builder>
   m_button_quick_find->signal_clicked().connect(
     sigc::mem_fun(*this, &Frame_Glom::on_button_quickfind) );
   m_box_quick_find->pack_start(*m_button_quick_find, Gtk::PACK_SHRINK);
-
-  m_box_quick_find->show_all_children();
   m_box_quick_find->hide();
 
   PlaceHolder* placeholder_quickfind = nullptr;
diff --git a/glom/libglom/test_avahi_publisher.cc b/glom/libglom/test_avahi_publisher.cc
index bbe1ee5..2e585f2 100644
--- a/glom/libglom/test_avahi_publisher.cc
+++ b/glom/libglom/test_avahi_publisher.cc
@@ -39,8 +39,6 @@ TestWindow::TestWindow()
 
   m_button_start.signal_clicked().connect(sigc::mem_fun(*this, &TestWindow::on_button_start));
   m_button_stop.signal_clicked().connect(sigc::mem_fun(*this, &TestWindow::on_button_stop));
-
-  show_all_children();
 }
 
 TestWindow::~TestWindow()
diff --git a/glom/mode_data/box_data_details.cc b/glom/mode_data/box_data_details.cc
index c1f7639..c03cd19 100644
--- a/glom/mode_data/box_data_details.cc
+++ b/glom/mode_data/box_data_details.cc
@@ -145,8 +145,6 @@ Box_Data_Details::Box_Data_Details(bool bWithNavButtons /* = true */)
   pack_start(m_hbox_buttons, Gtk::PACK_SHRINK);
 
   m_ignore_signals = false;
-
-  show_all_children();
 }
 
 Box_Data_Details::~Box_Data_Details()
diff --git a/glom/mode_data/datawidget/dialog_choose_id.cc b/glom/mode_data/datawidget/dialog_choose_id.cc
index e6e973f..23679db 100644
--- a/glom/mode_data/datawidget/dialog_choose_id.cc
+++ b/glom/mode_data/datawidget/dialog_choose_id.cc
@@ -82,7 +82,6 @@ void Dialog_ChooseID::setup()
 
   //Fill composite view:
   add_view(&m_box_find);
-  //m_box_select.show_all_children();
   add_view(&m_box_select);
   m_box_select.set_open_button_title(_("Select"));
 
diff --git a/glom/mode_data/db_adddel/db_adddel.cc b/glom/mode_data/db_adddel/db_adddel.cc
index 39ec2c8..c67cdf9 100644
--- a/glom/mode_data/db_adddel/db_adddel.cc
+++ b/glom/mode_data/db_adddel/db_adddel.cc
@@ -103,8 +103,6 @@ DbAddDel::DbAddDel()
 
   remove_all_columns(); //set up the default columns.
 
-  show_all_children();
-
   auto refSelection = m_tree_view.get_selection();
   if(refSelection)
   {
diff --git a/glom/mode_data/notebook_data.cc b/glom/mode_data/notebook_data.cc
index 4b81889..58991bb 100644
--- a/glom/mode_data/notebook_data.cc
+++ b/glom/mode_data/notebook_data.cc
@@ -75,8 +75,6 @@ Notebook_Data::Notebook_Data()
   add_view(&m_Box_List);
   add_view(&m_Box_Details);
 
-  show_all_children();
-
 #ifndef GLOM_ENABLE_CLIENT_ONLY
   //This is hidden by default,
   m_Box_Details.show_layout_toolbar(false);
diff --git a/glom/mode_design/box_db_table_relationships.cc b/glom/mode_design/box_db_table_relationships.cc
index 606d46a..b79149f 100644
--- a/glom/mode_design/box_db_table_relationships.cc
+++ b/glom/mode_design/box_db_table_relationships.cc
@@ -65,8 +65,6 @@ void Box_DB_Table_Relationships::init()
   m_AddDel.signal_user_changed().connect(sigc::mem_fun(*this, 
&Box_DB_Table_Relationships::on_adddel_user_changed));
   m_AddDel.signal_user_added().connect(sigc::mem_fun(*this, 
&Box_DB_Table_Relationships::on_adddel_user_added));
   m_AddDel.signal_user_requested_delete().connect(sigc::mem_fun(*this, 
&Box_DB_Table_Relationships::on_adddel_user_requested_delete));
-
-  show_all_children();
 }
 
 bool Box_DB_Table_Relationships::fill_from_database()
diff --git a/glom/mode_design/dialog_design.cc b/glom/mode_design/dialog_design.cc
index 4e0bba1..740f624 100644
--- a/glom/mode_design/dialog_design.cc
+++ b/glom/mode_design/dialog_design.cc
@@ -38,8 +38,6 @@ Dialog_Design::Dialog_Design(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Bu
   builder->get_widget("label_table_name", m_label_table);
 
   set_modal(); //We don't want people to edit the main window while we are changing structure.
-
-  show_all_children();
 }
 
 bool Dialog_Design::init_db_details(const Glib::ustring& table_name)
diff --git a/glom/mode_design/dialog_fields.cc b/glom/mode_design/dialog_fields.cc
index d97e851..032ec7e 100644
--- a/glom/mode_design/dialog_fields.cc
+++ b/glom/mode_design/dialog_fields.cc
@@ -36,8 +36,6 @@ Dialog_Fields::Dialog_Fields(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Bu
 
   //Fill composite view:
   add_view(m_box);
-
-  show_all_children();
 }
 
 Dialog_Fields::~Dialog_Fields()
diff --git a/glom/mode_design/dialog_relationships.cc b/glom/mode_design/dialog_relationships.cc
index 47c6775..66d0897 100644
--- a/glom/mode_design/dialog_relationships.cc
+++ b/glom/mode_design/dialog_relationships.cc
@@ -36,8 +36,6 @@ Dialog_Relationships::Dialog_Relationships(BaseObjectType* cobject, const Glib::
 
   //Fill composite view:
   add_view(m_box);
-
-  show_all_children();
 }
 
 Dialog_Relationships::~Dialog_Relationships()
diff --git a/glom/mode_design/fields/dialog_defaultformatting.cc 
b/glom/mode_design/fields/dialog_defaultformatting.cc
index 880f1d9..54e3930 100644
--- a/glom/mode_design/fields/dialog_defaultformatting.cc
+++ b/glom/mode_design/fields/dialog_defaultformatting.cc
@@ -50,8 +50,6 @@ Dialog_DefaultFormatting::Dialog_DefaultFormatting(BaseObjectType* cobject, cons
   }
 
   Dialog_Properties::set_modified(false);
-
-  show_all_children();
 }
 
 Dialog_DefaultFormatting::~Dialog_DefaultFormatting()
diff --git a/glom/mode_design/fields/dialog_fieldcalculation.cc 
b/glom/mode_design/fields/dialog_fieldcalculation.cc
index 19ec16a..1a43a85 100644
--- a/glom/mode_design/fields/dialog_fieldcalculation.cc
+++ b/glom/mode_design/fields/dialog_fieldcalculation.cc
@@ -64,8 +64,6 @@ Dialog_FieldCalculation::Dialog_FieldCalculation(BaseObjectType* cobject, const
   }
 
   //Dialog_Properties::set_modified(false);
-
-  show_all_children();
 }
 
 void Dialog_FieldCalculation::set_field(const std::shared_ptr<const Field>& field, const Glib::ustring& 
table_name)
diff --git a/glom/mode_design/fields/dialog_fielddefinition.cc 
b/glom/mode_design/fields/dialog_fielddefinition.cc
index 66a03f7..3b599c2 100644
--- a/glom/mode_design/fields/dialog_fielddefinition.cc
+++ b/glom/mode_design/fields/dialog_fielddefinition.cc
@@ -101,8 +101,6 @@ Dialog_FieldDefinition::Dialog_FieldDefinition(BaseObjectType* cobject, const Gl
 
   //This is mostly just to exercise some widgets during simple tests:
   enforce_constraints();
-
-  show_all_children();
 }
 
 void Dialog_FieldDefinition::set_field(const std::shared_ptr<const Field>& field, const Glib::ustring& 
table_name)
diff --git a/glom/mode_design/layout/dialog_choose_field.cc b/glom/mode_design/layout/dialog_choose_field.cc
index c540bb0..c650a59 100644
--- a/glom/mode_design/layout/dialog_choose_field.cc
+++ b/glom/mode_design/layout/dialog_choose_field.cc
@@ -69,8 +69,6 @@ Dialog_ChooseField::Dialog_ChooseField(BaseObjectType* cobject, const Glib::RefP
       refSelection->signal_changed().connect( sigc::mem_fun(*this, 
&Dialog_ChooseField::on_treeview_selection_changed) );
     }
   }
-
-  show_all_children();
 }
 
 void Dialog_ChooseField::set_document(const std::shared_ptr<Document>& document, const Glib::ustring& 
table_name, const std::shared_ptr<const LayoutItem_Field>& field)
diff --git a/glom/mode_design/layout/dialog_choose_relationship.cc 
b/glom/mode_design/layout/dialog_choose_relationship.cc
index 79db5b6..9e6591e 100644
--- a/glom/mode_design/layout/dialog_choose_relationship.cc
+++ b/glom/mode_design/layout/dialog_choose_relationship.cc
@@ -55,8 +55,6 @@ Dialog_ChooseRelationship::Dialog_ChooseRelationship(BaseObjectType* cobject, co
     m_treeview->append_column( _("Name"), m_ColumnsRelationships.m_col_name );
     //m_treeview->append_column( _("Title"), m_ColumnsRelationships.m_col_title );
   }
-
-  show_all_children();
 }
 
 void Dialog_ChooseRelationship::set_document(const std::shared_ptr<Document>& document, const Glib::ustring& 
table_name)
diff --git a/glom/mode_design/layout/dialog_layout.cc b/glom/mode_design/layout/dialog_layout.cc
index b5ff4b7..079c675 100644
--- a/glom/mode_design/layout/dialog_layout.cc
+++ b/glom/mode_design/layout/dialog_layout.cc
@@ -42,8 +42,6 @@ Dialog_Layout::Dialog_Layout(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Bu
 
     builder->get_widget("label_title", m_label_table_title);
   }
-
-  show_all_children();
 }
 
 void Dialog_Layout::init(const Glib::ustring& layout_name, const Glib::ustring& layout_platform, const 
std::shared_ptr<Document>& /* document */, const Glib::ustring& table_name, const type_vecConstLayoutFields& 
/* table_fields */)
diff --git a/glom/mode_design/layout/dialog_layout_calendar_related.cc 
b/glom/mode_design/layout/dialog_layout_calendar_related.cc
index efaa414..81a6622 100644
--- a/glom/mode_design/layout/dialog_layout_calendar_related.cc
+++ b/glom/mode_design/layout/dialog_layout_calendar_related.cc
@@ -81,8 +81,6 @@ Dialog_Layout_Calendar_Related::Dialog_Layout_Calendar_Related(BaseObjectType* c
 
   m_modified = false;
 
-  //show_all_children();
-
   //The base class hid this, but we do want it here:
   //(We share one glade definition for several dialogs.)
   Gtk::Frame* box_calendar = nullptr;
diff --git a/glom/mode_design/layout/dialog_layout_details.cc 
b/glom/mode_design/layout/dialog_layout_details.cc
index 00cdc60..d2cae8c 100644
--- a/glom/mode_design/layout/dialog_layout_details.cc
+++ b/glom/mode_design/layout/dialog_layout_details.cc
@@ -203,8 +203,6 @@ Dialog_Layout_Details::Dialog_Layout_Details(BaseObjectType* cobject, const Glib
 
   builder->get_widget("button_edit", m_button_edit);
   m_button_edit->signal_clicked().connect( sigc::mem_fun(*this, &Dialog_Layout_Details::on_button_edit) );
-
-  //show_all_children();
 }
 
 void Dialog_Layout_Details::fill_group(const Gtk::TreeModel::iterator& iter, std::shared_ptr<LayoutGroup>& 
group)
diff --git a/glom/mode_design/layout/dialog_layout_export.cc b/glom/mode_design/layout/dialog_layout_export.cc
index 3039c40..7789cfa 100644
--- a/glom/mode_design/layout/dialog_layout_export.cc
+++ b/glom/mode_design/layout/dialog_layout_export.cc
@@ -88,8 +88,6 @@ Dialog_Layout_Export::Dialog_Layout_Export(BaseObjectType* cobject, const Glib::
 
   builder->get_widget("button_field_edit", m_button_field_edit);
   m_button_field_edit->signal_clicked().connect( sigc::mem_fun(*this, 
&Dialog_Layout_Export::on_button_edit_field) );
-
-  show_all_children();
 }
 
 void Dialog_Layout_Export::set_layout_groups(Document::type_list_const_layout_groups& mapGroups, const 
std::shared_ptr<Document>& document, const Glib::ustring& table_name)
diff --git a/glom/mode_design/layout/dialog_layout_list_related.cc 
b/glom/mode_design/layout/dialog_layout_list_related.cc
index ffaf6ae..ec1ceff 100644
--- a/glom/mode_design/layout/dialog_layout_list_related.cc
+++ b/glom/mode_design/layout/dialog_layout_list_related.cc
@@ -115,8 +115,6 @@ Dialog_Layout_List_Related::Dialog_Layout_List_Related(BaseObjectType* cobject,
 
   m_modified = false;
 
-  //show_all_children();
-
   //This entry must be in the Glade file, because it's used by the base class,
   //but we don't want it here, because it is confusing when dealing with relationships:
   if(m_entry_table_title)
diff --git a/glom/mode_design/layout/layout_item_dialogs/box_formatting.cc 
b/glom/mode_design/layout/layout_item_dialogs/box_formatting.cc
index 4d0772b..7347ba0 100644
--- a/glom/mode_design/layout/layout_item_dialogs/box_formatting.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/box_formatting.cc
@@ -175,8 +175,6 @@ Box_Formatting::Box_Formatting(BaseObjectType* cobject, const Glib::RefPtr<Gtk::
     add_view(m_dialog_choices_sortby); //Give it access to the document.
     m_dialog_choices_sortby->set_title(_("Sort Order"));
   }
-
-  show_all_children();
 }
 
 Box_Formatting::~Box_Formatting()
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_buttonscript.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_buttonscript.cc
index 9fefbb0..54a6f2b 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_buttonscript.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_buttonscript.cc
@@ -65,8 +65,6 @@ Dialog_ButtonScript::Dialog_ButtonScript(BaseObjectType* cobject, const Glib::Re
      buffer->set_highlight_syntax();
      m_text_view_script->set_buffer(buffer);
   }
-
-  show_all_children();
 }
 
 void Dialog_ButtonScript::set_script(const std::shared_ptr<const LayoutItem_Button>& script, const 
Glib::ustring& table_name)
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_field_layout.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_field_layout.cc
index 9abfaf6..7f90512 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_field_layout.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_field_layout.cc
@@ -57,8 +57,6 @@ Dialog_FieldLayout::Dialog_FieldLayout(BaseObjectType* cobject, const Glib::RefP
   add_view(m_box_formatting);
 
   m_radiobutton_custom_formatting->signal_toggled().connect(sigc::mem_fun(*this, 
&Dialog_FieldLayout::on_radiobutton_custom_formatting));
-
-  show_all_children();
 }
 
 Dialog_FieldLayout::~Dialog_FieldLayout()
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_field_summary.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_field_summary.cc
index 0f14c5d..7db085c 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_field_summary.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_field_summary.cc
@@ -39,8 +39,6 @@ Dialog_FieldSummary::Dialog_FieldSummary(BaseObjectType* cobject, const Glib::Re
 
   //Connect signals:
   m_button_field->signal_clicked().connect(sigc::mem_fun(*this, &Dialog_FieldSummary::on_button_field));
-
-  show_all_children();
 }
 
 void Dialog_FieldSummary::set_item(const std::shared_ptr<const LayoutItem_FieldSummary>& item, const 
Glib::ustring& table_name)
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_fieldslist.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_fieldslist.cc
index 4e0aaef..8038844 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_fieldslist.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_fieldslist.cc
@@ -90,8 +90,6 @@ Dialog_FieldsList::Dialog_FieldsList(BaseObjectType* cobject, const Glib::RefPtr
 
   builder->get_widget("button_field_formatting", m_button_field_formatting);
   m_button_field_formatting->signal_clicked().connect( sigc::mem_fun(*this, 
&Dialog_FieldsList::on_button_formatting) );
-
-  show_all_children();
 }
 
 void Dialog_FieldsList::set_fields(const Glib::ustring& table_name, const LayoutGroup::type_list_items& 
fields)
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_formatting.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_formatting.cc
index b37ffe1..3ab802e 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_formatting.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_formatting.cc
@@ -37,8 +37,6 @@ Dialog_Formatting::Dialog_Formatting()
 
   add_button(_("_Cancel"), Gtk::RESPONSE_CANCEL);
   add_button(_("_Save"), Gtk::RESPONSE_OK);
-
-  show_all_children();
 }
 
 Dialog_Formatting::~Dialog_Formatting()
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_group_by.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_group_by.cc
index bbd6569..6331b1d 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_group_by.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_group_by.cc
@@ -60,8 +60,6 @@ Dialog_GroupBy::Dialog_GroupBy(BaseObjectType* cobject, const Glib::RefPtr<Gtk::
   m_button_formatting_group_by->signal_clicked().connect(sigc::mem_fun(*this, 
&Dialog_GroupBy::on_button_formatting_group_by));
   m_button_field_sort_by->signal_clicked().connect(sigc::mem_fun(*this, 
&Dialog_GroupBy::on_button_field_sort_by));
   m_button_secondary_fields->signal_clicked().connect(sigc::mem_fun(*this, 
&Dialog_GroupBy::on_button_secondary_fields));
-
-  show_all_children();
 }
 
 Dialog_GroupBy::~Dialog_GroupBy()
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_imageobject.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_imageobject.cc
index cd8fc3a..308597c 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_imageobject.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_imageobject.cc
@@ -47,8 +47,6 @@ Dialog_ImageObject::Dialog_ImageObject(BaseObjectType* cobject, const Glib::RefP
   //connect_each_widget(this);
 
   //Dialog_Properties::set_modified(false);
-
-  show_all_children();
 }
 
 void Dialog_ImageObject::on_button_choose()
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_line.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_line.cc
index 7017b03..6d46624 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_line.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_line.cc
@@ -42,8 +42,6 @@ Dialog_Line::Dialog_Line(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Builde
   //connect_each_widget(this);
 
   //Dialog_Properties::set_modified(false);
-
-  show_all_children();
 }
 
 void Dialog_Line::set_line(const std::shared_ptr<const LayoutItem_Line>& line)
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_sortfields.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_sortfields.cc
index 91b67a4..176e3fa 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_sortfields.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_sortfields.cc
@@ -87,8 +87,6 @@ Dialog_SortFields::Dialog_SortFields(BaseObjectType* cobject, const Glib::RefPtr
 
   builder->get_widget("button_field_edit", m_button_field_edit);
   m_button_field_edit->signal_clicked().connect( sigc::mem_fun(*this, 
&Dialog_SortFields::on_button_edit_field) );
-
-  show_all_children();
 }
 
 void Dialog_SortFields::set_fields(const Glib::ustring& table_name, const 
LayoutItem_GroupBy::type_list_sort_fields& fields)
diff --git a/glom/mode_design/layout/layout_item_dialogs/dialog_textobject.cc 
b/glom/mode_design/layout/layout_item_dialogs/dialog_textobject.cc
index 6cffb54..ef9a8e3 100644
--- a/glom/mode_design/layout/layout_item_dialogs/dialog_textobject.cc
+++ b/glom/mode_design/layout/layout_item_dialogs/dialog_textobject.cc
@@ -44,8 +44,6 @@ Dialog_TextObject::Dialog_TextObject(BaseObjectType* cobject, const Glib::RefPtr
   //connect_each_widget(this);
 
   //Dialog_Properties::set_modified(false);
-
-  show_all_children();
 }
 
 void Dialog_TextObject::set_textobject(const std::shared_ptr<const LayoutItem_Text>& textobject, const 
Glib::ustring& table_name, bool show_title)
diff --git a/glom/mode_design/print_layouts/box_print_layouts.cc 
b/glom/mode_design/print_layouts/box_print_layouts.cc
index 42bbb98..b9fc041 100644
--- a/glom/mode_design/print_layouts/box_print_layouts.cc
+++ b/glom/mode_design/print_layouts/box_print_layouts.cc
@@ -51,8 +51,6 @@ Box_Print_Layouts::Box_Print_Layouts(BaseObjectType* cobject, const Glib::RefPtr
   m_AddDel.signal_user_requested_delete().connect(sigc::mem_fun(*this, 
&Box_Print_Layouts::on_adddel_user_requested_delete));
   m_AddDel.signal_user_requested_edit().connect(sigc::mem_fun(*this, 
&Box_Print_Layouts::on_adddel_user_requested_edit));
   m_AddDel.signal_user_changed().connect(sigc::mem_fun(*this, &Box_Print_Layouts::on_adddel_user_changed));
-
-  show_all_children();
 }
 
 void Box_Print_Layouts::fill_row(const Gtk::TreeModel::iterator& iter, const std::shared_ptr<const 
PrintLayout>& item)
diff --git a/glom/mode_design/print_layouts/dialog_text_formatting.cc 
b/glom/mode_design/print_layouts/dialog_text_formatting.cc
index 5511951..c8574f1 100644
--- a/glom/mode_design/print_layouts/dialog_text_formatting.cc
+++ b/glom/mode_design/print_layouts/dialog_text_formatting.cc
@@ -51,8 +51,6 @@ Dialog_TextFormatting::Dialog_TextFormatting(BaseObjectType* cobject, const Glib
   }
 
   set_modal(); //We don't want people to edit the main window while we are changing structure.
-
-  show_all_children();
 }
 
 Dialog_TextFormatting::~Dialog_TextFormatting()
diff --git a/glom/mode_design/print_layouts/print_layout_toolbar.cc 
b/glom/mode_design/print_layouts/print_layout_toolbar.cc
index 7b7cdc3..db2ce95 100644
--- a/glom/mode_design/print_layouts/print_layout_toolbar.cc
+++ b/glom/mode_design/print_layouts/print_layout_toolbar.cc
@@ -62,8 +62,6 @@ PrintLayoutToolbar::PrintLayoutToolbar()
   add(m_group_records);
 
   set_drag_source();
-
-  show_all_children();
 }
 
 
diff --git a/glom/mode_design/print_layouts/window_print_layout_edit.cc 
b/glom/mode_design/print_layouts/window_print_layout_edit.cc
index 5f8dce5..8c317c6 100644
--- a/glom/mode_design/print_layouts/window_print_layout_edit.cc
+++ b/glom/mode_design/print_layouts/window_print_layout_edit.cc
@@ -191,8 +191,6 @@ Window_PrintLayout_Edit::Window_PrintLayout_Edit(BaseObjectType* cobject, const
   m_canvas.signal_selection_changed().connect(
     sigc::mem_fun(*this, &Window_PrintLayout_Edit::on_canvas_selection_changed));
   on_canvas_selection_changed(); //Disable relevant widgets or actions by default.
-
-  show_all_children();
 }
 
 void Window_PrintLayout_Edit::init_menu()
diff --git a/glom/mode_design/report_layout/dialog_layout_report.cc 
b/glom/mode_design/report_layout/dialog_layout_report.cc
index 5d18753..d84c617 100644
--- a/glom/mode_design/report_layout/dialog_layout_report.cc
+++ b/glom/mode_design/report_layout/dialog_layout_report.cc
@@ -174,9 +174,6 @@ Dialog_Layout_Report::Dialog_Layout_Report(BaseObjectType* cobject, const Glib::
   builder->get_widget("treeview_parts_main", m_treeview_parts_main);
   setup_model(*m_treeview_parts_main, m_model_parts_main);
 
-
-  show_all_children();
-
   //We save the connection, so we can disconnect it in the destructor,
   //because, for some reason, this signal handler is still called _after_ the destructor.
   //TODO: Fix that problem in GTK+ or gtkmm?
diff --git a/glom/mode_design/script_library/dialog_script_library.cc 
b/glom/mode_design/script_library/dialog_script_library.cc
index 942bfb4..0cf204d 100644
--- a/glom/mode_design/script_library/dialog_script_library.cc
+++ b/glom/mode_design/script_library/dialog_script_library.cc
@@ -67,8 +67,6 @@ Dialog_ScriptLibrary::Dialog_ScriptLibrary(BaseObjectType* cobject, const Glib::
      buffer->set_highlight_syntax();
      m_text_view->set_buffer(buffer);
   }
-
-  show_all_children();
 }
 
 void Dialog_ScriptLibrary::on_button_check()
diff --git a/glom/mode_design/translation/window_translations.cc 
b/glom/mode_design/translation/window_translations.cc
index 517331f..27b07b6 100644
--- a/glom/mode_design/translation/window_translations.cc
+++ b/glom/mode_design/translation/window_translations.cc
@@ -125,8 +125,6 @@ Window_Translations::Window_Translations(BaseObjectType* cobject, const Glib::Re
     m_button_export->signal_clicked().connect( sigc::mem_fun(*this, &Window_Translations::on_button_export) 
);
   }
 
-  show_all_children();
-
   //Start with the currently-used/tested translation, if appropriate:
   if(AppWindow::get_current_locale_not_original())
   {
diff --git a/glom/mode_design/users/dialog_groups_list.cc b/glom/mode_design/users/dialog_groups_list.cc
index 059d679..0c0de30 100644
--- a/glom/mode_design/users/dialog_groups_list.cc
+++ b/glom/mode_design/users/dialog_groups_list.cc
@@ -108,8 +108,6 @@ Dialog_GroupsList::Dialog_GroupsList(BaseObjectType* cobject, const Glib::RefPtr
   m_button_group_users->signal_clicked().connect( sigc::mem_fun(*this, 
&Dialog_GroupsList::on_button_group_users) );
 
   enable_buttons();
-
-  show_all_children();
 }
 
 /*
diff --git a/glom/mode_design/users/dialog_user.cc b/glom/mode_design/users/dialog_user.cc
index 41a2ab1..81a4507 100644
--- a/glom/mode_design/users/dialog_user.cc
+++ b/glom/mode_design/users/dialog_user.cc
@@ -43,8 +43,6 @@ Dialog_User::Dialog_User(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Builde
   m_entry_password->set_max_length(Privs::MAX_ROLE_SIZE); //Let's assume that this has a similar 
(undocumented in PostgreSQL) max size as the user.
   builder->get_widget("entry_password_confirm", m_entry_password_confirm);
   m_entry_password_confirm->set_max_length(Privs::MAX_ROLE_SIZE);
-
-  show_all_children();
 }
 
 bool Dialog_User::check_password()
diff --git a/glom/mode_design/users/dialog_users_list.cc b/glom/mode_design/users/dialog_users_list.cc
index b63c175..5754272 100644
--- a/glom/mode_design/users/dialog_users_list.cc
+++ b/glom/mode_design/users/dialog_users_list.cc
@@ -83,8 +83,6 @@ Dialog_UsersList::Dialog_UsersList(BaseObjectType* cobject, const Glib::RefPtr<G
   m_button_user_edit->signal_clicked().connect( sigc::mem_fun(*this, &Dialog_UsersList::on_button_user_edit) 
);
 
   enable_buttons();
-
-  show_all_children();
 }
 
 void Dialog_UsersList::enable_buttons()
diff --git a/glom/mode_find/box_data_details_find.cc b/glom/mode_find/box_data_details_find.cc
index 7a8fbc0..4b2aa39 100644
--- a/glom/mode_find/box_data_details_find.cc
+++ b/glom/mode_find/box_data_details_find.cc
@@ -41,8 +41,6 @@ Box_Data_Details_Find::Box_Data_Details_Find()
 #endif
 
   m_FlowTable.set_find_mode();
-
-  show_all_children();
 }
 
 bool Box_Data_Details_Find::init_db_details(const Glib::ustring& table_name, const Glib::ustring& 
layout_platform)
diff --git a/glom/mode_find/box_data_list_find.cc b/glom/mode_find/box_data_list_find.cc
index f3dc30d..690d9ba 100644
--- a/glom/mode_find/box_data_list_find.cc
+++ b/glom/mode_find/box_data_list_find.cc
@@ -39,8 +39,6 @@ Box_Data_List_Find::Box_Data_List_Find()
 
   //Prevent the widget from trying to add or change records:
   m_AddDel.set_find_mode();
-
-  show_all_children();
 }
 
 void Box_Data_List_Find::create_layout()
diff --git a/glom/mode_find/notebook_find.cc b/glom/mode_find/notebook_find.cc
index dcb6eeb..cdc55c3 100644
--- a/glom/mode_find/notebook_find.cc
+++ b/glom/mode_find/notebook_find.cc
@@ -47,9 +47,6 @@ Notebook_Find::Notebook_Find()
 
 
   add_view(&m_Box_Details);
-
-  show_all_children();
-
 }
 
 Notebook_Find::~Notebook_Find()
diff --git a/glom/navigation/box_tables.cc b/glom/navigation/box_tables.cc
index 452cd8c..54e051c 100644
--- a/glom/navigation/box_tables.cc
+++ b/glom/navigation/box_tables.cc
@@ -62,8 +62,6 @@ Box_Tables::Box_Tables(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Builder>
   m_AddDel.signal_user_changed().connect(sigc::mem_fun(*this, &Box_Tables::on_adddel_changed));
 #endif //GLOM_ENABLE_CLIENT_ONLY
   m_AddDel.signal_user_requested_edit().connect(sigc::mem_fun(*this, &Box_Tables::on_adddel_edit));
-
-  show_all_children();
 }
 
 void Box_Tables::fill_table_row(const Gtk::TreeModel::iterator& iter, const std::shared_ptr<const 
TableInfo>& table_info)
diff --git a/glom/utility_widgets/adddel/adddel.cc b/glom/utility_widgets/adddel/adddel.cc
index 3356c3e..b8d3977 100644
--- a/glom/utility_widgets/adddel/adddel.cc
+++ b/glom/utility_widgets/adddel/adddel.cc
@@ -102,8 +102,6 @@ void AddDel::init()
   set_ignore_treeview_signals(false);
 
   remove_all_columns(); //set up the default columns.
-
-  show_all_children();
 }
 
 void AddDel::set_treeview_accessible_name(const Glib::ustring& name)
diff --git a/glom/utility_widgets/dialog_flowtable.cc b/glom/utility_widgets/dialog_flowtable.cc
index b66b7fb..7efb873 100644
--- a/glom/utility_widgets/dialog_flowtable.cc
+++ b/glom/utility_widgets/dialog_flowtable.cc
@@ -44,8 +44,6 @@ Dialog_FlowTable::Dialog_FlowTable(BaseObjectType* cobject, const Glib::RefPtr<G
   m_spin_columns->set_range(0, 10);
   m_spin_columns->set_increments(1, 2);
   m_spin_columns->set_value(3); //A sensible default.
-
-  show_all_children();
 }
 
 void Dialog_FlowTable::set_flowtable(FlowTableWithFields* flowtable)
diff --git a/glom/utility_widgets/dialog_properties.cc b/glom/utility_widgets/dialog_properties.cc
index 841be9d..ea0c119 100644
--- a/glom/utility_widgets/dialog_properties.cc
+++ b/glom/utility_widgets/dialog_properties.cc
@@ -41,9 +41,7 @@ Dialog_Properties::Dialog_Properties(BaseObjectType* cobject, const Glib::RefPtr
 
   //Connect signal handlers:
   m_button_cancel->signal_clicked().connect( sigc::mem_fun(*this, &Dialog_Properties::on_button_cancel) );
-  m_button_save->signal_clicked().connect( sigc::mem_fun(*this, &Dialog_Properties::on_button_save) );
-
-  show_all_children();
+  m_button_save->signal_clicked().connect( sigc::mem_fun(*this, &Dialog_Properties::on_button_save) );;
 }
 
 Dialog_Properties::type_signal_apply Dialog_Properties::signal_apply()
diff --git a/glom/utility_widgets/layouttoolbar.cc b/glom/utility_widgets/layouttoolbar.cc
index e954a30..fc7e9e1 100644
--- a/glom/utility_widgets/layouttoolbar.cc
+++ b/glom/utility_widgets/layouttoolbar.cc
@@ -65,8 +65,6 @@ LayoutToolbar::LayoutToolbar()
   add(m_group_items);
 
   set_drag_source();
-
-  show_all_children();
 }
 
 } // namespace Glom
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]