[glom/gtkmm4v3: 20/21] gtkmm4: Remove calls to show_all().



commit 110dca7dc8ad0a41f623aed34f898dc223dfa131
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Mar 14 10:26:10 2017 +0100

    gtkmm4: Remove calls to show_all().
    
    This has been removed from gtkmm4. Apparently child widgets are now
    visible by default.

 glom/appwindow.cc                                  |    1 -
 glom/frame_glom.cc                                 |    6 ------
 glom/mode_data/datawidget/datawidget.cc            |    2 --
 glom/mode_data/flowtablewithfields.cc              |    2 --
 .../print_layouts/window_print_layout_edit.cc      |    1 -
 5 files changed, 0 insertions(+), 12 deletions(-)
---
diff --git a/glom/appwindow.cc b/glom/appwindow.cc
index b6ad910..795f7b1 100644
--- a/glom/appwindow.cc
+++ b/glom/appwindow.cc
@@ -228,7 +228,6 @@ bool AppWindow::init_with_document(const Glib::ustring& document_uri, bool resto
   }
 
   return true;
-  //show_all();
 }
 
 bool AppWindow::get_show_sql_debug() const
diff --git a/glom/frame_glom.cc b/glom/frame_glom.cc
index 1e451ce..8e7d926 100644
--- a/glom/frame_glom.cc
+++ b/glom/frame_glom.cc
@@ -141,7 +141,6 @@ Frame_Glom::Frame_Glom(BaseObjectType* cobject, const Glib::RefPtr<Gtk::Builder>
     *Gtk::manage(new Gtk::Label(_("Found:"))), Gtk::PACK_SHRINK);
   m_box_records_count.pack_start(m_label_found_count, Gtk::PACK_SHRINK);
   m_box_records_count.pack_start(m_button_find_all, Gtk::PACK_SHRINK);
-  m_box_records_count.show_all();
   m_notebook_data.set_action_widget(&m_box_records_count, Gtk::PACK_END);
   m_button_find_all.signal_clicked().connect(
     sigc::mem_fun(*this, &Frame_Glom::on_button_find_all) );
@@ -431,8 +430,6 @@ void Frame_Glom::show_table_allow_empty(const Glib::ustring& table_name, const G
     pApp->fill_menu_reports(table_name);
     pApp->fill_menu_print_layouts(table_name);
   }
-
-  //show_all();
 }
 
 void Frame_Glom::show_table(const Glib::ustring& table_name, const Gnome::Gda::Value& 
primary_key_value_for_details)
@@ -1104,7 +1101,6 @@ void Frame_Glom::do_menu_Navigate_Table(bool open_default)
       m_dialog_tables->set_transient_for(*pWindow);
 
     m_dialog_tables->set_default_size(300, 400);
-    m_box_tables->show_all();
     add_view(m_box_tables);
 
     //Connect signals:
@@ -1584,7 +1580,6 @@ void Frame_Glom::on_menu_developer_reports()
     m_dialog_layout_report->signal_hide().connect( sigc::mem_fun(*this, 
&Frame_Glom::on_dialog_layout_report_hide) );
 
     m_dialog_reports->set_default_size(300, 400);
-    m_box_reports->show_all();
 
     m_box_reports->signal_selected.connect(sigc::mem_fun(*this, &Frame_Glom::on_box_reports_selected));
     add_view(m_box_reports);
@@ -1616,7 +1611,6 @@ void Frame_Glom::on_menu_developer_print_layouts()
     m_dialog_print_layouts->set_transient_for(*get_app_window());
     m_dialog_print_layouts->set_title(_("Print Layouts"));
     m_dialog_print_layouts->set_default_size(300, 400);
-    m_box_print_layouts->show_all();
     add_view(m_box_print_layouts);
 
     m_box_print_layouts->signal_selected.connect(sigc::mem_fun(*this, 
&Frame_Glom::on_box_print_layouts_selected));
diff --git a/glom/mode_data/datawidget/datawidget.cc b/glom/mode_data/datawidget/datawidget.cc
index ad5a045..cfcf816 100644
--- a/glom/mode_data/datawidget/datawidget.cc
+++ b/glom/mode_data/datawidget/datawidget.cc
@@ -172,8 +172,6 @@ DataWidget::DataWidget(const std::shared_ptr<LayoutItem_Field>& field, const Gli
 
     m_child = dynamic_cast<Gtk::Widget*>(pFieldWidget);
     set_child_size_by_field(field);
-
-    m_child->show_all();
   }
 
   if(m_child)
diff --git a/glom/mode_data/flowtablewithfields.cc b/glom/mode_data/flowtablewithfields.cc
index d8132a0..1a4c117 100644
--- a/glom/mode_data/flowtablewithfields.cc
+++ b/glom/mode_data/flowtablewithfields.cc
@@ -458,7 +458,6 @@ void FlowTableWithFields::add_field(const std::shared_ptr<LayoutItem_Field>& lay
   add_view(pDataWidget); //So it can get the document.
 
   info.m_second = pDataWidget;
-  info.m_second->show_all();
 
   //Add a label, if one is necessary:
   //We put it inside a box so that halign works as we want.
@@ -503,7 +502,6 @@ void FlowTableWithFields::add_field(const std::shared_ptr<LayoutItem_Field>& lay
   info.m_first_eventbox = eventbox; //Remember it so we can retrieve the column number later from FlowTable.
   eventbox->set_visible_window(false);
   eventbox->set_events(Gdk::ALL_EVENTS_MASK);
-  eventbox->show_all();
 
   add_widgets(*eventbox, *(info.m_second), true);
 
diff --git a/glom/mode_design/print_layouts/window_print_layout_edit.cc 
b/glom/mode_design/print_layouts/window_print_layout_edit.cc
index 8c317c6..a5aa09c 100644
--- a/glom/mode_design/print_layouts/window_print_layout_edit.cc
+++ b/glom/mode_design/print_layouts/window_print_layout_edit.cc
@@ -144,7 +144,6 @@ Window_PrintLayout_Edit::Window_PrintLayout_Edit(BaseObjectType* cobject, const
 
   m_scrolled_window.set_policy(Gtk::POLICY_AUTOMATIC, Gtk::POLICY_AUTOMATIC);
   m_scrolled_window.add(m_canvas);
-  m_scrolled_window.show_all();
   m_box_canvas->pack_start(m_scrolled_window);
   m_canvas.show();
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]