[gnome-builder] autotools: Check exit status of make subprocess



commit 75644edbe77638a1849cd59d4a0cef82bc2d8c89
Author: Matthew Leeds <mleeds redhat com>
Date:   Mon Mar 13 23:32:50 2017 -0500

    autotools: Check exit status of make subprocess
    
    By using the wait_check_async and wait_check_finish functions, we can
    make sure to return an error for the task when make fails, so the user
    sees "Failed" in the omnibar and right panel.

 plugins/autotools/ide-autotools-make-stage.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
---
diff --git a/plugins/autotools/ide-autotools-make-stage.c b/plugins/autotools/ide-autotools-make-stage.c
index 58b6b80..59432e1 100644
--- a/plugins/autotools/ide-autotools-make-stage.c
+++ b/plugins/autotools/ide-autotools-make-stage.c
@@ -143,7 +143,7 @@ ide_autotools_make_stage_wait_cb (GObject      *object,
   g_assert (IDE_IS_SUBPROCESS (subprocess));
   g_assert (G_IS_ASYNC_RESULT (result));
 
-  if (!ide_subprocess_wait_finish (subprocess, result, &error))
+  if (!ide_subprocess_wait_check_finish (subprocess, result, &error))
     g_task_return_error (task, g_steal_pointer (&error));
   else
     g_task_return_boolean (task, TRUE);
@@ -215,10 +215,10 @@ ide_autotools_make_stage_execute_async (IdeBuildStage       *stage,
 
   ide_build_stage_log_subprocess (stage, subprocess);
 
-  ide_subprocess_wait_async (subprocess,
-                             cancellable,
-                             ide_autotools_make_stage_wait_cb,
-                             g_steal_pointer (&task));
+  ide_subprocess_wait_check_async (subprocess,
+                                   cancellable,
+                                   ide_autotools_make_stage_wait_cb,
+                                   g_steal_pointer (&task));
 
   IDE_EXIT;
 }
@@ -293,10 +293,10 @@ ide_autotools_make_stage_clean_async (IdeBuildStage       *stage,
 
   ide_build_stage_log_subprocess (stage, subprocess);
 
-  ide_subprocess_wait_async (subprocess,
-                             cancellable,
-                             ide_autotools_make_stage_wait_cb,
-                             g_steal_pointer (&task));
+  ide_subprocess_wait_check_async (subprocess,
+                                   cancellable,
+                                   ide_autotools_make_stage_wait_cb,
+                                   g_steal_pointer (&task));
 
   IDE_EXIT;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]