[orca] Eliminate double-presentation of selection changes in editable comboboxes



commit dafd38c787e091bef98173cdc6a59db5a496fb93
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Sat Mar 11 10:12:02 2017 -0500

    Eliminate double-presentation of selection changes in editable comboboxes

 src/orca/scripts/default.py |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/src/orca/scripts/default.py b/src/orca/scripts/default.py
index 65fe16f..de7f5e1 100644
--- a/src/orca/scripts/default.py
+++ b/src/orca/scripts/default.py
@@ -2387,11 +2387,11 @@ class Script(script.Script):
         """Callback for object:selection-changed accessibility events."""
 
         obj = event.source
+        state = obj.getState()
 
         if self.utilities.handlePasteLocusOfFocusChange():
             orca.setLocusOfFocus(event, event.source, False)
         else:
-            state = obj.getState()
             if state.contains(pyatspi.STATE_MANAGES_DESCENDANTS):
                 return
 
@@ -2403,6 +2403,12 @@ class Script(script.Script):
         keyString, mods = self.utilities.lastKeyAndModifiers()
         if keyString == "space":
             return
+
+        role = obj.getRole()
+        if role == pyatspi.ROLE_COMBO_BOX and not state.contains(pyatspi.STATE_EXPANDED):
+            entry = self.utilities.getEntryForEditableComboBox(event.source)
+            if entry and entry.getState().contains(pyatspi.STATE_FOCUSED):
+                return
  
         selectedChildren = self.utilities.selectedChildren(obj)
         for child in selectedChildren:


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]