[gnumeric] ods: write names in a way that Excel will read.



commit 8813076d1a92456ca1f2613a928d1e680d2a5fb1
Author: Morten Welinder <terra gnome org>
Date:   Thu Mar 9 10:28:23 2017 -0500

    ods: write names in a way that Excel will read.

 plugins/openoffice/ChangeLog          |    8 +++++++-
 plugins/openoffice/openoffice-write.c |    5 +++++
 2 files changed, 12 insertions(+), 1 deletions(-)
---
diff --git a/plugins/openoffice/ChangeLog b/plugins/openoffice/ChangeLog
index 04647ee..0578018 100644
--- a/plugins/openoffice/ChangeLog
+++ b/plugins/openoffice/ChangeLog
@@ -1,6 +1,12 @@
+2017-03-09  Morten Welinder  <terra gnome org>
+
+       * openoffice-write.c (odf_write_named_expression): Don't write
+       range-usable-as attribute.
+
 2017-01-30  Andreas J. Guelzow <aguelzow pyrshep ca>
 
-       * openoffice-read.c (oo_cell_content_link) local links may be prefixed with #
+       * openoffice-read.c (oo_cell_content_link) local links may be
+       prefixed with #
        * openoffice-write.c (odf_write_objects) prefix local links with #
 
 2017-03-06  Morten Welinder  <terra gnome org>
diff --git a/plugins/openoffice/openoffice-write.c b/plugins/openoffice/openoffice-write.c
index c96766a..88b5d20 100644
--- a/plugins/openoffice/openoffice-write.c
+++ b/plugins/openoffice/openoffice-write.c
@@ -4864,9 +4864,14 @@ odf_write_named_expression (G_GNUC_UNUSED gpointer key, GnmNamedExpr *nexpr,
                g_free (formula);
                gnm_expr_top_unref (texpr);
 
+#if 0
+               // This would be the right thing to do per the spec, but
+               // Excel ignores any name that has the attribute.  LO does
+               // not seem to write this.
                gsf_xml_out_add_cstr_unchecked
                        (state->xml, TABLE "range-usable-as",
                         "print-range filter repeat-row repeat-column");
+#endif
 
                if (nexpr->pos.sheet != NULL && state->with_extension
                    && (state->odf_version < 102))


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]