[gnome-builder] buildui: only clear diagnostics if rebuilding



commit 2c05d8e98b967c5712e3ad6cdf862784b7e34d1c
Author: Christian Hergert <chergert redhat com>
Date:   Wed Mar 8 17:15:21 2017 -0800

    buildui: only clear diagnostics if rebuilding
    
    If we are not advancing to or past IDE_BUILD_PHASE_BUILD, then there is no
    need to clear the previous diagnostics.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=779526

 libide/buildui/ide-build-panel.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)
---
diff --git a/libide/buildui/ide-build-panel.c b/libide/buildui/ide-build-panel.c
index da9547d..3fdb9ac 100644
--- a/libide/buildui/ide-build-panel.c
+++ b/libide/buildui/ide-build-panel.c
@@ -178,14 +178,17 @@ ide_build_panel_started (IdeBuildPanel    *self,
   g_assert (IDE_IS_BUILD_PANEL (self));
   g_assert (IDE_IS_BUILD_PIPELINE (pipeline));
 
-  self->error_count = 0;
-  self->warning_count = 0;
+  if (phase >= IDE_BUILD_PHASE_BUILD)
+    {
+      self->error_count = 0;
+      self->warning_count = 0;
 
-  gtk_label_set_label (self->warnings_label, "—");
-  gtk_label_set_label (self->errors_label, "—");
+      gtk_label_set_label (self->warnings_label, "—");
+      gtk_label_set_label (self->errors_label, "—");
 
-  gtk_list_store_clear (self->diagnostics_store);
-  g_hash_table_remove_all (self->diags_hash);
+      gtk_list_store_clear (self->diagnostics_store);
+      g_hash_table_remove_all (self->diags_hash);
+    }
 
   IDE_EXIT;
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]