[evolution] Bug 779746 - Possible use-after-free in 'Edit as New Message'



commit 4320fcb9e923194897d83c13d7690f5ce326b127
Author: Milan Crha <mcrha redhat com>
Date:   Wed Mar 8 12:48:35 2017 +0100

    Bug 779746 - Possible use-after-free in 'Edit as New Message'

 src/composer/e-msg-composer.c |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/src/composer/e-msg-composer.c b/src/composer/e-msg-composer.c
index ac8881c..1268fe1 100644
--- a/src/composer/e-msg-composer.c
+++ b/src/composer/e-msg-composer.c
@@ -3558,7 +3558,7 @@ e_msg_composer_setup_with_message (EMsgComposer *composer,
        EHTMLEditor *editor;
        EContentEditor *cnt_editor;
        GtkToggleAction *action;
-       gchar *identity_uid, *tmp = NULL;
+       gchar *identity_uid;
        gint len, i;
        guint jj, jjlen;
        gboolean is_message_from_draft = FALSE;
@@ -3607,10 +3607,8 @@ e_msg_composer_setup_with_message (EMsgComposer *composer,
                if (!identity_uid) {
                        source = em_utils_guess_mail_identity_with_recipients (
                                e_shell_get_registry (e_msg_composer_get_shell (composer)), message, NULL, 
NULL, NULL, NULL);
-                       if (source) {
-                               tmp = e_source_dup_uid (source);
-                               identity_uid = tmp;
-                       }
+                       if (source)
+                               identity_uid = e_source_dup_uid (source);
                }
        }
 
@@ -3620,8 +3618,6 @@ e_msg_composer_setup_with_message (EMsgComposer *composer,
                        table, identity_uid);
        }
 
-       g_free (tmp);
-
        auto_cc = g_hash_table_new_full (
                (GHashFunc) camel_strcase_hash,
                (GEqualFunc) camel_strcase_equal,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]