[gnome-builder] omnibar: remove "Build: " prefix for messages



commit c95f0306429ecb4ab2e8482a327cc8ead0d83bf8
Author: Christian Hergert <chergert redhat com>
Date:   Wed Mar 8 01:26:25 2017 -0800

    omnibar: remove "Build: " prefix for messages
    
    We don't really need this anymore, and it just wastes space. We should
    instead make our build messages very clear as they come from the
    particular build stages/phases.

 libide/workbench/ide-omni-bar.c |   29 +++--------------------------
 1 files changed, 3 insertions(+), 26 deletions(-)
---
diff --git a/libide/workbench/ide-omni-bar.c b/libide/workbench/ide-omni-bar.c
index d286195..2a80f3e 100644
--- a/libide/workbench/ide-omni-bar.c
+++ b/libide/workbench/ide-omni-bar.c
@@ -154,25 +154,6 @@ date_time_to_label (GBinding     *binding,
 }
 
 static gboolean
-message_to_label (GBinding     *binding,
-                  const GValue *from_value,
-                  GValue       *to_value,
-                  gpointer      user_data)
-{
-  g_assert (G_IS_BINDING (binding));
-  g_assert (from_value != NULL);
-  g_assert (G_VALUE_HOLDS (from_value, G_TYPE_STRING));
-  g_assert (to_value != NULL);
-  g_assert (G_VALUE_HOLDS (to_value, G_TYPE_STRING));
-
-  g_value_take_string (to_value,
-                       /* translators: this message is shown in the header bar to indicate build status */
-                       g_strdup_printf (_("Build: %s"), g_value_get_string (from_value)));
-
-  return TRUE;
-}
-
-static gboolean
 file_to_relative_path (GBinding     *binding,
                        const GValue *from_value,
                        GValue       *to_value,
@@ -700,13 +681,9 @@ ide_omni_bar_init (IdeOmniBar *self)
                                NULL,
                                NULL);
 
-  egg_binding_group_bind_full (self->build_manager_bindings,
-                               "message",
-                               self->build_result_mode_label,
-                               "label",
-                               G_BINDING_SYNC_CREATE,
-                               message_to_label,
-                               NULL, NULL, NULL);
+  egg_binding_group_bind (self->build_manager_bindings, "message",
+                          self->build_result_mode_label, "label",
+                          G_BINDING_SYNC_CREATE);
 
   egg_binding_group_bind (self->build_manager_bindings,
                           "message",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]