[gnumeric] Names: plug leak.



commit 0576e695e64f07aad13dda833c6d5ede4d016109
Author: Morten Welinder <terra gnome org>
Date:   Mon Mar 6 20:12:41 2017 -0500

    Names: plug leak.

 ChangeLog       |    4 ++++
 NEWS            |    1 +
 src/expr-name.c |    3 ++-
 3 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index ec44f08..6b07f21 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2017-03-06  Morten Welinder  <terra gnome org>
+
+       * src/expr-name.c (expr_name_add): Plug leak.
+
 2017-03-05  Morten Welinder  <terra gnome org>
 
        * src/hlink.c (GnmHLinkCurWB): Store location as dependent.
diff --git a/NEWS b/NEWS
index bef13bb..867b8b1 100644
--- a/NEWS
+++ b/NEWS
@@ -14,6 +14,7 @@ Morten:
        * Test suite improvements.
        * Improve Excel handling of hyperlinks.
        * Hyperlinks improvements.  [#706671]
+       * Plug leaks.
 
 --------------------------------------------------------------------------
 Gnumeric 1.12.33
diff --git a/src/expr-name.c b/src/expr-name.c
index f17f527..b5a31cc 100644
--- a/src/expr-name.c
+++ b/src/expr-name.c
@@ -733,7 +733,8 @@ expr_name_add (GnmParsePos const *pp, char const *name,
        if (nexpr != NULL) {
                if (texpr == NULL) {
                        /* there was already a placeholder for this */
-                       expr_name_ref (nexpr);
+                       if (!link_to_container)
+                               expr_name_ref (nexpr);
                        return nexpr;
                }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]