[metacity] don't leave focus on a window we are unmanaging when sending WM_TAKE_FOCUS

commit 5064d412969f16466fd540dc5b6737f346402595
Author: Owen W. Taylor <otaylor fishsoup net>
Date:   Mon Dec 16 12:20:02 2013 -0500

    don't leave focus on a window we are unmanaging when sending WM_TAKE_FOCUS
    When we move focus elsewhere when unmanaging a window, we *need* to move
    the focus, so if the target is globally active, move the focus to the
    no-focus-window in anticipation that the focus will normally get moved
    to the right window when the target window responds to WM_TAKE_FOCUS.
    If the window doesn't respond to WM_TAKE_FOCUS, then focus will be left
    on the no-focus-window, but there's no way to distinguish whether the
    app will respond or not.

 src/core/window.c |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/src/core/window.c b/src/core/window.c
index 14d76fc..9b171c6 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -4509,6 +4509,25 @@ meta_window_focus (MetaWindow  *window,
                       "Sending WM_TAKE_FOCUS to %s since take_focus = true\n",
+          if (!window->input)
+            {
+              /* The "Globally Active Input" window case, where the window
+               * doesn't want us to call XSetInputFocus on it, but does
+               * want us to send a WM_TAKE_FOCUS.
+               *
+               * Normally, we want to just leave the focus undisturbed until
+               * the window respnds to WM_TAKE_FOCUS, but if we're unmanaging
+               * the current focus window we *need* to move the focus away, so
+               * we focus the no_focus_window now (and set
+               * display->focus_window to that) before sending WM_TAKE_FOCUS.
+               */
+              if (window->display->focus_window != NULL &&
+                  window->display->focus_window->unmanaging)
+                meta_display_focus_the_no_focus_window (window->display,
+                                                        window->screen,
+                                                        timestamp);
+            }
           meta_display_request_take_focus (window->display,

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]