[metacity] stack: never focus unmanaging windows

commit 33a6a39c9a7f1a0d706d79175c7ed157984f3da0
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Thu Sep 4 13:53:06 2014 -0700

    stack: never focus unmanaging windows
    We can enter weird states where get_default_window is called during
    window unmanagement, before the window has been fully removed from
    the stack. Make sure these windows are *never* returned from
    get_default_window, as focusing them can cause an assertion fail,
    or worse.

 src/core/window.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/core/window.c b/src/core/window.c
index e7163b8..c9130ad 100644
--- a/src/core/window.c
+++ b/src/core/window.c
@@ -1110,8 +1110,7 @@ meta_window_free (MetaWindow  *window,
                   "Focusing default window since we're unmanaging %s\n",
       meta_workspace_focus_default_window (window->screen->active_workspace,
-                                           window,
-                                           timestamp);
+                                           NULL, timestamp);
   else if (window->display->expected_focus_window == window)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]