[vala/0.34] gtkmodule: Preserve order of required-gtype-classes for reproducibility



commit 65db7e626a977a4b08cb2a5e182af4518f998eeb
Author: Niko Tyni <ntyni debian org>
Date:   Mon Oct 19 23:56:36 2015 +0300

    gtkmodule: Preserve order of required-gtype-classes for reproducibility
    
    The elements of current_required_app_classes end up in the generated
    code in g_type_ensure() statements. The order of these can vary
    between builds when using a HashSet, breaking reproducibilty.
    
    See https://wiki.debian.org/ReproducibleBuilds
    
    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=802528

 codegen/valagtkmodule.vala |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/codegen/valagtkmodule.vala b/codegen/valagtkmodule.vala
index 07c022e..1558469 100644
--- a/codegen/valagtkmodule.vala
+++ b/codegen/valagtkmodule.vala
@@ -32,7 +32,7 @@ public class Vala.GtkModule : GSignalModule {
        /* GtkBuilder xml child to Vala class mapping */
        private HashMap<string, Class> current_child_to_class_map = new HashMap<string, Class>(str_hash, 
str_equal);
        /* Required custom application-specific gtype classes to be ref'd before initializing the template */
-       private HashSet<Class> current_required_app_classes = new HashSet<Class>();
+       private List<Class> current_required_app_classes = new ArrayList<Class>();
 
        private void ensure_cclass_to_vala_map () {
                // map C name of gtypeinstance classes to Vala classes


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]