[tracker/wip/carlosg/domain-ontologies: 80/124] libtracker-miner: Remove tracker_miner_fs_[sg]et_initial_crawling()



commit 3dea8565416ffd3e79ac0b9dbd8d6e89ea999501
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sun Jun 18 13:18:21 2017 +0200

    libtracker-miner: Remove tracker_miner_fs_[sg]et_initial_crawling()
    
    It did nothing at the libtracker-miner level, and can be safely removed.

 .../libtracker-miner/libtracker-miner-sections.txt |    2 -
 src/libtracker-miner/tracker-miner-fs.c            |   75 +-------------------
 src/libtracker-miner/tracker-miner-fs.h            |    4 -
 src/libtracker-miner/tracker-miner.vapi            |    3 -
 4 files changed, 1 insertions(+), 83 deletions(-)
---
diff --git a/docs/reference/libtracker-miner/libtracker-miner-sections.txt 
b/docs/reference/libtracker-miner/libtracker-miner-sections.txt
index c842388..cc16d28 100644
--- a/docs/reference/libtracker-miner/libtracker-miner-sections.txt
+++ b/docs/reference/libtracker-miner/libtracker-miner-sections.txt
@@ -185,9 +185,7 @@ tracker_miner_fs_error_quark
 tracker_miner_fs_get_indexing_tree
 tracker_miner_fs_get_data_provider
 tracker_miner_fs_get_throttle
-tracker_miner_fs_get_initial_crawling
 tracker_miner_fs_set_throttle
-tracker_miner_fs_set_initial_crawling
 tracker_miner_fs_add_directory_without_parent
 tracker_miner_fs_directory_add
 tracker_miner_fs_directory_remove
diff --git a/src/libtracker-miner/tracker-miner-fs.c b/src/libtracker-miner/tracker-miner-fs.c
index 15298e9..c345773 100644
--- a/src/libtracker-miner/tracker-miner-fs.c
+++ b/src/libtracker-miner/tracker-miner-fs.c
@@ -198,8 +198,6 @@ struct _TrackerMinerFSPrivate {
 
        /* Properties */
        gdouble throttle;
-       guint initial_crawling : 1; /* TRUE if initial crawling should be
-                                    * done */
 
        /* Writeback tasks */
        TrackerTaskPool *writeback_pool;
@@ -266,8 +264,7 @@ enum {
        PROP_ROOT,
        PROP_WAIT_POOL_LIMIT,
        PROP_READY_POOL_LIMIT,
-       PROP_DATA_PROVIDER,
-       PROP_INITIAL_CRAWLING
+       PROP_DATA_PROVIDER
 };
 
 static void           miner_fs_initable_iface_init        (GInitableIface       *iface);
@@ -405,13 +402,6 @@ tracker_miner_fs_class_init (TrackerMinerFSClass *klass)
                                                              "Data provider populating data, e.g. like 
GFileEnumerator",
                                                              TRACKER_TYPE_DATA_PROVIDER,
                                                              G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
-       g_object_class_install_property (object_class,
-                                        PROP_INITIAL_CRAWLING,
-                                        g_param_spec_boolean ("initial-crawling",
-                                                              "Initial crawling",
-                                                              "Whether to perform initial crawling or not",
-                                                              TRUE,
-                                                              G_PARAM_READWRITE));
 
        /**
         * TrackerMinerFS::process-file:
@@ -668,8 +658,6 @@ tracker_miner_fs_init (TrackerMinerFS *object)
        priv->quark_attribute_updated = g_quark_from_static_string ("tracker-attribute-updated");
        priv->quark_reentry_counter = g_quark_from_static_string ("tracker-reentry-counter");
 
-       priv->initial_crawling = TRUE;
-
        priv->roots_to_notify = g_hash_table_new_full (g_file_hash,
                                                       (GEqualFunc) g_file_equal,
                                                       g_object_unref,
@@ -906,9 +894,6 @@ fs_set_property (GObject      *object,
        case PROP_DATA_PROVIDER:
                fs->priv->data_provider = g_value_dup_object (value);
                break;
-       case PROP_INITIAL_CRAWLING:
-               fs->priv->initial_crawling = g_value_get_boolean (value);
-               break;
        default:
                G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
                break;
@@ -941,9 +926,6 @@ fs_get_property (GObject    *object,
        case PROP_DATA_PROVIDER:
                g_value_set_object (value, fs->priv->data_provider);
                break;
-       case PROP_INITIAL_CRAWLING:
-               g_value_set_boolean (value, fs->priv->initial_crawling);
-               break;
        default:
                G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
                break;
@@ -3383,61 +3365,6 @@ tracker_miner_fs_query_urn (TrackerMinerFS *fs,
 }
 
 /**
- * tracker_miner_fs_set_initial_crawling:
- * @fs: a #TrackerMinerFS
- * @do_initial_crawling: a #gboolean
- *
- * Tells the @fs that crawling the #TrackerIndexingTree should happen
- * initially. This is actually required to set up file system monitor
- * using technologies like inotify, etc.
- *
- * Setting this to #FALSE can dramatically improve the start up the
- * crawling of the @fs.
- *
- * The down side is that using this consistently means that some files
- * on the disk may be out of date with files in the database.
- *
- * The main purpose of this function is for systems where a @fs is
- * running the entire time and where it is very unlikely that a file
- * could be changed outside between startup and shutdown of the
- * process using this API.
- *
- * The default if not set directly is that @do_initial_crawling is %TRUE.
- *
- * Since: 0.10
- **/
-void
-tracker_miner_fs_set_initial_crawling (TrackerMinerFS *fs,
-                                       gboolean        do_initial_crawling)
-{
-       g_return_if_fail (TRACKER_IS_MINER_FS (fs));
-
-       fs->priv->initial_crawling = do_initial_crawling;
-}
-
-/**
- * tracker_miner_fs_get_initial_crawling:
- * @fs: a #TrackerMinerFS
- *
- * Returns a boolean which indicates if the indexing tree is crawled
- * upon start up or not. This may be set to %FALSE if working
- * prodominently with cloud data where you can't perform these checks.
- * By default and for local file systems, this is enabled.
- *
- * Returns: %TRUE if a file system structure is crawled for new
- * updates on start up, otherwise %FALSE.
- *
- * Since: 0.10
- **/
-gboolean
-tracker_miner_fs_get_initial_crawling (TrackerMinerFS *fs)
-{
-       g_return_val_if_fail (TRACKER_IS_MINER_FS (fs), FALSE);
-
-       return fs->priv->initial_crawling;
-}
-
-/**
  * tracker_miner_fs_has_items_to_process:
  * @fs: a #TrackerMinerFS
  *
diff --git a/src/libtracker-miner/tracker-miner-fs.h b/src/libtracker-miner/tracker-miner-fs.h
index bbed7a8..f87863e 100644
--- a/src/libtracker-miner/tracker-miner-fs.h
+++ b/src/libtracker-miner/tracker-miner-fs.h
@@ -131,12 +131,8 @@ GQuark                tracker_miner_fs_error_quark           (void);
 TrackerIndexingTree * tracker_miner_fs_get_indexing_tree     (TrackerMinerFS  *fs);
 TrackerDataProvider * tracker_miner_fs_get_data_provider     (TrackerMinerFS  *fs);
 gdouble               tracker_miner_fs_get_throttle          (TrackerMinerFS  *fs);
-gboolean              tracker_miner_fs_get_initial_crawling  (TrackerMinerFS  *fs);
-
 void                  tracker_miner_fs_set_throttle          (TrackerMinerFS  *fs,
                                                               gdouble          throttle);
-void                  tracker_miner_fs_set_initial_crawling  (TrackerMinerFS  *fs,
-                                                              gboolean         do_initial_crawling);
 
 #ifndef TRACKER_DISABLE_DEPRECATED
 /* Setting locations to be processed in IndexingTree */
diff --git a/src/libtracker-miner/tracker-miner.vapi b/src/libtracker-miner/tracker-miner.vapi
index 9f7bec7..3b894bf 100644
--- a/src/libtracker-miner/tracker-miner.vapi
+++ b/src/libtracker-miner/tracker-miner.vapi
@@ -121,16 +121,13 @@ namespace Tracker {
                public void notify_finish (GLib.File file, GLib.Task task, string sparql, GLib.Error error);
                public unowned Tracker.DataProvider get_data_provider ();
                public unowned Tracker.IndexingTree get_indexing_tree ();
-               public bool get_initial_crawling ();
                public double get_throttle ();
                public unowned string? get_urn (GLib.File file);
                public bool has_items_to_process ();
                public string query_urn (GLib.File file);
-               public void set_initial_crawling (bool do_initial_crawling);
                public void set_throttle (double throttle);
                public void writeback_notify (GLib.File file, GLib.Error error);
                public Tracker.DataProvider data_provider { get; construct; }
-               public bool initial_crawling { get; set; }
                [NoAccessorMethod]
                public uint processing_pool_ready_limit { get; set construct; }
                [NoAccessorMethod]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]