[glib/wip/meson] meson: error out if atomic ops would be available with -march=i486
- From: Tim-Philipp Müller <tpm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib/wip/meson] meson: error out if atomic ops would be available with -march=i486
- Date: Mon, 26 Jun 2017 22:54:25 +0000 (UTC)
commit 6a831000e0d38a6badf1f5d37fc6016644dbea82
Author: Tim-Philipp Müller <tim centricular com>
Date: Wed Jun 14 23:57:11 2017 +0100
meson: error out if atomic ops would be available with -march=i486
Same as autotools build.
meson.build | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
---
diff --git a/meson.build b/meson.build
index 9938991..f4d3b7b 100644
--- a/meson.build
+++ b/meson.build
@@ -1198,6 +1198,12 @@ else
endif
glibconfig_conf.set('G_ATOMIC_OP_MEMORY_BARRIER_NEEDED', glib_memory_barrier_needed)
+# Note that the atomic ops are only available with GCC on x86 when
+# using -march=i486 or higher. If we detect that the atomic ops are
+# not available but would be available given the right flags, we want
+# to abort and advise the user to fix their CFLAGS. It's better to do
+# that then to silently fall back on emulated atomic ops just because
+# the user had the wrong build environment.
atomictest = '''void func() {
volatile int atomic = 2;
__sync_bool_compare_and_swap (&atomic, 2, 3);
@@ -1206,6 +1212,9 @@ atomictest = '''void func() {
if cc.compiles(atomictest)
glibconfig_conf.set('G_ATOMIC_LOCK_FREE', true)
else
+ if host_machine.cpu_family() == 'x86' and cc.compiles(atomictest, args : '-march=i486')
+ error('GLib must be built with -march=i486 or later.')
+ endif
glibconfig_conf.set('G_ATOMIC_LOCK_FREE', false)
endif
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]