[libdmapsharing] dmap-share: Don't throw warnings during normal operations
- From: W. Michael Petullo <wmpetullo src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libdmapsharing] dmap-share: Don't throw warnings during normal operations
- Date: Mon, 26 Jun 2017 15:59:14 +0000 (UTC)
commit ebcff4a228612afa7246f0488b56fb2d8bdc0055
Author: Bastien Nocera <hadess hadess net>
Date: Mon Jun 26 17:01:56 2017 +0200
dmap-share: Don't throw warnings during normal operations
DACP (_touch-able._tcp) and DAAP (_daap._tcp) on macOS use the same
default port, 3689, to advertise both services. A single server likely
implements both protocols, and internally routes the requests.
This is not the case with the libdmapsharing, with each protocol getting
its own server running on the port (both in IPv4 and IPv6). When an
application like rhythmbox would launch both possible types of share,
the first one would go without a hitch, the second one would only be
accessible via IPv6 on a different port.
This doesn't make much difference as:
- which port is used is ultimately unimportant as the port is
advertised in mDNS
- the port already being used might mean we're sharing music with
another application on the same machine
and none of those are programming or configuration errors.
Ideally, services with the same port would share a single SoupServer,
but until then, this change will not make any difference in terms of
interoperability.
https://bugzilla.gnome.org/show_bug.cgi?id=766723
Signed-off-by: W. Michael Petullo <mike flyn org>
libdmapsharing/dmap-share.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/libdmapsharing/dmap-share.c b/libdmapsharing/dmap-share.c
index a302e73..10922ec 100644
--- a/libdmapsharing/dmap-share.c
+++ b/libdmapsharing/dmap-share.c
@@ -288,8 +288,8 @@ _dmap_share_server_start (DMAPShare *share)
ret = soup_server_listen_all (share->priv->server, desired_port, 0, &error);
if (ret == FALSE) {
- g_warning ("Unable to start music sharing server on port %d: %s. "
- "Trying any open IPv6 port", desired_port, error->message);
+ g_debug ("Unable to start music sharing server on port %d: %s. "
+ "Trying any open IPv6 port", desired_port, error->message);
g_clear_error (&error);
ret = soup_server_listen_all (share->priv->server, SOUP_ADDRESS_ANY_PORT,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]