[libdmapsharing] daap-share: Fix leak when destroying DaapShare object



commit 603e2936f7bc15b0163b14fae79cae710f82bbf9
Author: Bastien Nocera <hadess hadess net>
Date:   Mon Jun 26 16:58:22 2017 +0200

    daap-share: Fix leak when destroying DaapShare object
    
    The dispose call wasn't chaining up to the parent. Removing the empty
    custom implementation will make GObject call the parent directly.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=784222
    
    Signed-off-by: W. Michael Petullo <mike flyn org>

 libdmapsharing/daap-share.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
---
diff --git a/libdmapsharing/daap-share.c b/libdmapsharing/daap-share.c
index e025196..df5bba6 100644
--- a/libdmapsharing/daap-share.c
+++ b/libdmapsharing/daap-share.c
@@ -50,7 +50,6 @@ static void daap_share_set_property (GObject * object,
 static void daap_share_get_property (GObject * object,
                                     guint prop_id,
                                     GValue * value, GParamSpec * pspec);
-static void daap_share_dispose (GObject * object);
 guint daap_share_get_desired_port (DMAPShare * share);
 const char *daap_share_get_type_of_service (DMAPShare * share);
 void daap_share_server_info (DMAPShare * share,
@@ -100,7 +99,6 @@ daap_share_class_init (DAAPShareClass * klass)
 
        object_class->get_property = daap_share_get_property;
        object_class->set_property = daap_share_set_property;
-       object_class->dispose = daap_share_dispose;
 
        parent_class->get_desired_port = daap_share_get_desired_port;
        parent_class->get_type_of_service = daap_share_get_type_of_service;
@@ -149,12 +147,6 @@ daap_share_get_property (GObject * object,
        }
 }
 
-static void
-daap_share_dispose (GObject * object)
-{
-       /* FIXME: implement in parent */
-}
-
 DAAPShare *
 daap_share_new (const char *name,
                const char *password,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]