[gnome-builder] build: don't include build identifier unless necessary



commit ca2cb6ddceff2a36b79e7e39b79421008f0d6d5f
Author: Christian Hergert <chergert redhat com>
Date:   Sun Jun 18 14:05:11 2017 -0700

    build: don't include build identifier unless necessary
    
    If we include this from ide.h or ide-version.h, we risk causing massive
    rebuilds for things that are not necessary. So instead, just include it
    manually from the places we need it.

 libide/application/ide-application-actions.c |    1 +
 libide/ide-version.h.in                      |    2 --
 libide/ide.h                                 |   20 +++++++++-----------
 plugins/support/ide-support.c                |    1 +
 4 files changed, 11 insertions(+), 13 deletions(-)
---
diff --git a/libide/application/ide-application-actions.c b/libide/application/ide-application-actions.c
index 3b94fb6..452d253 100644
--- a/libide/application/ide-application-actions.c
+++ b/libide/application/ide-application-actions.c
@@ -23,6 +23,7 @@
 
 #include <glib/gi18n.h>
 
+#include "ide-build-ident.h"
 #include "ide-debug.h"
 #include "ide-version.h"
 
diff --git a/libide/ide-version.h.in b/libide/ide-version.h.in
index 04af60b..3c4af55 100644
--- a/libide/ide-version.h.in
+++ b/libide/ide-version.h.in
@@ -23,8 +23,6 @@
 # error "Only <ide.h> can be included directly."
 #endif
 
-#include "ide-build-ident.h"
-
 /**
  * SECTION:jsonrpc-version
  * @short_description: libide version checking
diff --git a/libide/ide.h b/libide/ide.h
index 28b8be4..c4787c7 100644
--- a/libide/ide.h
+++ b/libide/ide.h
@@ -25,11 +25,17 @@ G_BEGIN_DECLS
 
 #define IDE_INSIDE
 
-#include "ide-build-ident.h"
-#include "ide-version.h"
-
 #include "ide-types.h"
 
+#include "ide-context.h"
+#include "ide-debug.h"
+#include "ide-enums.h"
+#include "ide-global.h"
+#include "ide-macros.h"
+#include "ide-object.h"
+#include "ide-service.h"
+#include "ide-version.h"
+
 #include "application/ide-application-addin.h"
 #include "application/ide-application-tool.h"
 #include "application/ide-application.h"
@@ -77,14 +83,6 @@ G_BEGIN_DECLS
 #include "highlighting/ide-highlighter.h"
 #include "history/ide-back-forward-item.h"
 #include "history/ide-back-forward-list.h"
-#include "ide-context.h"
-#include "ide-debug.h"
-#include "ide-enums.h"
-#include "ide-global.h"
-#include "ide-macros.h"
-#include "ide-object.h"
-#include "ide-service.h"
-#include "ide-types.h"
 #include "langserv/ide-langserv-client.h"
 #include "langserv/ide-langserv-completion-provider.h"
 #include "langserv/ide-langserv-diagnostic-provider.h"
diff --git a/plugins/support/ide-support.c b/plugins/support/ide-support.c
index a032584..64c592e 100644
--- a/plugins/support/ide-support.c
+++ b/plugins/support/ide-support.c
@@ -23,6 +23,7 @@
 #include <dazzle.h>
 #include <gtk/gtk.h>
 #include <ide.h>
+#include <ide-build-ident.h>
 #include <string.h>
 
 #include "ide-support.h"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]