[meld] meldapp: Rearrange failure-on-launch logging for better feedback
- From: Kai Willadsen <kaiw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [meld] meldapp: Rearrange failure-on-launch logging for better feedback
- Date: Mon, 12 Jun 2017 20:49:53 +0000 (UTC)
commit 8b6cc1110f8ae6649378f52774d123380d72832d
Author: Kai Willadsen <kai willadsen gmail com>
Date: Tue Jun 13 06:48:09 2017 +1000
meldapp: Rearrange failure-on-launch logging for better feedback
In the case that we actually hit a failure on launch, the raw exception
text isn't really enough; we need the traceback. This will only be
logged at debug level anyway, so no one will see it without manually
changing the log level.
meld/meldapp.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/meld/meldapp.py b/meld/meldapp.py
index 4818358..2aa0906 100644
--- a/meld/meldapp.py
+++ b/meld/meldapp.py
@@ -333,6 +333,7 @@ class MeldApp(Gtk.Application):
auto_merge=auto_merge, new_tab=options.newtab,
focus=i == 0)
except ValueError as err:
+ log.debug("Couldn't open comparison: %s", error, exc_info=True)
error = err
else:
if i > 0:
@@ -346,7 +347,6 @@ class MeldApp(Gtk.Application):
tab.set_merge_output_file(outfile.get_path())
if error:
- log.debug("Couldn't open comparison: %s", error)
if not tab:
parser.local_error(error)
else:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]