[gimp] Bug 783382 - Lava filter broken



commit e122303fe041d7f7ff51c5a37f814ee3bb6e059c
Author: Michael Natterer <mitch gimp org>
Date:   Sat Jun 3 17:08:47 2017 +0200

    Bug 783382 - Lava filter broken
    
    Allow NONE(0) for "wrapmode" (which translates to GEGL_ABYSS_NONE) in
    the plug-in-edge PDB compat wrapper. The old plug-in accepted this
    (undocumented) value and used a GimpPixelFetches in NONE mode.

 app/pdb/plug-in-compat-cmds.c       |    8 ++++++--
 tools/pdbgen/pdb/plug_in_compat.pdb |    8 ++++++--
 2 files changed, 12 insertions(+), 4 deletions(-)
---
diff --git a/app/pdb/plug-in-compat-cmds.c b/app/pdb/plug-in-compat-cmds.c
index 42fe18a..a7d140b 100644
--- a/app/pdb/plug-in-compat-cmds.c
+++ b/app/pdb/plug-in-compat-cmds.c
@@ -1427,6 +1427,10 @@ plug_in_edge_invoker (GimpProcedure         *procedure,
 
           switch (warpmode)
             {
+            case 0:
+              border_behavior = GEGL_ABYSS_NONE;
+              break;
+
             case 1:
               border_behavior = GEGL_ABYSS_LOOP;
               break;
@@ -5565,8 +5569,8 @@ register_plug_in_compat_procs (GimpPDB *pdb)
   gimp_procedure_add_argument (procedure,
                                gimp_param_spec_int32 ("warpmode",
                                                       "warpmode",
-                                                      "Edge detection behavior { WRAP (1), SMEAR (2), BLACK 
(3) }",
-                                                      1, 3, 1,
+                                                      "Edge detection behavior { NONE (0), WRAP (1), SMEAR 
(2), BLACK (3) }",
+                                                      0, 3, 0,
                                                       GIMP_PARAM_READWRITE));
   gimp_procedure_add_argument (procedure,
                                gimp_param_spec_int32 ("edgemode",
diff --git a/tools/pdbgen/pdb/plug_in_compat.pdb b/tools/pdbgen/pdb/plug_in_compat.pdb
index 60a8443..e7dabfa 100644
--- a/tools/pdbgen/pdb/plug_in_compat.pdb
+++ b/tools/pdbgen/pdb/plug_in_compat.pdb
@@ -1211,8 +1211,8 @@ HELP
           desc => 'Input drawable' },
         { name => 'amount', type => '1.0 <= float <= 10.0',
           desc => 'Edge detection amount' },
-        { name => 'warpmode', type => '1 <= int32 <= 3',
-          desc => 'Edge detection behavior { WRAP (1), SMEAR (2), BLACK (3) }' },
+        { name => 'warpmode', type => '0 <= int32 <= 3',
+          desc => 'Edge detection behavior { NONE (0), WRAP (1), SMEAR (2), BLACK (3) }' },
         { name => 'edgemode', type => '0 <= int32 <= 5',
           desc => 'Edge detection algorithm { SOBEL (0), PREWITT (1), GRADIENT (2), ROBERTS (3), 
DIFFERENTIAL (4), LAPLACE (5) }' }
     );
@@ -1229,6 +1229,10 @@ HELP
 
       switch (warpmode)
         {
+       case 0:
+         border_behavior = GEGL_ABYSS_NONE;
+         break;
+
        case 1:
          border_behavior = GEGL_ABYSS_LOOP;
          break;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]