[orca] Ignore layout-only ancestors when identifying top-level browser chrome alerts



commit 2346e3d7c1e5944d13560b430d3b159547cc8cec
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Wed Jul 26 16:57:22 2017 +0200

    Ignore layout-only ancestors when identifying top-level browser chrome alerts

 src/orca/scripts/web/script_utilities.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 9836c27..803a110 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -2352,7 +2352,11 @@ class Utilities(script_utilities.Utilities):
         if not self.isChromeAlert(obj):
             return False
 
-        return obj.parent.getRole() == pyatspi.ROLE_FRAME
+        parent = obj.parent
+        while parent and self.isLayoutOnly(parent):
+            parent = parent.parent
+
+        return parent.getRole() == pyatspi.ROLE_FRAME
 
     def isClickableElement(self, obj):
         if not (obj and self.inDocumentContent(obj)):


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]