[gnome-control-center/wip/gbsneto/new-network-panel: 19/26] network: Wrap panel in a scrolled window



commit d8ec431fc614bbd4157f791747292e116e560786
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Sun Jul 16 14:55:32 2017 -0300

    network: Wrap panel in a scrolled window
    
    After introducing the new single-column layout,
    we can easily hit the case where there are too
    many connections and/or devices and the panel
    gets way too tall.
    
    To fix that, wrap all the widgets inside a
    scrolled window that only scrolls vertically.

 panels/network/network.ui |   68 +++++++++++++++++++++++++++++----------------
 1 files changed, 44 insertions(+), 24 deletions(-)
---
diff --git a/panels/network/network.ui b/panels/network/network.ui
index dfe099f..2f6071d 100644
--- a/panels/network/network.ui
+++ b/panels/network/network.ui
@@ -28,47 +28,67 @@
   <template class="CcNetworkPanel" parent="CcPanel">
     <property name="visible">True</property>
     <property name="can_focus">False</property>
-    <property name="margin">6</property>
+
     <child>
-      <object class="GtkBox" id="main_box">
+      <object class="GtkScrolledWindow">
         <property name="visible">True</property>
         <property name="can_focus">False</property>
-        <property name="spacing">12</property>
-        <property name="orientation">vertical</property>
+        <property name="hscrollbar_policy">never</property>
         <child>
-          <object class="GtkBox">
+          <object class="GtkViewport">
             <property name="visible">True</property>
             <property name="can_focus">False</property>
-            <property name="spacing">3</property>
-            <property name="orientation">vertical</property>
-
-            <!-- Each GtkBox below will contain GtkStacks from the NetDevices -->
+            <property name="shadow_type">none</property>
             <child>
               <object class="GtkBox">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
+                <property name="spacing">12</property>
+                <property name="margin">18</property>
                 <property name="orientation">vertical</property>
+                <property name="halign">center</property>
+                <property name="valign">start</property>
+
                 <child>
-                  <object class="GtkBox" id="box_wired">
-                    <property name="visible">True</property>
-                    <property name="can_focus">False</property>
-                    <property name="orientation">vertical</property>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkBox" id="box_vpn">
-                    <property name="visible">True</property>
-                    <property name="can_focus">False</property>
-                    <property name="orientation">vertical</property>
-                  </object>
-                </child>
-                <child>
-                  <object class="GtkBox" id="box_proxy">
+                  <object class="GtkBox">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
+                    <property name="spacing">12</property>
                     <property name="orientation">vertical</property>
+                    <property name="width_request">350</property>
+
+                    <!-- Each GtkBox below will contain GtkStacks from the NetDevices -->
+                    <child>
+                      <object class="GtkBox">
+                        <property name="visible">True</property>
+                        <property name="can_focus">False</property>
+                        <property name="orientation">vertical</property>
+                        <child>
+                          <object class="GtkBox" id="box_wired">
+                            <property name="visible">True</property>
+                            <property name="can_focus">False</property>
+                            <property name="orientation">vertical</property>
+                          </object>
+                        </child>
+                        <child>
+                          <object class="GtkBox" id="box_vpn">
+                            <property name="visible">True</property>
+                            <property name="can_focus">False</property>
+                            <property name="orientation">vertical</property>
+                          </object>
+                        </child>
+                        <child>
+                          <object class="GtkBox" id="box_proxy">
+                            <property name="visible">True</property>
+                            <property name="can_focus">False</property>
+                            <property name="orientation">vertical</property>
+                          </object>
+                        </child>
+                      </object>
+                    </child>
                   </object>
                 </child>
+
               </object>
             </child>
           </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]