[gegl] buffer: reduce length of critical section in cache

[Øyvind Kolås <ok src gnome org>]

commit 63e164d8982d0a3149d0fe6f636e5c28d7b0fb1c
Author: Øyvind Kolås <pippin gimp org>
Date:   Sat Jul 22 02:06:10 2017 +0200

    buffer: reduce length of critical section in cache

 gegl/buffer/gegl-cache.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)
---
diff --git a/gegl/buffer/gegl-cache.c b/gegl/buffer/gegl-cache.c
index 47cde7f..ff5ca8b 100644
--- a/gegl/buffer/gegl-cache.c
+++ b/gegl/buffer/gegl-cache.c
@@ -262,7 +262,6 @@ gegl_cache_invalidate (GeglCache           *self,
                        const GeglRectangle *roi)
 {
   gint i;
-  g_mutex_lock (&self->mutex);
 
   if (roi)
     {
@@ -270,8 +269,11 @@ gegl_cache_invalidate (GeglCache           *self,
 
       GeglRegion *temp_region;
       temp_region = gegl_region_rectangle (&expanded);
+
+      g_mutex_lock (&self->mutex);
       for (i = 0; i < GEGL_CACHE_VALID_MIPMAPS; i++)
         gegl_region_subtract (self->valid_region[i], temp_region);
+      g_mutex_unlock (&self->mutex);
       gegl_region_destroy (temp_region);
       g_signal_emit (self, gegl_cache_signals[INVALIDATED], 0,
                      roi, NULL);
@@ -279,16 +281,17 @@ gegl_cache_invalidate (GeglCache           *self,
   else
     {
       GeglRectangle rect = { 0, 0, 0, 0 }; /* should probably be the extent of the cache */
+      g_mutex_lock (&self->mutex);
       for (i = 0; i < GEGL_CACHE_VALID_MIPMAPS; i++)
       {
         if (self->valid_region[i])
           gegl_region_destroy (self->valid_region[i]);
         self->valid_region[i] = gegl_region_new ();
       }
+      g_mutex_unlock (&self->mutex);
       g_signal_emit (self, gegl_cache_signals[INVALIDATED], 0,
                      &rect, NULL);
     }
-  g_mutex_unlock (&self->mutex);
 }
 
 void
@@ -304,8 +307,9 @@ gegl_cache_computed (GeglCache           *self,
   if (level < GEGL_CACHE_VALID_MIPMAPS)
     gegl_region_union_with_rect (self->valid_region[level], rect);
 
-  g_signal_emit (self, gegl_cache_signals[COMPUTED], 0, rect, NULL);
   g_mutex_unlock (&self->mutex);
+
+  g_signal_emit (self, gegl_cache_signals[COMPUTED], 0, rect, NULL);
 }
 
 gboolean