[gnome-builder] buildui: implement the new build panel design
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] buildui: implement the new build panel design
- Date: Wed, 19 Jul 2017 11:08:17 +0000 (UTC)
commit dd47526a3b0fc21d990a6b0239ef7b1e91b69136
Author: Christian Hergert <chergert redhat com>
Date: Tue Jul 4 20:56:03 2017 -0700
buildui: implement the new build panel design
Based upon the mockup at
https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/builder/builder-editor.png
data/themes/Adwaita-shared.css | 8 +-
data/themes/shared.css | 10 +-
libide/buildsystem/ide-build-pipeline.h | 1 +
libide/buildui/ide-build-panel.c | 285 ++++++++++++++++++++++---------
libide/buildui/ide-build-panel.ui | 230 +++++++++----------------
5 files changed, 301 insertions(+), 233 deletions(-)
---
diff --git a/data/themes/Adwaita-shared.css b/data/themes/Adwaita-shared.css
index 408611b..da655cf 100644
--- a/data/themes/Adwaita-shared.css
+++ b/data/themes/Adwaita-shared.css
@@ -50,4 +50,10 @@ popover.messagepopover .popover-content-area {
margin: 24px;
}
-
+/* buildui panel */
+ideeditorsidebar notebook header {
+ background: transparent;
+}
+ideeditorsidebar notebook header tab {
+ padding: 0;
+}
diff --git a/data/themes/shared.css b/data/themes/shared.css
index d32f761..ccf7ca3 100644
--- a/data/themes/shared.css
+++ b/data/themes/shared.css
@@ -364,9 +364,11 @@ popover.transfers list row > box {
padding: 10px;
}
-ideeditorspellwidget {
- background: @theme_bg_color;
+
+ideeditorsidebar label.error {
+ color: @error_color;
+ font-weight: bold;
}
-ideeditorspellwidget:backdrop {
- background: @theme_unfocused_bg_color;
+ideeditorsidebar label.error:backdrop {
+ font-weight: normal;
}
diff --git a/libide/buildsystem/ide-build-pipeline.h b/libide/buildsystem/ide-build-pipeline.h
index b0ce220..5b4b851 100644
--- a/libide/buildsystem/ide-build-pipeline.h
+++ b/libide/buildsystem/ide-build-pipeline.h
@@ -59,6 +59,7 @@ IdeConfiguration *ide_build_pipeline_get_configuration (IdeBuildPipeline
const gchar *ide_build_pipeline_get_builddir (IdeBuildPipeline *self);
const gchar *ide_build_pipeline_get_srcdir (IdeBuildPipeline *self);
gchar *ide_build_pipeline_get_message (IdeBuildPipeline *self);
+IdeBuildPhase ide_build_pipeline_get_phase (IdeBuildPipeline *self);
IdeSubprocessLauncher *ide_build_pipeline_create_launcher (IdeBuildPipeline *self,
GError **error);
gchar *ide_build_pipeline_build_srcdir_path (IdeBuildPipeline *self,
diff --git a/libide/buildui/ide-build-panel.c b/libide/buildui/ide-build-panel.c
index 22ae7d8..9d274df 100644
--- a/libide/buildui/ide-build-panel.c
+++ b/libide/buildui/ide-build-panel.c
@@ -29,17 +29,19 @@ struct _IdeBuildPanel
{
DzlDockWidget parent_instance;
+ /* Owned references */
GHashTable *diags_hash;
IdeBuildPipeline *pipeline;
+ /* Template widgets */
+ GtkLabel *build_status_label;
+ GtkLabel *time_completed_label;
+ GtkNotebook *notebook;
+ GtkScrolledWindow *errors_page;
+ IdeFancyTreeView *errors_tree_view;
+ GtkScrolledWindow *warnings_page;
+ IdeFancyTreeView *warnings_tree_view;
GtkListStore *diagnostics_store;
- GtkTreeView *diagnostics_tree_view;
- GtkLabel *errors_label;
- GtkLabel *running_time_label;
- GtkStack *stack;
- GtkRevealer *status_revealer;
- GtkLabel *status_label;
- GtkLabel *warnings_label;
guint error_count;
guint warning_count;
@@ -49,7 +51,6 @@ G_DEFINE_TYPE (IdeBuildPanel, ide_build_panel, DZL_TYPE_DOCK_WIDGET)
enum {
COLUMN_DIAGNOSTIC,
- COLUMN_TEXT,
LAST_COLUMN
};
@@ -62,6 +63,24 @@ enum {
static GParamSpec *properties [N_PROPS];
static void
+set_warnings_label (IdeBuildPanel *self,
+ const gchar *label)
+{
+ gtk_container_child_set (GTK_CONTAINER (self->notebook), GTK_WIDGET (self->warnings_page),
+ "tab-label", label,
+ NULL);
+}
+
+static void
+set_errors_label (IdeBuildPanel *self,
+ const gchar *label)
+{
+ gtk_container_child_set (GTK_CONTAINER (self->notebook), GTK_WIDGET (self->errors_page),
+ "tab-label", label,
+ NULL);
+}
+
+static void
ide_build_panel_diagnostic (IdeBuildPanel *self,
IdeDiagnostic *diagnostic,
IdeBuildPipeline *pipeline)
@@ -79,66 +98,41 @@ ide_build_panel_diagnostic (IdeBuildPanel *self,
if (severity == IDE_DIAGNOSTIC_WARNING)
{
- g_autofree gchar *str = NULL;
+ g_autofree gchar *label = NULL;
self->warning_count++;
- str = g_strdup_printf (ngettext ("%d warning", "%d warnings", self->warning_count),
self->warning_count);
- gtk_label_set_label (self->warnings_label, str);
+ label = g_strdup_printf ("%s (%u)", _("Warnings"), self->warning_count);
+ set_warnings_label (self, label);
}
else if (severity == IDE_DIAGNOSTIC_ERROR || severity == IDE_DIAGNOSTIC_FATAL)
{
- g_autofree gchar *str = NULL;
+ g_autofree gchar *label = NULL;
self->error_count++;
- str = g_strdup_printf (ngettext ("%d error", "%d errors", self->error_count), self->error_count);
- gtk_label_set_label (self->errors_label, str);
+ label = g_strdup_printf ("%s (%u)", _("Errors"), self->error_count);
+ set_errors_label (self, label);
+ }
+ else
+ {
+ /* TODO: Figure out design for "Others" Column like Notes? */
}
hash = ide_diagnostic_hash (diagnostic);
if (g_hash_table_insert (self->diags_hash, GUINT_TO_POINTER (hash), NULL))
{
- GtkTreeModel *model = GTK_TREE_MODEL (self->diagnostics_store);
GtkTreeIter iter;
- gint left = 0;
- gint right = gtk_tree_model_iter_n_children (model, NULL) - 1;
- gint middle = 0;
- gint cmpval = 1;
- /* Binary search to locate the target position. */
- while (left <= right)
- {
- g_autoptr(IdeDiagnostic) item = NULL;
-
- middle = (left + right) / 2;
-
- gtk_tree_model_iter_nth_child (model, &iter, NULL, middle);
- gtk_tree_model_get (model, &iter,
- COLUMN_DIAGNOSTIC, &item,
- -1);
-
- cmpval = ide_diagnostic_compare (item, diagnostic);
-
- if (cmpval < 0)
- left = middle + 1;
- else if (cmpval > 0)
- right = middle - 1;
- else
- break;
- }
-
- /* If we binary searched and middle was compared previous
- * to our new diagnostic, advance one position.
- */
- if (cmpval < 0)
- middle++;
-
- gtk_list_store_insert (self->diagnostics_store, &iter, middle);
+ dzl_gtk_list_store_insert_sorted (self->diagnostics_store,
+ &iter,
+ diagnostic,
+ COLUMN_DIAGNOSTIC,
+ (GCompareDataFunc)ide_diagnostic_compare,
+ NULL);
gtk_list_store_set (self->diagnostics_store, &iter,
COLUMN_DIAGNOSTIC, diagnostic,
- COLUMN_TEXT, ide_diagnostic_get_text (diagnostic),
-1);
}
@@ -163,9 +157,10 @@ ide_build_panel_update_running_time (IdeBuildPanel *self)
span = ide_build_manager_get_running_time (build_manager);
text = dzl_g_time_span_to_label (span);
+ gtk_label_set_label (self->time_completed_label, text);
}
-
- gtk_label_set_label (self->running_time_label, text);
+ else
+ gtk_label_set_label (self->time_completed_label, "—");
}
static void
@@ -183,8 +178,8 @@ ide_build_panel_started (IdeBuildPanel *self,
self->error_count = 0;
self->warning_count = 0;
- gtk_label_set_label (self->warnings_label, "—");
- gtk_label_set_label (self->errors_label, "—");
+ set_warnings_label (self, _("Warnings"));
+ set_errors_label (self, _("Errors"));
gtk_list_store_clear (self->diagnostics_store);
g_hash_table_remove_all (self->diags_hash);
@@ -205,8 +200,11 @@ ide_build_panel_connect (IdeBuildPanel *self,
self->error_count = 0;
self->warning_count = 0;
- gtk_label_set_label (self->warnings_label, "—");
- gtk_label_set_label (self->errors_label, "—");
+ set_warnings_label (self, _("Warnings"));
+ set_errors_label (self, _("Errors"));
+
+ gtk_label_set_label (self->time_completed_label, "—");
+ gtk_label_set_label (self->build_status_label, "—");
g_signal_connect_object (pipeline,
"diagnostic",
@@ -219,10 +217,6 @@ ide_build_panel_connect (IdeBuildPanel *self,
G_CALLBACK (ide_build_panel_started),
self,
G_CONNECT_SWAPPED);
-
- gtk_revealer_set_reveal_child (self->status_revealer, TRUE);
-
- gtk_stack_set_visible_child_name (self->stack, "diagnostics");
}
static void
@@ -236,11 +230,8 @@ ide_build_panel_disconnect (IdeBuildPanel *self)
self);
g_clear_object (&self->pipeline);
- gtk_revealer_set_reveal_child (self->status_revealer, FALSE);
-
g_hash_table_remove_all (self->diags_hash);
gtk_list_store_clear (self->diagnostics_store);
- gtk_stack_set_visible_child_name (self->stack, "empty-state");
}
void
@@ -321,14 +312,11 @@ ide_build_panel_text_func (GtkCellLayout *layout,
{
IdeCellRendererFancy *fancy = (IdeCellRendererFancy *)renderer;
g_autoptr(IdeDiagnostic) diagnostic = NULL;
- g_auto(GValue) value = { 0 };
gtk_tree_model_get (model, iter,
COLUMN_DIAGNOSTIC, &diagnostic,
-1);
- g_value_init (&value, G_TYPE_STRING);
-
if G_LIKELY (diagnostic != NULL)
{
g_autofree gchar *title = NULL;
@@ -362,11 +350,37 @@ ide_build_panel_text_func (GtkCellLayout *layout,
text = ide_diagnostic_get_text (diagnostic);
ide_cell_renderer_fancy_set_body (fancy, text);
-
- return;
}
+ else
+ {
+ ide_cell_renderer_fancy_set_title (fancy, NULL);
+ ide_cell_renderer_fancy_set_body (fancy, NULL);
+ }
+}
+
+static void
+ide_build_panel_notify_message (IdeBuildPanel *self,
+ GParamSpec *pspec,
+ IdeBuildManager *build_manager)
+{
+ g_autofree gchar *message = NULL;
+ IdeBuildPipeline *pipeline;
+ GtkStyleContext *style;
- g_object_set_property (G_OBJECT (renderer), "text", &value);
+ g_assert (IDE_IS_BUILD_PANEL (self));
+ g_assert (IDE_IS_BUILD_MANAGER (build_manager));
+
+ message = ide_build_manager_get_message (build_manager);
+ pipeline = ide_build_manager_get_pipeline (build_manager);
+
+ gtk_label_set_label (self->build_status_label, message);
+
+ style = gtk_widget_get_style_context (GTK_WIDGET (self->build_status_label));
+
+ if (ide_build_pipeline_get_phase (pipeline) == IDE_BUILD_PHASE_FAILED)
+ gtk_style_context_add_class (style, GTK_STYLE_CLASS_ERROR);
+ else
+ gtk_style_context_remove_class (style, GTK_STYLE_CLASS_ERROR);
}
static void
@@ -386,9 +400,11 @@ ide_build_panel_context_handler (GtkWidget *widget,
build_manager = ide_context_get_build_manager (context);
- g_object_bind_property (build_manager, "message",
- self->status_label, "label",
- G_BINDING_SYNC_CREATE);
+ g_signal_connect_object (build_manager,
+ "notify::message",
+ G_CALLBACK (ide_build_panel_notify_message),
+ self,
+ G_CONNECT_SWAPPED);
g_signal_connect_object (build_manager,
"notify::running-time",
@@ -417,6 +433,78 @@ ide_build_panel_context_handler (GtkWidget *widget,
IDE_EXIT;
}
+static gboolean
+ide_build_panel_diagnostic_tooltip (IdeBuildPanel *self,
+ gint x,
+ gint y,
+ gboolean keyboard_mode,
+ GtkTooltip *tooltip,
+ GtkTreeView *tree_view)
+{
+ GtkTreeModel *model = NULL;
+ GtkTreeIter iter;
+
+ g_assert (IDE_IS_BUILD_PANEL (self));
+ g_assert (GTK_IS_TOOLTIP (tooltip));
+ g_assert (GTK_IS_TREE_VIEW (tree_view));
+
+ if (gtk_tree_view_get_tooltip_context (tree_view, &x, &y, keyboard_mode, &model, NULL, &iter))
+ {
+ g_autoptr(IdeDiagnostic) diag = NULL;
+
+ gtk_tree_model_get (model, &iter,
+ COLUMN_DIAGNOSTIC, &diag,
+ -1);
+
+ if (diag != NULL)
+ {
+ g_autofree gchar *text = ide_diagnostic_get_text_for_display (diag);
+
+ gtk_tooltip_set_text (tooltip, text);
+
+ return TRUE;
+ }
+ }
+
+ return FALSE;
+}
+
+static gboolean
+diagnostic_is_warning (GtkTreeModel *model,
+ GtkTreeIter *iter,
+ gpointer user_data)
+{
+ g_autoptr(IdeDiagnostic) diag = NULL;
+ IdeDiagnosticSeverity severity = 0;
+
+ gtk_tree_model_get (model, iter,
+ COLUMN_DIAGNOSTIC, &diag,
+ -1);
+
+ if (diag != NULL)
+ severity = ide_diagnostic_get_severity (diag);
+
+ return severity <= IDE_DIAGNOSTIC_WARNING;
+}
+
+static gboolean
+diagnostic_is_error (GtkTreeModel *model,
+ GtkTreeIter *iter,
+ gpointer user_data)
+{
+ g_autoptr(IdeDiagnostic) diag = NULL;
+ IdeDiagnosticSeverity severity = 0;
+
+ gtk_tree_model_get (model, iter,
+ COLUMN_DIAGNOSTIC, &diag,
+ -1);
+
+ if (diag != NULL)
+ severity = ide_diagnostic_get_severity (diag);
+
+ return severity > IDE_DIAGNOSTIC_WARNING;
+}
+
static void
ide_build_panel_destroy (GtkWidget *widget)
{
@@ -490,14 +578,14 @@ ide_build_panel_class_init (IdeBuildPanelClass *klass)
gtk_widget_class_set_template_from_resource (widget_class,
"/org/gnome/builder/plugins/buildui/ide-build-panel.ui");
gtk_widget_class_set_css_name (widget_class, "buildpanel");
+ gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, build_status_label);
+ gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, time_completed_label);
+ gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, notebook);
+ gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, errors_page);
+ gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, errors_tree_view);
+ gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, warnings_page);
+ gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, warnings_tree_view);
gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, diagnostics_store);
- gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, diagnostics_tree_view);
- gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, errors_label);
- gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, running_time_label);
- gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, stack);
- gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, status_label);
- gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, status_revealer);
- gtk_widget_class_bind_template_child (widget_class, IdeBuildPanel, warnings_label);
g_type_ensure (IDE_TYPE_CELL_RENDERER_FANCY);
g_type_ensure (IDE_TYPE_DIAGNOSTIC);
@@ -507,20 +595,51 @@ ide_build_panel_class_init (IdeBuildPanelClass *klass)
static void
ide_build_panel_init (IdeBuildPanel *self)
{
+ GtkTreeModel *filter;
+
gtk_widget_init_template (GTK_WIDGET (self));
self->diags_hash = g_hash_table_new (NULL, NULL);
- g_object_set (self, "title", _("Build"), NULL);
+ g_object_set (self, "title", _("Build Issues"), NULL);
ide_widget_set_context_handler (self, ide_build_panel_context_handler);
- g_signal_connect_object (self->diagnostics_tree_view,
+ g_signal_connect_swapped (self->warnings_tree_view,
"row-activated",
G_CALLBACK (ide_build_panel_diagnostic_activated),
- self,
- G_CONNECT_SWAPPED);
+ self);
+
+ g_signal_connect_swapped (self->warnings_tree_view,
+ "query-tooltip",
+ G_CALLBACK (ide_build_panel_diagnostic_tooltip),
+ self);
+
+ g_signal_connect_swapped (self->errors_tree_view,
+ "row-activated",
+ G_CALLBACK (ide_build_panel_diagnostic_activated),
+ self);
+
+ g_signal_connect_swapped (self->errors_tree_view,
+ "query-tooltip",
+ G_CALLBACK (ide_build_panel_diagnostic_tooltip),
+ self);
+
+ filter = gtk_tree_model_filter_new (GTK_TREE_MODEL (self->diagnostics_store), NULL);
+ gtk_tree_model_filter_set_visible_func (GTK_TREE_MODEL_FILTER (filter),
+ diagnostic_is_warning, NULL, NULL);
+ gtk_tree_view_set_model (GTK_TREE_VIEW (self->warnings_tree_view), GTK_TREE_MODEL (filter));
+ g_object_unref (filter);
+
+ filter = gtk_tree_model_filter_new (GTK_TREE_MODEL (self->diagnostics_store), NULL);
+ gtk_tree_model_filter_set_visible_func (GTK_TREE_MODEL_FILTER (filter),
+ diagnostic_is_error, NULL, NULL);
+ gtk_tree_view_set_model (GTK_TREE_VIEW (self->errors_tree_view), GTK_TREE_MODEL (filter));
+ g_object_unref (filter);
+
+ ide_fancy_tree_view_set_data_func (IDE_FANCY_TREE_VIEW (self->warnings_tree_view),
+ ide_build_panel_text_func, self, NULL);
- ide_fancy_tree_view_set_data_func (IDE_FANCY_TREE_VIEW (self->diagnostics_tree_view),
+ ide_fancy_tree_view_set_data_func (IDE_FANCY_TREE_VIEW (self->errors_tree_view),
ide_build_panel_text_func, self, NULL);
}
diff --git a/libide/buildui/ide-build-panel.ui b/libide/buildui/ide-build-panel.ui
index 156cc40..706097e 100644
--- a/libide/buildui/ide-build-panel.ui
+++ b/libide/buildui/ide-build-panel.ui
@@ -1,177 +1,118 @@
<interface>
<template class="IdeBuildPanel" parent="DzlDockWidget">
<child>
- <object class="GtkBox" id="toplevel">
- <property name="visible">true</property>
+ <object class="GtkBox">
<property name="orientation">vertical</property>
+ <property name="spacing">12</property>
+ <property name="visible">true</property>
<child>
- <object class="GtkRevealer" id="status_revealer">
- <property name="transition-type">slide-down</property>
+ <object class="GtkGrid">
+ <property name="margin">6</property>
+ <property name="column-spacing">6</property>
+ <property name="row-spacing">6</property>
+ <property name="expand">false</property>
<property name="visible">true</property>
<child>
- <object class="GtkBox">
- <property name="orientation">vertical</property>
+ <object class="GtkLabel">
+ <property name="label" translatable="yes">Build status:</property>
<property name="visible">true</property>
+ <property name="xalign">1.0</property>
<style>
- <class name="build-status"/>
+ <class name="dim-label"/>
</style>
- <child>
- <object class="GtkSeparator">
- <property name="orientation">horizontal</property>
- <property name="visible">true</property>
- </object>
- </child>
- <child>
- <object class="GtkGrid">
- <property name="border-width">12</property>
- <property name="column-spacing">12</property>
- <property name="column-homogeneous">true</property>
- <property name="row-spacing">3</property>
- <property name="visible">true</property>
- <child>
- <object class="GtkLabel" id="label4">
- <property name="label" translatable="yes">Status:</property>
- <property name="xalign">1.0</property>
- <property name="visible">true</property>
- <style>
- <class name="dim-label"/>
- </style>
- </object>
- <packing>
- <property name="left-attach">0</property>
- <property name="top-attach">0</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="status_label">
- <property name="ellipsize">end</property>
- <property name="visible">true</property>
- <property name="xalign">0.0</property>
- </object>
- <packing>
- <property name="left-attach">1</property>
- <property name="top-attach">0</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="label5">
- <property name="label" translatable="yes">Running Time:</property>
- <property name="xalign">1.0</property>
- <property name="visible">true</property>
- <style>
- <class name="dim-label"/>
- </style>
- </object>
- <packing>
- <property name="left-attach">0</property>
- <property name="top-attach">1</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="running_time_label">
- <property name="xalign">0.0</property>
- <property name="visible">true</property>
- </object>
- <packing>
- <property name="left-attach">1</property>
- <property name="top-attach">1</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="label6">
- <property name="label" translatable="yes">Warnings:</property>
- <property name="xalign">1.0</property>
- <property name="visible">true</property>
- <style>
- <class name="dim-label"/>
- </style>
- </object>
- <packing>
- <property name="left-attach">0</property>
- <property name="top-attach">2</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="warnings_label">
- <property name="xalign">0.0</property>
- <property name="visible">true</property>
- </object>
- <packing>
- <property name="left-attach">1</property>
- <property name="top-attach">2</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel">
- <property name="label" translatable="yes">Errors:</property>
- <property name="xalign">1.0</property>
- <property name="visible">true</property>
- <style>
- <class name="dim-label"/>
- </style>
- </object>
- <packing>
- <property name="left-attach">0</property>
- <property name="top-attach">3</property>
- </packing>
- </child>
- <child>
- <object class="GtkLabel" id="errors_label">
- <property name="xalign">0.0</property>
- <property name="visible">true</property>
- </object>
- <packing>
- <property name="left-attach">1</property>
- <property name="top-attach">3</property>
- </packing>
- </child>
- </object>
- </child>
- <child>
- <object class="GtkSeparator">
- <property name="orientation">horizontal</property>
- <property name="visible">true</property>
- </object>
- </child>
+ <attributes>
+ <attribute name="scale" value="0.8333"/>
+ </attributes>
+ </object>
+ <packing>
+ <property name="top-attach">0</property>
+ <property name="left-attach">0</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel">
+ <property name="label" translatable="yes">Time completed:</property>
+ <property name="visible">true</property>
+ <property name="xalign">1.0</property>
+ <style>
+ <class name="dim-label"/>
+ </style>
+ <attributes>
+ <attribute name="scale" value="0.8333"/>
+ </attributes>
+ </object>
+ <packing>
+ <property name="top-attach">1</property>
+ <property name="left-attach">0</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel" id="build_status_label">
+ <property name="label" translatable="yes">—</property>
+ <property name="hexpand">true</property>
+ <property name="visible">true</property>
+ <property name="xalign">0.0</property>
+ <attributes>
+ <attribute name="scale" value="0.8333"/>
+ </attributes>
+ </object>
+ <packing>
+ <property name="top-attach">0</property>
+ <property name="left-attach">1</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkLabel" id="time_completed_label">
+ <property name="label" translatable="yes">—</property>
+ <property name="hexpand">true</property>
+ <property name="visible">true</property>
+ <property name="xalign">0.0</property>
+ <attributes>
+ <attribute name="scale" value="0.8333"/>
+ </attributes>
</object>
+ <packing>
+ <property name="top-attach">1</property>
+ <property name="left-attach">1</property>
+ </packing>
</child>
</object>
</child>
<child>
- <object class="GtkStack" id="stack">
+ <object class="GtkNotebook" id="notebook">
+ <property name="show-border">false</property>
+ <property name="vexpand">true</property>
<property name="visible">true</property>
<child>
- <object class="DzlEmptyState">
- <property name="border-width">12</property>
- <property name="icon-name">builder-build-symbolic</property>
- <property name="margin-top">12</property>
- <property name="pixel-size">64</property>
- <property name="title" translatable="yes">No Diagnostics</property>
- <property name="subtitle" translatable="yes" comments="the action:// link is used to execute
a build"><a href="action://build-manager.build">Build your project</a> to show diagnostics
here</property>
- <property name="valign">start</property>
+ <object class="GtkScrolledWindow" id="warnings_page">
<property name="visible">true</property>
+ <child>
+ <object class="IdeFancyTreeView" id="warnings_tree_view">
+ <property name="has-tooltip">true</property>
+ <property name="visible">true</property>
+ </object>
+ </child>
</object>
<packing>
- <property name="name">empty-state</property>
+ <property name="position">0</property>
+ <property name="tab-label" translatable="yes">Warnings</property>
+ <property name="tab-expand">true</property>
</packing>
</child>
<child>
- <object class="GtkScrolledWindow">
- <property name="hscrollbar-policy">never</property>
- <property name="vexpand">true</property>
+ <object class="GtkScrolledWindow" id="errors_page">
<property name="visible">true</property>
<child>
- <object class="IdeFancyTreeView" id="diagnostics_tree_view">
- <property name="activate-on-single-click">true</property>
- <property name="tooltip-column">1</property>
- <property name="model">diagnostics_store</property>
- <property name="headers-visible">false</property>
+ <object class="IdeFancyTreeView" id="errors_tree_view">
+ <property name="has-tooltip">true</property>
<property name="visible">true</property>
</object>
</child>
</object>
<packing>
- <property name="name">diagnostics</property>
+ <property name="position">1</property>
+ <property name="tab-label" translatable="yes">Errors</property>
+ <property name="tab-expand">true</property>
</packing>
</child>
</object>
@@ -182,7 +123,6 @@
<object class="GtkListStore" id="diagnostics_store">
<columns>
<column type="IdeDiagnostic"/>
- <column type="gchararray"/>
</columns>
</object>
</interface>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
