[gnome-builder/wip/chergert/layout] color-picker: keep usage within condition branch



commit bb3d718fb7fd52dd778b7289176d867096a868f7
Author: Christian Hergert <chergert redhat com>
Date:   Tue Jul 18 20:24:38 2017 -0700

    color-picker: keep usage within condition branch
    
    This can only ever be non-NULL inside the branch.

 .../color-picker/gb-color-picker-editor-addin.c    |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)
---
diff --git a/plugins/color-picker/gb-color-picker-editor-addin.c 
b/plugins/color-picker/gb-color-picker-editor-addin.c
index 4da0dce..180e15c 100644
--- a/plugins/color-picker/gb-color-picker-editor-addin.c
+++ b/plugins/color-picker/gb-color-picker-editor-addin.c
@@ -186,7 +186,6 @@ gb_color_picker_editor_addin_notify_rgba (GbColorPickerEditorAddin *self,
                                           GstyleColorPanel         *panel)
 {
   g_autoptr(GstyleColor) color = NULL;
-  GbColorPickerEditorViewAddin *view_addin = NULL;
   GdkRGBA rgba;
 
   g_assert (GB_IS_COLOR_PICKER_EDITOR_ADDIN (self));
@@ -197,10 +196,14 @@ gb_color_picker_editor_addin_notify_rgba (GbColorPickerEditorAddin *self,
   color = gstyle_color_new_from_rgba (NULL, GSTYLE_COLOR_KIND_RGB_HEX6, &rgba);
 
   if (self->view_addin_signals != NULL)
-    view_addin = dzl_signal_group_get_target (self->view_addin_signals);
+    {
+      GbColorPickerEditorViewAddin *view_addin;
+
+      view_addin = dzl_signal_group_get_target (self->view_addin_signals);
 
-  if (GB_IS_COLOR_PICKER_EDITOR_VIEW_ADDIN (view_addin))
-    gb_color_picker_editor_view_addin_set_color (view_addin, color);
+      if (GB_IS_COLOR_PICKER_EDITOR_VIEW_ADDIN (view_addin))
+        gb_color_picker_editor_view_addin_set_color (view_addin, color);
+    }
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]