[balsa] Avoid some whining from the clang static analyzer



commit 1b70afc7ee8e63e6286e025acc1da63d94cde895
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Mon Jul 17 10:41:43 2017 -0400

    Avoid some whining from the clang static analyzer
    
        * libbalsa/libbalsa-gpgme-keys.c (gpgme_import_key):
        value stored to 'gpgme_err' is never read.
        * libbalsa/libbalsa-gpgme-widgets.c (create_subkey_widget):
        value stored to 'subkey_row' is never read.

 ChangeLog                         |    9 +++++++++
 libbalsa/libbalsa-gpgme-keys.c    |    3 ++-
 libbalsa/libbalsa-gpgme-widgets.c |    3 ++-
 3 files changed, 13 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index fb1425c..b4fcb08 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,14 @@
 2017-07-17  Peter Bloomfield  <pbloomfield bellsouth net>
 
+       Avoid some whining from the clang static analyzer
+
+       * libbalsa/libbalsa-gpgme-keys.c (gpgme_import_key):
+       value stored to 'gpgme_err' is never read.
+       * libbalsa/libbalsa-gpgme-widgets.c (create_subkey_widget):
+       value stored to 'subkey_row' is never read.
+
+2017-07-17  Peter Bloomfield  <pbloomfield bellsouth net>
+
        * src/balsa-mime-widget-message.c (foreach_label): the only
        children that have a "populate-popup" signal are GtkLabels.
 
diff --git a/libbalsa/libbalsa-gpgme-keys.c b/libbalsa/libbalsa-gpgme-keys.c
index a20744a..f9f5050 100644
--- a/libbalsa/libbalsa-gpgme-keys.c
+++ b/libbalsa/libbalsa-gpgme-keys.c
@@ -375,7 +375,8 @@ gpgme_import_key(gpgme_ctx_t   ctx,
                                kl_mode |= GPGME_KEYLIST_MODE_LOCAL;
                                gpgme_err = gpgme_set_keylist_mode(ctx, kl_mode);
                                if (gpgme_err == GPG_ERR_NO_ERROR) {
-                                       gpgme_err = gpgme_get_key(ctx, key->subkeys->fpr, imported_key, 0);
+                                       /* gpgme_err = gpgme_get_key(ctx, key->subkeys->fpr, imported_key, 
0); */
+                                       (void) gpgme_get_key(ctx, key->subkeys->fpr, imported_key, 0);
                                }
                        }
                }
diff --git a/libbalsa/libbalsa-gpgme-widgets.c b/libbalsa/libbalsa-gpgme-widgets.c
index 6783e78..38d779e 100644
--- a/libbalsa/libbalsa-gpgme-widgets.c
+++ b/libbalsa/libbalsa-gpgme-widgets.c
@@ -468,7 +468,8 @@ create_subkey_widget(gpgme_subkey_t subkey)
        } else {
                timebuf = libbalsa_date_to_utf8(subkey->expires, "%x %X");
        }
-       subkey_row = create_key_grid_row(GTK_GRID(subkey_grid), subkey_row, _("Expires:"), timebuf, FALSE);
+       /* subkey_row = create_key_grid_row(GTK_GRID(subkey_grid), subkey_row, _("Expires:"), timebuf, 
FALSE); */
+       (void) create_key_grid_row(GTK_GRID(subkey_grid), subkey_row, _("Expires:"), timebuf, FALSE);
        g_free(timebuf);
 
        return subkey_grid;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]