[tracker] libtracker-data: Make all other ifaces than wal/writable readonly



commit 15083ead11377f1b34ffb38569e737c3cd12c0bd
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sun Jul 9 21:30:43 2017 +0200

    libtracker-data: Make all other ifaces than wal/writable readonly
    
    The interfaces returned by tracker_data_manager_get_db_interface()
    are now ensured to be only used in select queries, so be bolder
    about this and ensure the interfaces are actually readonly.

 src/libtracker-data/tracker-db-manager.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/src/libtracker-data/tracker-db-manager.c b/src/libtracker-data/tracker-db-manager.c
index b157e76..2e55ea2 100644
--- a/src/libtracker-data/tracker-db-manager.c
+++ b/src/libtracker-data/tracker-db-manager.c
@@ -876,8 +876,7 @@ tracker_db_manager_new (TrackerDBManagerFlags   flags,
        }
 
        resources_iface = tracker_db_manager_create_db_interface (db_manager,
-                                                                 (flags & TRACKER_DB_MANAGER_READONLY) != 0,
-                                                                 &internal_error);
+                                                                 TRUE, &internal_error);
 
        if (internal_error) {
                if ((!restoring_backup) && (flags & TRACKER_DB_MANAGER_READONLY) == 0) {
@@ -885,7 +884,7 @@ tracker_db_manager_new (TrackerDBManagerFlags   flags,
 
                        perform_recreate (db_manager, first_time, &new_error);
                        if (!new_error) {
-                               resources_iface = tracker_db_manager_create_db_interface (db_manager, FALSE,
+                               resources_iface = tracker_db_manager_create_db_interface (db_manager, TRUE,
                                                                                          &internal_error);
                        } else {
                                /* Most serious error is the recreate one here */
@@ -1034,8 +1033,7 @@ tracker_db_manager_get_db_interface (TrackerDBManager *db_manager)
 
                flags = tracker_db_manager_get_flags (db_manager, NULL, NULL);
                interface = tracker_db_manager_create_db_interface (db_manager,
-                                                                   (flags & TRACKER_DB_MANAGER_READONLY) != 
0,
-                                                                   &internal_error);
+                                                                   TRUE, &internal_error);
 
                if (internal_error) {
                        g_critical ("Error opening database: %s", internal_error->message);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]