[recipes/todoist] Fix some warnings and some ui tweaks in dialog



commit b8eb74b69b0edc322a7ad70d312e214cb305c2dd
Author: Ekta Nandwani <mailnandwaniekta gmail com>
Date:   Sun Jul 9 10:26:15 2017 +0530

    Fix some warnings and some ui tweaks in dialog

 src/gr-ingredients-exporter.c      |    5 +--
 src/ingredients-exporter-dialog.ui |   62 +++++++++--------------------------
 2 files changed, 18 insertions(+), 49 deletions(-)
---
diff --git a/src/gr-ingredients-exporter.c b/src/gr-ingredients-exporter.c
index 0907c4d..15bdb7f 100644
--- a/src/gr-ingredients-exporter.c
+++ b/src/gr-ingredients-exporter.c
@@ -1,5 +1,6 @@
 /* gr-ingredients-exporter.c:
  *
+ * Copyright (C) 2017 Ekta Nandwani
  *
  * Licensed under the GNU General Public License Version 3
  *
@@ -57,8 +58,6 @@ static void
 gr_ingredients_exporter_class_init (GrIngredientsExporterClass *klass)
 {
         GObjectClass *object_class = G_OBJECT_CLASS (klass);
-        GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (klass);
-
 
         object_class->finalize = gr_ingredients_exporter_finalize;
 }
@@ -115,7 +114,7 @@ show_export_dialog (GrIngredientsExporter *exporter)
         exporter->providers_box = GTK_WIDGET (gtk_builder_get_object (builder, "providers_box"));
         exporter->dialog_stack = GTK_WIDGET (gtk_builder_get_object (builder, "dialog_stack"));
         exporter->header_start_stack = GTK_WIDGET (gtk_builder_get_object (builder, "header_start_stack"));
-        exporter->header =  gtk_builder_get_object (builder, "header");
+        exporter->header =  GTK_WIDGET (gtk_builder_get_object (builder, "header"));
 
         g_signal_connect (add_service, "activate-link", G_CALLBACK (switch_dialog_contents), exporter);
         
diff --git a/src/ingredients-exporter-dialog.ui b/src/ingredients-exporter-dialog.ui
index beb1bd4..e0b6f41 100644
--- a/src/ingredients-exporter-dialog.ui
+++ b/src/ingredients-exporter-dialog.ui
@@ -27,6 +27,7 @@
             <child>
               <object class="GtkButton" id="back_button">
                 <property name="visible">1</property>
+                <property name="halign">start</property>
                 <signal name="clicked" handler="go_back" swapped="yes"/>
                 <style>
                   <class name="image-button"/>
@@ -47,36 +48,6 @@
         </child>
       </object>
     </child>
-<!--     <child type="title">
-          <object class="GtkStack" id="header_title_stack">
-            <property name="visible">1</property>
-            <property name="hhomogeneous">0</property>
-            <child>
-              <object class="GtkLabel">
-                <property name="visible">1</property>
-                <property name="label">Export Ingredeints</property>
-                <attributes>
-                  <attribute name="weight" value="bold"/>
-                </attributes>
-              </object>
-              <packing>
-                <property name="name">export</property>
-              </packing>
-            </child>
-            <child>
-              <object class="GtkLabel">
-                <property name="visible">1</property>
-                <property name="label">Add Service</property>
-                <attributes>
-                  <attribute name="weight" value="bold"/>
-                </attributes>
-              </object>
-              <packing>
-                <property name="name">add</property>
-              </packing>
-            </child>
-          </object>
-        </child> -->
     <child type="action">
               <object class="GtkButton" id="export_button">
                 <property name="visible">1</property>
@@ -100,16 +71,19 @@
               <object class="GtkListBox" id="accounts_list">
                 <property name="visible">1</property>
                 <property name="selection_mode">none</property>
+                <style>
+                      <class name="frame"/>
+                </style>
                 <child>
                   <object class="GtkListBoxRow">
                     <property name="visible">1</property>
-                    <property name="can_focus">True</property>
+                    <property name="can_focus">1</property>
                     <child>
                       <object class="GtkGrid">
                         <property name="visible">1</property>
                         <property name="border_width">6</property>
                         <property name="margin_end">18</property>
-                      <!--   <property name="column_spacing">12</property> -->
+                        <property name="column_spacing">12</property>
                         <child>
                           <object class="GtkImage">
                             <property name="visible">1</property>
@@ -119,7 +93,6 @@
                           <packing>
                             <property name="left_attach">0</property>
                             <property name="top_attach">0</property>
-                            <property name="height">2</property>
                           </packing>
                         </child>
                         <child>
@@ -140,7 +113,7 @@
                 <child>
                   <object class="GtkListBoxRow" id="todoist_account_row">
                     <!-- <property name="visible">1</property> -->
-                    <property name="can_focus">True</property>
+                    <property name="can_focus">1</property>
                     <child>
                       <object class="GtkGrid">
                         <property name="visible">1</property>
@@ -156,7 +129,6 @@
                           <packing>
                             <property name="left_attach">0</property>
                             <property name="top_attach">0</property>
-                            <property name="height">2</property>
                           </packing>
                         </child>
                         <child>
@@ -180,7 +152,7 @@
               <object class="GtkLabel" id="add_service">
                 <property name="label">&lt;a href=&quot;&quot;&gt;Add service&lt;/a&gt;</property>
                  <property name="visible">1</property>
-                 <property name="use_markup">True</property>
+                 <property name="use_markup">1</property>
                  <property name="use_underline">0</property>
               </object>
             </child>
@@ -188,7 +160,7 @@
         </child>
         <child>
           <object class="GtkBox" id="providers_box">
-                        <property name="margin">20</property>
+            <property name="margin">20</property>
             <property name="spacing">20</property>
             <property name="visible">1</property>
             <property name="orientation">vertical</property>
@@ -196,10 +168,13 @@
               <object class="GtkListBox" id="providers_list">
                 <property name="selection_mode">none</property>
                 <property name="visible">1</property>
+                <style>
+                      <class name="frame"/>
+                </style>
                 <child>
                   <object class="GtkListBoxRow" id="todoist_provider_row">
                     <property name="visible">1</property>
-                    <property name="can_focus">True</property>
+                    <property name="can_focus">1</property>
                     <child>
                       <object class="GtkGrid" >
                         <property name="visible">1</property>
@@ -215,7 +190,6 @@
                           <packing>
                             <property name="left_attach">0</property>
                             <property name="top_attach">0</property>
-                            <property name="height">2</property>
                           </packing>
                         </child>
                         <child>
@@ -236,17 +210,13 @@
             </object>
           </child>
         </object>
-                    <packing>
-                <property name="name">providers_box</property>
-            </packing >
+        <packing>
+          <property name="name">providers_box</property>
+        </packing >
       </child>
     </object>
   </child>
 </object>
 </child>
-<!--     <action-widgets>
-      <action-widget response="cancel">button_later</action-widget>
-      <action-widget response="ok">button_now</action-widget>
-    </action-widgets> -->
   </object>
 </interface>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]