[rhythmbox] remove visualizer plugin



commit 6fcb68f257872ab1cd635ee5774533ed2cf95e79
Author: Jonathan Matthew <jonathan d14n org>
Date:   Mon Jul 3 18:58:36 2017 +1000

    remove visualizer plugin
    
    The current implementation is a dead end and I don't have the time
    or interest to rewrite it again.

 .gitignore                                    |    1 -
 INSTALL.quick                                 |    2 -
 configure.ac                                  |   35 --
 data/org.gnome.rhythmbox.gschema.xml          |   18 -
 doc/reference/Makefile.am                     |    3 -
 plugins/Makefile.am                           |    4 -
 plugins/visualizer/Makefile.am                |   79 ---
 plugins/visualizer/button-active.png          |  Bin 569 -> 0 bytes
 plugins/visualizer/button-disabled.png        |  Bin 569 -> 0 bytes
 plugins/visualizer/button-focus.png           |  Bin 701 -> 0 bytes
 plugins/visualizer/button-hover.png           |  Bin 605 -> 0 bytes
 plugins/visualizer/button.png                 |  Bin 605 -> 0 bytes
 plugins/visualizer/rb-visualizer-fullscreen.c |  649 -------------------------
 plugins/visualizer/rb-visualizer-fullscreen.h |   45 --
 plugins/visualizer/rb-visualizer-menu.c       |  128 -----
 plugins/visualizer/rb-visualizer-menu.h       |   54 --
 plugins/visualizer/rb-visualizer-page.c       |  453 -----------------
 plugins/visualizer/rb-visualizer-page.h       |   83 ----
 plugins/visualizer/rb-visualizer-plugin.c     |  479 ------------------
 plugins/visualizer/visualizer-box.png         |  Bin 330 -> 0 bytes
 plugins/visualizer/visualizer.css             |   56 ---
 plugins/visualizer/visualizer.plugin.in       |    8 -
 po/POTFILES.in                                |    5 -
 23 files changed, 0 insertions(+), 2102 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 5f11d7a..700b9d8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -70,7 +70,6 @@ metadata/test-metadata
 plugins/audiocd/sj-metadata-marshal.c
 plugins/audiocd/sj-metadata-marshal.h
 plugins/daap/rb-daap-glue.h
-plugins/visualizer/rb-visualizer-glue.h
 
 #
 sample-plugins/sample-vala/rb-sample-vala-plugin.c
diff --git a/INSTALL.quick b/INSTALL.quick
index e032cee..155959f 100644
--- a/INSTALL.quick
+++ b/INSTALL.quick
@@ -23,8 +23,6 @@ Rhythmbox can also make use of the following packages:
 - libdmapsharing 2.9.11 or newer
 - libmtp 0.3.0 or newer
 - grilo 0.3.0 or newer
-- clutter 1.8, clutter-gst 1.4, clutter-gtk 1.0 and mx 1.0.1 or newer
-  for music visualization
 
 
 Simple install procedure
diff --git a/configure.ac b/configure.ac
index e29d1cf..67567d4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -515,8 +515,6 @@ AC_DEFINE(GLIB_VERSION_MIN_REQUIRED, GLIB_VERSION_2_38, [minimum glib version])
 AC_DEFINE(GLIB_VERSION_MAX_ALLOWED, GLIB_VERSION_2_38, [maximum glib version])
 AC_DEFINE(GDK_VERSION_MIN_REQUIRED, GDK_VERSION_3_16, [minimum gdk version])
 AC_DEFINE(GDK_VERSION_MAX_ALLOWED, GDK_VERSION_3_16, [maximum gdk version])
-AC_DEFINE(CLUTTER_VERSION_MIN_REQUIRED, CLUTTER_VERSION_1_8, [minimum clutter version])
-AC_DEFINE(CLUTTER_VERSION_MAX_ALLOWED, CLUTTER_VERSION_1_8, [maximum clutter version])
 
 dnl Check for -fno-strict-aliasing
 FLAGS="-fno-strict-aliasing"
@@ -670,32 +668,6 @@ AC_SUBST(DMAPSHARING_CFLAGS)
 AC_SUBST(DMAPSHARING_LIBS)
 
 dnl ================================================================
-dnl clutter for visualizer plugin
-dnl ================================================================
-AC_ARG_ENABLE(visualizer,
-              AC_HELP_STRING([--disable-visualizer],
-                             [Disable visualizer plugin support]),,
-              enable_visualizer=auto)
-if test "x$enable_visualizer" != "xno"; then
-       PKG_CHECK_MODULES(CLUTTER,
-                         clutter-1.0 >= 1.8                    \
-                         clutter-x11-1.0 >= 1.8                \
-                         clutter-gst-2.0                               \
-                         clutter-gtk-1.0 >= 1.0                \
-                         mx-1.0 >= 1.0.1,
-                         have_clutter=yes,
-                         have_clutter=no)
-       if test "x$have_clutter" = "xno" -a "x$enable_visualizer" = "xyes"; then
-               AC_MSG_ERROR([Visualizer support explicitly requested, but clutter couldn't be found])
-       fi
-fi
-
-AM_CONDITIONAL(USE_CLUTTER, test x"$have_clutter" = "xyes")
-
-AC_SUBST(CLUTTER_CFLAGS)
-AC_SUBST(CLUTTER_LIBS)
-
-dnl ================================================================
 dnl grilo plugin
 dnl ================================================================
 AC_ARG_ENABLE(grilo,
@@ -783,7 +755,6 @@ plugins/mpris/Makefile
 plugins/dbus-media-server/Makefile
 plugins/rbzeitgeist/Makefile
 plugins/notification/Makefile
-plugins/visualizer/Makefile
 plugins/grilo/Makefile
 plugins/soundcloud/Makefile
 plugins/webremote/Makefile
@@ -881,10 +852,4 @@ else
        AC_MSG_NOTICE([   iTunes detection browser plugin (for podcasts) disabled])
 fi
 
-if test "x$have_clutter" = xyes; then
-       AC_MSG_NOTICE([** Visualizer plugin enabled])
-else
-       AC_MSG_NOTICE([   Visualizer plugin disabled])
-fi
-
 AC_MSG_NOTICE([End options])
diff --git a/data/org.gnome.rhythmbox.gschema.xml b/data/org.gnome.rhythmbox.gschema.xml
index d5dbb9f..95685a7 100644
--- a/data/org.gnome.rhythmbox.gschema.xml
+++ b/data/org.gnome.rhythmbox.gschema.xml
@@ -415,24 +415,6 @@
     </key>
   </schema>
 
-  <enum id="org.gnome.rhythmbox.plugins.visualizer.quality">
-    <value nick="low" value="0"/>
-    <value nick="medium" value="1"/>
-    <value nick="high" value="2"/>
-  </enum>
-  <schema id="org.gnome.rhythmbox.plugins.visualizer" path="/org/gnome/rhythmbox/plugins/visualizer/">
-    <key name="vis-plugin" type="s">
-      <default>'goom'</default>
-      <summary>GStreamer element to use for visual effects</summary>
-      <description>The name of the GStreamer element to use for visual effects.</description>
-    </key>
-    <key name="vis-quality" enum="org.gnome.rhythmbox.plugins.visualizer.quality">
-      <default>'medium'</default>
-      <summary>The frame rate and size to use for visual effects</summary>
-      <description>The frame rate and size to use for visual effects</description>
-    </key>
-  </schema>
-
   <schema id="org.gnome.rhythmbox.plugins.grilo" path="/org/gnome/rhythmbox/plugins/grilo/">
     <child name="source" schema="org.gnome.rhythmbox.source"/>
   </schema>
diff --git a/doc/reference/Makefile.am b/doc/reference/Makefile.am
index 933c562..28678e5 100644
--- a/doc/reference/Makefile.am
+++ b/doc/reference/Makefile.am
@@ -138,9 +138,6 @@ IGNORE_HFILES= \
        rb-rhythmdb-dmap-db-adapter.h \
        rb-rhythmdb-query-model-dmap-db-adapter.h \
        rb-station-properties-dialog.h \
-       rb-visualizer-fullscreen.h \
-       rb-visualizer-menu.h \
-       rb-visualizer-page.h \
        sj-metadata-marshal.h \
        \
        test-utils.h
diff --git a/plugins/Makefile.am b/plugins/Makefile.am
index efdb1c5..fa83a4d 100644
--- a/plugins/Makefile.am
+++ b/plugins/Makefile.am
@@ -53,10 +53,6 @@ if ENABLE_FM_RADIO
 SUBDIRS += fmradio
 endif
 
-if USE_CLUTTER
-SUBDIRS += visualizer
-endif
-
 if USE_NOTIFY
 SUBDIRS += notification
 endif
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 9e24b8e..66afe2e 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -160,11 +160,6 @@ plugins/sendto/sendto.py
 [type: gettext/ini]plugins/soundcloud/soundcloud.plugin.in
 plugins/soundcloud/soundcloud.py
 [type: gettext/glade]plugins/soundcloud/soundcloud.ui
-plugins/visualizer/rb-visualizer-fullscreen.c
-plugins/visualizer/rb-visualizer-menu.c
-plugins/visualizer/rb-visualizer-page.c
-plugins/visualizer/rb-visualizer-plugin.c
-[type: gettext/ini]plugins/visualizer/visualizer.plugin.in
 [type: gettext/glade]plugins/webremote/webremote-config.ui
 [type: gettext/ini]plugins/webremote/webremote.plugin.in
 plugins/webremote/webremote.py


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]