[tracker] Delete tracker-needle

From: Carlos Garnacho <carlosg src gnome org>
To: commits-list gnome org
Cc:
Subject: [tracker] Delete tracker-needle
Date: Mon, 3 Jul 2017 13:23:03 +0000 (UTC)
commit e479e5f393e4b7292ab4ac8088ec22e4ed30aa3c
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sun Jul 2 16:57:25 2017 +0200

    Delete tracker-needle
    
    It was cool when Tracker search was barely integrated anywhere.
    Nowadays, it's nothing but an aging showcase app (eg. was conceived
    in the gtk2 days and barely ported to gtk3, and it shows everywhere).
    
    If you want a modern and capable search UI, try Nautilus. If you
    are outraged that tracker-needle is gone and ended up here, by all
    means be my guest, reset to the parent of this commit and take it
    out of tree. If you join #tracker I'll gladly give you advise on
    how could it be brought up-to-date. But our hands are full, sorry,
    we leave cool UIs to others.

 configure.ac                                       |   51 -
 docs/manpages/Makefile.am                          |    5 -
 po/POTFILES.in                                     |    9 -
 src/Makefile.am                                    |    4 -
 src/meson.build                                    |    3 -
 src/tracker-needle/.gitignore                      |    6 -
 src/tracker-needle/Makefile.am                     |   80 --
 src/tracker-needle/config.vapi                     |   31 -
 src/tracker-needle/icons/16x16/Makefile.am         |    8 -
 src/tracker-needle/icons/16x16/tracker.png         |  Bin 997 -> 0 bytes
 src/tracker-needle/icons/22x22/Makefile.am         |    8 -
 src/tracker-needle/icons/22x22/tracker.png         |  Bin 1334 -> 0 bytes
 src/tracker-needle/icons/24x24/Makefile.am         |    8 -
 src/tracker-needle/icons/24x24/tracker.png         |  Bin 1484 -> 0 bytes
 src/tracker-needle/icons/32x32/Makefile.am         |    8 -
 src/tracker-needle/icons/32x32/tracker.png         |  Bin 2242 -> 0 bytes
 src/tracker-needle/icons/48x48/Makefile.am         |    8 -
 src/tracker-needle/icons/48x48/tracker.png         |  Bin 4145 -> 0 bytes
 src/tracker-needle/icons/Makefile.am               |   14 -
 src/tracker-needle/icons/scalable/Makefile.am      |   11 -
 src/tracker-needle/icons/scalable/tracker.svg      | 1347 --------------------
 src/tracker-needle/meson.build                     |   46 -
 .../org.freedesktop.Tracker.Needle.gschema.xml.in  |   19 -
 src/tracker-needle/tracker-history.vala            |   93 --
 src/tracker-needle/tracker-needle.appdata.xml      |   24 -
 src/tracker-needle/tracker-needle.desktop.in.in    |   14 -
 src/tracker-needle/tracker-needle.ui               |  469 -------
 src/tracker-needle/tracker-needle.vala             |  858 -------------
 src/tracker-needle/tracker-query.vala              |  410 ------
 src/tracker-needle/tracker-result-store.vala       |  890 -------------
 src/tracker-needle/tracker-stats.vala              |  191 ---
 src/tracker-needle/tracker-tags-view.vala          |  834 ------------
 src/tracker-needle/tracker-utils.vala              |  238 ----
 src/tracker-needle/tracker-view.vala               |  561 --------
 34 files changed, 0 insertions(+), 6248 deletions(-)
---
diff --git a/configure.ac b/configure.ac
index d50b2ed..6ff4eaf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -405,16 +405,6 @@ PKG_CHECK_MODULES(TRACKER_MINER_RSS, [$TRACKER_MINER_RSS_REQUIRED],
                   [have_tracker_miner_rss=yes],
                   [have_tracker_miner_rss=no])
 
-# Check requirements for tracker-needle
-TRACKER_NEEDLE_REQUIRED="glib-2.0     >= $GLIB_REQUIRED
-                         gio-unix-2.0 >= $GLIB_REQUIRED
-                         gmodule-2.0  >= $GLIB_REQUIRED
-                         gtk+-3.0     >= $GTK_REQUIRED"
-
-PKG_CHECK_MODULES(TRACKER_NEEDLE, [$TRACKER_NEEDLE_REQUIRED],
-                  [have_tracker_needle=yes],
-                  [have_tracker_needle=no])
-
 # Check we have Vala valac command we need
 VALA_MIN_VERSION=0.18.0
 AM_PROG_VALAC([$VALA_MIN_VERSION])
@@ -507,7 +497,6 @@ if test "x$enable_minimal" = "xyes"; then
    enable_miner_fs=no
    enable_miner_apps=no
    enable_miner_rss=no
-   enable_tracker_needle=no
 fi
 
 ####################################################################
@@ -1232,34 +1221,6 @@ fi
 AM_CONDITIONAL(HAVE_TAGLIB, test "x$have_taglib" = "xyes")
 
 ##################################################################
-# Check for tracker-needle
-##################################################################
-
-AC_ARG_ENABLE([tracker-needle],
-              AS_HELP_STRING([--enable-tracker-needle],
-                             [enable GTK+ UI to search for content [[default=auto]]]),
-              [enable_tracker_needle=$enableval],
-              [enable_tracker_needle=auto])
-
-if test "x$enable_tracker_needle" = "xyes" ; then
-   if test "x$have_tracker_needle" != "xyes"; then
-      AC_MSG_ERROR([Could not find tracker-needle dependencies ($TRACKER_NEEDLE_REQUIRED).])
-   fi
-else
-   if test "x$enable_tracker_needle" = "xno"; then
-      have_tracker_needle="no  (disabled)"
-   fi
-fi
-
-if test "x$have_tracker_needle" = "xyes"; then
-   AC_DEFINE(HAVE_TRACKER_NEEDLE, [1], [Define to 1 if tracker-needle is compiled])
-else
-   AC_DEFINE(HAVE_TRACKER_NEEDLE, [0], [Define to 0 if tracker-needle is not compiled])
-fi
-
-AM_CONDITIONAL(HAVE_TRACKER_NEEDLE, test "$have_tracker_needle" = "yes")
-
-##################################################################
 # Check for tracker-resdump
 ##################################################################
 
@@ -2224,14 +2185,6 @@ AC_CONFIG_FILES([
        src/tracker-store/Makefile
        src/tracker/Makefile
        src/tracker-extract/Makefile
-       src/tracker-needle/Makefile
-       src/tracker-needle/icons/Makefile
-       src/tracker-needle/icons/16x16/Makefile
-       src/tracker-needle/icons/22x22/Makefile
-       src/tracker-needle/icons/24x24/Makefile
-       src/tracker-needle/icons/32x32/Makefile
-       src/tracker-needle/icons/48x48/Makefile
-       src/tracker-needle/icons/scalable/Makefile
        src/tracker-writeback/Makefile
        src/plugins/Makefile
        tests/common/Makefile
@@ -2392,10 +2345,6 @@ Writeback Formats:
 fi
 
 echo "
-Applications:
-
-       Build tracker-needle:                   $have_tracker_needle
-
 Frameworks / Options:
 
        Support Guaranteed Metadata             $enable_guarantee_metadata (e.g. guess nie:title from files)
diff --git a/docs/manpages/Makefile.am b/docs/manpages/Makefile.am
index e261489..31c6545 100644
--- a/docs/manpages/Makefile.am
+++ b/docs/manpages/Makefile.am
@@ -1,4 +1,3 @@
-tn = tracker-needle.1
 tmrss = tracker-miner-rss.1
 
 common = \
@@ -19,10 +18,6 @@ common = \
 # Require only common and enabled manpages
 man_MANS = $(common)
 
-if HAVE_TRACKER_NEEDLE
-man_MANS += $(tn)
-endif
-
 if HAVE_TRACKER_MINER_RSS
 man_MANS += $(tmrss)
 endif
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 042a150..83180e0 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -30,15 +30,6 @@ src/tracker-extract/org.freedesktop.Tracker.Extract.gschema.xml.in
 src/tracker-extract/tracker-extract.c
 src/tracker-extract/tracker-main.c
 src/tracker-extract/tracker-extract.desktop.in.in
-src/tracker-needle/org.freedesktop.Tracker.Needle.gschema.xml.in
-src/tracker-needle/tracker-needle.desktop.in.in
-[type: gettext/glade]src/tracker-needle/tracker-needle.ui
-src/tracker-needle/tracker-needle.vala
-src/tracker-needle/tracker-query.vala
-src/tracker-needle/tracker-stats.vala
-src/tracker-needle/tracker-tags-view.vala
-src/tracker-needle/tracker-utils.vala
-src/tracker-needle/tracker-view.vala
 src/tracker-store/tracker-main.vala
 src/tracker-store/tracker-store.desktop.in.in
 src/tracker-store/org.freedesktop.Tracker.Store.gschema.xml.in
diff --git a/src/Makefile.am b/src/Makefile.am
index 131f1dd..3ff5e7c 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -28,10 +28,6 @@ if HAVE_TRACKER_WRITEBACK
 SUBDIRS += tracker-writeback
 endif
 
-if HAVE_TRACKER_NEEDLE
-SUBDIRS += tracker-needle
-endif
-
 EXTRA_DIST = \
        meson.build \
        create-miner-symlinks.sh \
diff --git a/src/meson.build b/src/meson.build
index 1ea9619..f18903b 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -41,7 +41,4 @@ subdir('tracker')
 # Public shared database
 subdir('tracker-store')
 
-# Example search application
-subdir('tracker-needle')
-
 meson.add_install_script('create-miner-symlinks.sh', dbus_services_dir, tracker_miner_services_dir)
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]