[gnome-control-center] keyboard: make the entire panel scrollable



commit 83555219bb98388d480654de91fe732bbe131181
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Jan 31 08:26:49 2017 -0200

    keyboard: make the entire panel scrollable
    
    The current Keyboard panel allows only the shortcut list to scroll.
    Since we want to add more widgets above the list, and we want them
    to scroll out of sight per the latest mockups [1], making only the
    shortcut list scrollable poses a problem.
    
    Fix that by making the entire panel scrollable.
    
    [1] 
https://github.com/gnome-design-team/gnome-mockups/blob/master/system-settings/keyboard/keyboard-wires.png
    
    https://bugzilla.gnome.org/show_bug.cgi?id=777840

 panels/keyboard/gnome-keyboard-panel.ui |   49 +++++++++++++++++++-----------
 1 files changed, 31 insertions(+), 18 deletions(-)
---
diff --git a/panels/keyboard/gnome-keyboard-panel.ui b/panels/keyboard/gnome-keyboard-panel.ui
index f5c56ca..c5e38bf 100644
--- a/panels/keyboard/gnome-keyboard-panel.ui
+++ b/panels/keyboard/gnome-keyboard-panel.ui
@@ -36,37 +36,50 @@
           <object class="GtkScrolledWindow">
             <property name="visible">True</property>
             <property name="can_focus">True</property>
-            <property name="halign">center</property>
             <property name="hexpand">True</property>
             <property name="vexpand">True</property>
             <property name="hscrollbar_policy">never</property>
             <property name="propagate_natural_width">True</property>
             <property name="propagate_natural_height">True</property>
             <property name="max_content_height">350</property>
-            <property name="shadow_type">in</property>
-            <property name="border_width">18</property>
             <child>
-              <object class="GtkListBox" id="listbox">
+              <object class="GtkBox">
                 <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="selection-mode">none</property>
-                <property name="width-request">250</property>
-                <signal name="row-activated" handler="shortcut_row_activated" object="CcKeyboardPanel" 
swapped="no" />
+                <property name="can_focus">False</property>
+                <property name="orientation">vertical</property>
+                <property name="margin">18</property>
+                <property name="spacing">12</property>
+                <property name="halign">center</property>
                 <child>
-                  <object class="GtkListBoxRow" id="add_shortcut_row">
+                  <object class="GtkFrame">
                     <property name="visible">True</property>
-                    <property name="can_focus">True</property>
+                    <property name="can_focus">False</property>
                     <child>
-                      <object class="GtkBox">
+                      <object class="GtkListBox" id="listbox">
                         <property name="visible">True</property>
-                        <property name="can_focus">False</property>
-                        <property name="hexpand">True</property>
-                        <property name="border_width">6</property>
-                        <child type="center">
-                          <object class="GtkImage">
+                        <property name="can_focus">True</property>
+                        <property name="selection-mode">none</property>
+                        <property name="width-request">250</property>
+                        <signal name="row-activated" handler="shortcut_row_activated" 
object="CcKeyboardPanel" swapped="no" />
+                        <child>
+                          <object class="GtkListBoxRow" id="add_shortcut_row">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
-                            <property name="icon_name">list-add-symbolic</property>
+                            <property name="can_focus">True</property>
+                            <child>
+                              <object class="GtkBox">
+                                <property name="visible">True</property>
+                                <property name="can_focus">False</property>
+                                <property name="hexpand">True</property>
+                                <property name="border_width">6</property>
+                                <child type="center">
+                                  <object class="GtkImage">
+                                    <property name="visible">True</property>
+                                    <property name="can_focus">False</property>
+                                    <property name="icon_name">list-add-symbolic</property>
+                                  </object>
+                                </child>
+                              </object>
+                            </child>
                           </object>
                         </child>
                       </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]