[epiphany] web-extension: Fix logic error in insecure form detection



commit 2ad08ce0664bed0b666491055f639b716ff178aa
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Mon Jan 30 20:14:21 2017 -0600

    web-extension: Fix logic error in insecure form detection
    
    It's causing criticals on pages with password forms.

 embed/web-extension/ephy-web-extension.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/embed/web-extension/ephy-web-extension.c b/embed/web-extension/ephy-web-extension.c
index 3df3934..24890ac 100644
--- a/embed/web-extension/ephy-web-extension.c
+++ b/embed/web-extension/ephy-web-extension.c
@@ -1066,7 +1066,7 @@ sensitive_form_focused_cb (WebKitDOMHTMLFormElement *form,
    * unless it's clearly not. Insecure forms on insecure pages will be detected
    * in the UI process. Note that basically no websites should actually be dumb
    * enough to trip this, but no doubt they exist somewhere.... */
-  insecure_action = action == NULL && g_str_has_prefix (action, "http://";);
+  insecure_action = action != NULL && g_str_has_prefix (action, "http://";);
 
   variant = g_variant_new ("(tb)",
                            webkit_web_page_get_id (web_page),


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]