[gtk+/wip/dboles/combobox-cleanup] combobox: Remove popup_for_device()



commit 2f67488ee9041ad605f9a4b4717b4d6cbd690d56
Author: Daniel Boles <dboles src gnome org>
Date:   Sat Jan 21 21:01:54 2017 +0000

    combobox: Remove popup_for_device()
    
    It does nothing (useful) since list mode is gone. If we want to enable
    device-specific shenanigans for menu mode, we can add it back later.

 docs/reference/gtk/gtk4-sections.txt |    1 -
 gtk/gtkcombobox.c                    |   35 ----------------------------------
 gtk/gtkcombobox.h                    |    3 --
 3 files changed, 0 insertions(+), 39 deletions(-)
---
diff --git a/docs/reference/gtk/gtk4-sections.txt b/docs/reference/gtk/gtk4-sections.txt
index 0275499..cfa7b5e 100644
--- a/docs/reference/gtk/gtk4-sections.txt
+++ b/docs/reference/gtk/gtk4-sections.txt
@@ -649,7 +649,6 @@ gtk_combo_box_get_active_id
 gtk_combo_box_set_active_id
 gtk_combo_box_get_model
 gtk_combo_box_set_model
-gtk_combo_box_popup_for_device
 gtk_combo_box_popup
 gtk_combo_box_popdown
 gtk_combo_box_get_popup_accessible
diff --git a/gtk/gtkcombobox.c b/gtk/gtkcombobox.c
index 71fbe13..8cf939e 100644
--- a/gtk/gtkcombobox.c
+++ b/gtk/gtkcombobox.c
@@ -1634,41 +1634,6 @@ gtk_combo_box_popup (GtkComboBox *combo_box)
     g_signal_emit (combo_box, combo_box_signals[POPUP], 0);
 }
 
-/**
- * gtk_combo_box_popup_for_device:
- * @combo_box: a #GtkComboBox
- * @device: a #GdkDevice
- *
- * Pops up the menu of @combo_box. Note that currently this does not do anything
- * with the device, as it was previously only used for list-mode ComboBoxes,
- * and those were removed in GTK+ 4. However, it is retained in case similar
- * functionality is added back later.
- *
- * Since: 3.0
- **/
-void
-gtk_combo_box_popup_for_device (GtkComboBox *combo_box,
-                                GdkDevice   *device)
-{
-  /* As above, this currently does not do anything useful, and nothing with the
-   * passed-in device. But the bits that are not blatantly obsolete are kept. */
-
-  GtkComboBoxPrivate *priv;
-
-  g_return_if_fail (GTK_IS_COMBO_BOX (combo_box));
-  g_return_if_fail (GDK_IS_DEVICE (device));
-
-  if (!gtk_widget_get_realized (GTK_WIDGET (combo_box)))
-    return;
-
-  priv = combo_box->priv;
-
-  if (gtk_widget_get_mapped (priv->popup_widget))
-    return;
-
-  gtk_combo_box_menu_popup (combo_box, priv->trigger_event);
-}
-
 static void
 gtk_combo_box_real_popup (GtkComboBox *combo_box)
 {
diff --git a/gtk/gtkcombobox.h b/gtk/gtkcombobox.h
index f5172e1..2a2372f 100644
--- a/gtk/gtkcombobox.h
+++ b/gtk/gtkcombobox.h
@@ -155,9 +155,6 @@ gboolean           gtk_combo_box_get_popup_fixed_width  (GtkComboBox      *combo
 GDK_AVAILABLE_IN_ALL
 void          gtk_combo_box_popup            (GtkComboBox     *combo_box);
 GDK_AVAILABLE_IN_ALL
-void          gtk_combo_box_popup_for_device (GtkComboBox     *combo_box,
-                                              GdkDevice       *device);
-GDK_AVAILABLE_IN_ALL
 void          gtk_combo_box_popdown          (GtkComboBox     *combo_box);
 GDK_AVAILABLE_IN_ALL
 AtkObject*    gtk_combo_box_get_popup_accessible (GtkComboBox *combo_box);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]