[gimp/pippin/linear-is-the-new-black: 8/10] app: hide advanced color options



commit 44bad1939a64bb61cefa32bd3c55bb1e04aa05ac
Author: Øyvind Kolås <pippin gimp org>
Date:   Thu Dec 22 15:39:44 2016 +0100

    app: hide advanced color options
    
    This commit should not be picked straight to master, for doing it there a
    preference item we can turn of when 2.10 is released, since we do not want
    users of the stable release ot understand why these toggles are here and what
    they do.

 app/tools/gimpfilteroptions.c |   14 ++++++++------
 app/tools/gimpfiltertool.c    |    7 +++++++
 2 files changed, 15 insertions(+), 6 deletions(-)
---
diff --git a/app/tools/gimpfilteroptions.c b/app/tools/gimpfilteroptions.c
index ef6933a..0e17db7 100644
--- a/app/tools/gimpfilteroptions.c
+++ b/app/tools/gimpfilteroptions.c
@@ -38,7 +38,9 @@ enum
   PROP_PREVIEW_POSITION,
   PROP_REGION,
   PROP_COLOR_MANAGED,
+#if 0
   PROP_GAMMA_HACK,
+#endif
   PROP_SETTINGS
 };
 
@@ -114,7 +116,7 @@ gimp_filter_options_class_init (GimpFilterOptionsClass *klass)
                                                          FALSE,
                                                          GIMP_PARAM_READWRITE |
                                                          G_PARAM_CONSTRUCT));
-
+#if 0
   g_object_class_install_property (object_class, PROP_GAMMA_HACK,
                                    g_param_spec_boolean ("gamma-hack",
                                                          "Gamma hack (temp hack, please ignore)",
@@ -122,7 +124,7 @@ gimp_filter_options_class_init (GimpFilterOptionsClass *klass)
                                                          FALSE,
                                                          GIMP_PARAM_READWRITE |
                                                          G_PARAM_CONSTRUCT));
-
+#endif
   g_object_class_install_property (object_class, PROP_SETTINGS,
                                    g_param_spec_object ("settings",
                                                         NULL, NULL,
@@ -183,11 +185,11 @@ gimp_filter_options_set_property (GObject      *object,
     case PROP_COLOR_MANAGED:
       options->color_managed = g_value_get_boolean (value);
       break;
-
+#if 0
     case PROP_GAMMA_HACK:
       options->gamma_hack = g_value_get_boolean (value);
       break;
-
+#endif
     case PROP_SETTINGS:
       if (options->settings)
         g_object_unref (options->settings);
@@ -233,11 +235,11 @@ gimp_filter_options_get_property (GObject    *object,
     case PROP_COLOR_MANAGED:
       g_value_set_boolean (value, options->color_managed);
       break;
-
+#if 0
     case PROP_GAMMA_HACK:
       g_value_set_boolean (value, options->gamma_hack);
       break;
-
+#endif
     case PROP_SETTINGS:
       g_value_set_object (value, options->settings);
       break;
diff --git a/app/tools/gimpfiltertool.c b/app/tools/gimpfiltertool.c
index 5e85031..6322b11 100644
--- a/app/tools/gimpfiltertool.c
+++ b/app/tools/gimpfiltertool.c
@@ -423,6 +423,7 @@ gimp_filter_tool_initialize (GimpTool     *tool,
                               toggle,                             "sensitive",
                               G_BINDING_SYNC_CREATE);
 
+#if 0
       /*  The Color Options expander  */
       expander = gtk_expander_new (_("Advanced Color Options"));
       gtk_box_pack_end (GTK_BOX (vbox), expander, FALSE, FALSE, 0);
@@ -444,11 +445,15 @@ gimp_filter_tool_initialize (GimpTool     *tool,
       gtk_box_pack_start (GTK_BOX (vbox2), combo, FALSE, FALSE, 0);
       gtk_widget_show (combo);
 
+#if 0
       /*  The gamma hack toggle  */
       toggle = gimp_prop_check_button_new (G_OBJECT (tool_info->tool_options),
                                            "gamma-hack", NULL);
       gtk_box_pack_start (GTK_BOX (vbox2), toggle, FALSE, FALSE, 0);
       gtk_widget_show (toggle);
+#endif
+
+#endif
 
       /*  The area combo  */
       gegl_node_get (filter_tool->operation,
@@ -811,12 +816,14 @@ gimp_filter_tool_options_notify (GimpTool         *tool,
       gimp_drawable_filter_set_color_managed (filter_tool->filter,
                                               filter_options->color_managed);
     }
+#if 0
   else if (! strcmp (pspec->name, "gamma-hack") &&
            filter_tool->filter)
     {
       gimp_drawable_filter_set_gamma_hack (filter_tool->filter,
                                            filter_options->gamma_hack);
     }
+#endif
 }
 
 static gboolean


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]